diff options
author | Max Uvarov <muvarov@gmail.com> | 2017-11-30 13:08:29 +0300 |
---|---|---|
committer | Philippe Schenker <philippe.schenker@toradex.com> | 2019-05-09 11:13:56 +0200 |
commit | e7319a99f18efc04e5ce2142eb610a2009895c21 (patch) | |
tree | 89ecbd85c31ca78e37f36011c9959620c3aa1869 | |
parent | b1c1d8c46c348861995df4dc89d65c39d436d9df (diff) |
net: phy-micrel: check return code in flp center function
Fix obvious typo that first return value is set but not checked.
Signed-off-by: Max Uvarov <muvarov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit a0da456bbf95d2a9294799bb05c61bfb24736bb7)
Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
(cherry picked from commit 5f0a65495d895df2be2ddd681662f877f1a05b7f)
-rw-r--r-- | drivers/net/phy/micrel.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 9ac9923c04a5..0949aab25be0 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -509,16 +509,18 @@ static int ksz9031_of_load_skew_values(struct phy_device *phydev, return ksz9031_extended_write(phydev, OP_DATA, 2, reg, newval); } +/* Center KSZ9031RNX FLP timing at 16ms. */ static int ksz9031_center_flp_timing(struct phy_device *phydev) { int result; - /* Center KSZ9031RNX FLP timing at 16ms. */ result = ksz9031_extended_write(phydev, OP_DATA, 0, MII_KSZ9031RN_FLP_BURST_TX_HI, 0x0006); + if (result) + return result; + result = ksz9031_extended_write(phydev, OP_DATA, 0, MII_KSZ9031RN_FLP_BURST_TX_LO, 0x1A80); - if (result) return result; |