From fd3f9263f8b116993e91a2eab02cfd6b4d12fa64 Mon Sep 17 00:00:00 2001 From: Philippe Schenker Date: Tue, 17 Sep 2019 12:53:41 +0200 Subject: fec_mxc.c: add possibility for phy-reset-post-delay This adds the possibility to add a delay after a reset in DT. Signed-off-by: Philippe Schenker --- arch/arm/dts/fsl-imx8qxp-apalis.dts | 1 + drivers/net/fec_mxc.c | 9 +++++++++ drivers/net/fec_mxc.h | 1 + 3 files changed, 11 insertions(+) diff --git a/arch/arm/dts/fsl-imx8qxp-apalis.dts b/arch/arm/dts/fsl-imx8qxp-apalis.dts index 3a12e1a62d..bc0c257141 100644 --- a/arch/arm/dts/fsl-imx8qxp-apalis.dts +++ b/arch/arm/dts/fsl-imx8qxp-apalis.dts @@ -247,6 +247,7 @@ phy-handle = <ðphy0>; phy-mode = "rgmii"; phy-reset-duration = <10>; + phy-reset-post-delay = <200>; phy-reset-gpios = <&gpio3 4 GPIO_ACTIVE_LOW>; status = "okay"; diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index cb65d1fabd..5e4ad1c6ad 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -1269,6 +1269,7 @@ static void fec_gpio_reset(struct fec_priv *priv) dm_gpio_set_value(&priv->phy_reset_gpio, 1); mdelay(priv->reset_delay); dm_gpio_set_value(&priv->phy_reset_gpio, 0); + mdelay(priv->post_reset_delay); } } #endif @@ -1383,6 +1384,14 @@ static int fecmxc_ofdata_to_platdata(struct udevice *dev) /* property value wrong, use default value */ priv->reset_delay = 1; } + + priv->post_reset_delay = dev_read_u32_default(dev, + "phy-reset-post-delay", 0); + if (priv->post_reset_delay > 1000) { + printf("FEC MXC: phy reset post delay should be <= 1000ms\n"); + /* property value wrong, use default value */ + priv->post_reset_delay = 0; + } #endif return 0; diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h index dd2a0051c0..3e7b833968 100644 --- a/drivers/net/fec_mxc.h +++ b/drivers/net/fec_mxc.h @@ -254,6 +254,7 @@ struct fec_priv { #ifdef CONFIG_DM_GPIO struct gpio_desc phy_reset_gpio; uint32_t reset_delay; + uint32_t post_reset_delay; #endif #ifdef CONFIG_DM_ETH u32 interface; -- cgit v1.2.3