linux-toradex.git/arch/alpha/kernel/pci.c, branch v4.1.5

PCI: Assign resources before drivers claim devices (pci_scan_root_bus())

2015-03-19T15:17:13+00:00

Previously, pci_scan_root_bus() created a root PCI bus, enumerated the
devices on it, and called pci_bus_add_devices(), which made the devices
available for drivers to claim them.

Most callers assigned resources to devices after pci_scan_root_bus()
returns, which may be after drivers have claimed the devices.  This is
incorrect; the PCI core should not change device resources while a driver
is managing the device.

Remove pci_bus_add_devices() from pci_scan_root_bus() and do it after any
resource assignment in the callers.

Note that ARM's pci_common_init_dev() already called pci_bus_add_devices()
after pci_scan_root_bus(), so we only need to remove the first call:

  pci_common_init_dev
    pcibios_init_hw
      pci_scan_root_bus
        pci_bus_add_devices        # first call
    pci_bus_assign_resources
    pci_bus_add_devices            # second call

[bhelgaas: changelog, drop "root_bus" var in alpha common_init_pci(),
return failure earlier in mn10300, add "return" in x86 pcibios_scan_root(),
return early if xtensa platform_pcibios_fixup() fails]
Signed-off-by: Yijing Wang 
Signed-off-by: Bjorn Helgaas 
CC: Richard Henderson 
CC: Ivan Kokshaysky 
CC: Matt Turner 
CC: David Howells 
CC: Tony Luck 
CC: Michal Simek 
CC: Ralf Baechle 
CC: Koichi Yasutake 
CC: Sebastian Ott 
CC: "David S. Miller" 
CC: Chris Metcalf 
CC: Chris Zankel 
CC: Max Filippov 
CC: Thomas Gleixner

alpha/PCI: Clip bridge windows to fit in upstream windows

2015-01-16T16:04:42+00:00

Every PCI-PCI bridge window should fit inside an upstream bridge window
because orphaned address space is unreachable from the primary side of the
upstream bridge.  If we inherit invalid bridge windows that overlap an
upstream window from firmware, clip them to fit and update the bridge
accordingly.

[bhelgaas: changelog]
Link: https://bugzilla.kernel.org/show_bug.cgi?id=85491
Reported-by: Marek Kordik 
Fixes: 5b28541552ef ("PCI: Restrict 64-bit prefetchable bridge windows to 64-bit resources")
Signed-off-by: Yinghai Lu 
Signed-off-by: Bjorn Helgaas 
CC: Richard Henderson 
CC: Ivan Kokshaysky 
CC: Matt Turner 
CC: linux-alpha@vger.kernel.org

alpha/PCI: Use default pcibios_enable_device()

2014-03-19T21:00:14+00:00

We don't need anything arch-specific in pcibios_enable_device(), so drop
the arch implementation and use the default generic one.

Signed-off-by: Bjorn Helgaas 
CC: linux-alpha@vger.kernel.org

ALPHA: drivers: remove __dev* attributes.

2013-01-03T23:57:13+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: Richard Henderson 
Cc: Ivan Kokshaysky 
Signed-off-by: Greg Kroah-Hartman

PCI: Provide a default pcibios_update_irq()

2012-09-18T23:28:21+00:00

Most architectures implement this in exactly the same way. Instead of
having each architecture duplicate this function, provide a single
implementation in the core and make it a weak symbol so that it can be
overridden on architectures where it is required.

Signed-off-by: Thierry Reding 
Signed-off-by: Bjorn Helgaas

PCI: Discard __init annotations for pci_fixup_irqs() and related functions

2012-09-18T23:22:25+00:00

Remove the __init annotations in order to keep pci_fixup_irqs() around
after init (e.g. for hotplug). This requires the same change for the
implementation of pcibios_update_irq() on all architectures. While at
it, all __devinit annotations are removed as well, since they will be
useless now that HOTPLUG is always on.

Signed-off-by: Thierry Reding 
Signed-off-by: Bjorn Helgaas 
Acked-by: Greg Kroah-Hartman

Merge branch 'pci/myron-pcibios_setup' into next

2012-07-05T21:31:05+00:00

* pci/myron-pcibios_setup:
  xtensa/PCI: factor out pcibios_setup()
  x86/PCI: adjust section annotations for pcibios_setup()
  unicore32/PCI: adjust section annotations for pcibios_setup()
  tile/PCI: factor out pcibios_setup()
  sparc/PCI: factor out pcibios_setup()
  sh/PCI: adjust section annotations for pcibios_setup()
  sh/PCI: factor out pcibios_setup()
  powerpc/PCI: factor out pcibios_setup()
  parisc/PCI: factor out pcibios_setup()
  MIPS/PCI: adjust section annotations for pcibios_setup()
  MIPS/PCI: factor out pcibios_setup()
  microblaze/PCI: factor out pcibios_setup()
  ia64/PCI: factor out pcibios_setup()
  cris/PCI: factor out pcibios_setup()
  alpha/PCI: factor out pcibios_setup()
  PCI: pull pcibios_setup() up into core

alpha/PCI: factor out pcibios_setup()

2012-06-26T12:54:28+00:00

The PCI core provides a generic pcibios_setup() routine.  Drop this
architecture-specific version in favor of that.

Acked-by: Richard Henderson 
Signed-off-by: Myron Stowe 
Signed-off-by: Bjorn Helgaas

Merge branch 'topic/sebastian-devinit-fixups' into next

2012-06-18T18:14:10+00:00

* topic/sebastian-devinit-fixups:
  scripts/modpost: check for bad references in .pci.fixups area
  sh/PCI: move fixup hooks from __init to __devinit
  powerpc/PCI: move fixup hooks from __init to __devinit
  frv/PCI: move fixup hooks from __init to __devinit
  arm/PCI: move fixup hooks from __init to __devinit
  alpha/PCI: move fixup hooks from __init to __devinit
  PCI: move fixup hooks from __init to __devinit
  x86/PCI: move fixup hooks from __init to __devinit

PCI: replace struct pci_bus secondary/subordinate with busn_res

2012-06-13T21:42:22+00:00

Replace the struct pci_bus secondary/subordinate members with the
struct resource busn_res.  Later we'll build a resource tree of these
bus numbers.

[bhelgaas: changelog]
Signed-off-by: Yinghai Lu 
Signed-off-by: Bjorn Helgaas