linux-toradex.git/arch/arm/common/locomo.c, branch v3.3.4 Linux kernel for Apalis and Colibri modules arm: Fold irq_set_chip/irq_set_handler 2011-03-29T12:47:58+00:00 Thomas Gleixner tglx@linutronix.de 2011-03-24T12:35:09+00:00 f38c02f3b338651e145aac2889ba976baf6b28b3 Use irq_set_chip_and_handler() instead. Converted with coccinelle. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> 
Use irq_set_chip_and_handler() instead. Converted with coccinelle.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arm: Reorder irq_set_ function calls 2011-03-29T12:47:58+00:00 Thomas Gleixner tglx@linutronix.de 2011-03-24T12:29:39+00:00 9323f26186403433293e87e717a7785f74f75d80 Reorder irq_set_chip() irq_set_chip_data() irq_set_handler() to irq_set_chip() irq_set_handler() irq_set_chip_data() so the next patch can combine irq_set_chip() and irq_set_handler() to irq_set_chip_and_handler(). Automated conversion with coccinelle. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> 
Reorder 
irq_set_chip()
irq_set_chip_data()
irq_set_handler()

to

irq_set_chip()
irq_set_handler()
irq_set_chip_data()

so the next patch can combine irq_set_chip() and irq_set_handler() to
irq_set_chip_and_handler().

Automated conversion with coccinelle.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arm: Cleanup the irq namespace 2011-03-29T12:47:57+00:00 Thomas Gleixner tglx@linutronix.de 2011-03-24T12:25:22+00:00 6845664a6a7d443f03883db59d10749d38d98b8e Convert to the new function names. Automated with coccinelle. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> 
Convert to the new function names. Automated with coccinelle.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
ARM: LoCoMo: irq_data conversion. 2011-01-13T16:18:18+00:00 Lennert Buytenhek buytenh@wantstofly.org 2010-11-29T09:19:01+00:00 680244df886face4d29d3f75d964c8e45e0e8bda Signed-off-by: Lennert Buytenhek <buytenh@secretlab.ca> 
Signed-off-by: Lennert Buytenhek <buytenh@secretlab.ca>
[ARM] locomo: fix unpaired spin_lock_irqsave 2010-03-22T04:03:09+00:00 H Hartley Sweeten hsweeten@visionengravers.com 2010-03-22T03:09:20+00:00 c8c3dcb9df8025ed48f8b14bf4b8a77801d88758 The function locomo_m62332_senddata sends a three byte i2c message to a M62332 DAC. This entire function is guarded with a spin_lock_irqsave at the start of the function and a spin_unlock_irqrestore at the end. As each byte is transferred, the i2c ACK from the DAC is checked. Currently, if the ACK is missing the function simply returns without the unlock. It also leaves the i2c bus in an invalid state since the last byte transferred did not have a "stop" condition and leave the bus idle. Fix this by adding an exit path using goto. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Eric Miao <eric.y.miao@gmail.com> 
The function locomo_m62332_senddata sends a three byte i2c message to
a M62332 DAC. This entire function is guarded with a spin_lock_irqsave
at the start of the function and a spin_unlock_irqrestore at the end.

As each byte is transferred, the i2c ACK from the DAC is checked.
Currently, if the ACK is missing the function simply returns without
the unlock. It also leaves the i2c bus in an invalid state since the
last byte transferred did not have a "stop" condition and leave the
bus idle.

Fix this by adding an exit path using goto.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
[ARM] locomo: fix SPI register offset 2010-03-22T04:03:08+00:00 H Hartley Sweeten hsweeten@visionengravers.com 2010-03-22T02:33:58+00:00 1b0d76cb9d5a65567230097a2512046f09f30523 The locomo spi registers are all defined in locomo.h as offsets from the first spi register LOCOMO_SPI (0x60), which is itself an offset from the locomo base address. To correctly access these registers LOCOMO_SPI must always be included in the address calculation. There are two places in locomo.c where this is not done. The first one, in locomo_suspend, actually results in a write to LOCOMO_ST instead of LOCOMO_SPICT. The second is in __locomo_probe and results in a write to LOCOMO_MCSX2 instead of LOCOMO_SPIIE. Fix these by including LOCOMO_SPI in the calculation. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Eric Miao <eric.y.miao@gmail.com> 
The locomo spi registers are all defined in locomo.h as offsets
from the first spi register LOCOMO_SPI (0x60), which is itself
an offset from the locomo base address.  To correctly access
these registers LOCOMO_SPI must always be included in the
address calculation.

There are two places in locomo.c where this is not done.  The
first one, in locomo_suspend, actually results in a write to
LOCOMO_ST instead of LOCOMO_SPICT.  The second is in __locomo_probe
and results in a write to LOCOMO_MCSX2 instead of LOCOMO_SPIIE.

Fix these by including LOCOMO_SPI in the calculation.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
[ARM] locomo: allow cascaded IRQ base to be specified by platforms 2010-03-01T23:40:50+00:00 Eric Miao eric.y.miao@gmail.com 2010-02-05T02:07:33+00:00 ac609d266e4af4ebf586d610bd76e04dddae0c4c Signed-off-by: Eric Miao <eric.y.miao@gmail.com> 
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
[ARM] locomo: remove unused IRQs and avoid unnecessary cascade 2010-03-01T23:40:49+00:00 Eric Miao eric.y.miao@gmail.com 2009-12-25T04:18:33+00:00 00dd8027b913088ff9b656c5aaa6336c303b7f26 IRQ_LOCOMO_* are never used elsewhere, remove these definitions. As well as the cascade of these IRQs. IRQ_LOCOMO_*_BASE changed to IRQ_LOCOMO_*. IRQ_LOCOMO_LT and IRQ_LOCOMO_SPI are likely to be used in a same way as IRQ_LOCOMO_KEY. IRQ_LOCOMO_GPIO and the demultiplex handler should really be living somewhere else. Signed-off-by: Eric Miao <eric.y.miao@gmail.com> 
IRQ_LOCOMO_* are never used elsewhere, remove these definitions. As well
as the cascade of these IRQs. IRQ_LOCOMO_*_BASE changed to IRQ_LOCOMO_*.

IRQ_LOCOMO_LT and IRQ_LOCOMO_SPI are likely to be used in a same way as
IRQ_LOCOMO_KEY.

IRQ_LOCOMO_GPIO and the demultiplex handler should really be living
somewhere else.

Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
[ARM] locomo: avoid unnecessary cascaded keyboard IRQ 2010-03-01T23:40:49+00:00 Eric Miao eric.y.miao@gmail.com 2010-02-05T01:13:55+00:00 da8065ac3ea29d1bfdb5a163be346fbe35066f8d It is not necessary and is over-complicated for IRQ_LOCOMO_KEY to be a cascaded IRQ of IRQ_LOCOMO_KEY_BASE. Removed and introduced locomokbd_{open,close} for masking/unmasking of the keyboard IRQ. Signed-off-by: Eric Miao <eric.y.miao@gmail.com> 
It is not necessary and is over-complicated for IRQ_LOCOMO_KEY to
be a cascaded IRQ of IRQ_LOCOMO_KEY_BASE. Removed and introduced
locomokbd_{open,close} for masking/unmasking of the keyboard IRQ.

Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
ARM: 5711/1: locomo.c: CodingStyle cleanups 2009-09-21T15:03:04+00:00 Hartley Sweeten hartleys@visionengravers.com 2009-09-18T19:40:27+00:00 9c5e8fecc4a86adbf363f5cf344c0ccccdbb8982 EXPORT* macros should follow immediately after the closing function brace line. The prototype for locomo_chip_driver() is not needed since the static (inline) function is located earlier in the file. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> 
EXPORT* macros should follow immediately after the closing function
brace line.

The prototype for locomo_chip_driver() is not needed since the static
(inline) function is located earlier in the file.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>