linux-toradex.git/arch/hexagon/include, branch v6.16

mm: pgtable: fix pte_swp_exclusive

2025-06-11T21:52:08+00:00

Make pte_swp_exclusive return bool instead of int.  This will better
reflect how pte_swp_exclusive is actually used in the code.

This fixes swap/swapoff problems on Alpha due pte_swp_exclusive not
returning correct values when _PAGE_SWP_EXCLUSIVE bit resides in upper
32-bits of PTE (like on alpha).

Suggested-by: Al Viro 
Signed-off-by: Magnus Lindholm 
Cc: Sam James 
Link: https://lore.kernel.org/lkml/20250218175735.19882-2-linmag7@gmail.com/
Link: https://lore.kernel.org/lkml/20250602041118.GA2675383@ZenIV/
[ Applied as the 'sed' script Al suggested   - Linus ]
Signed-off-by: Linus Torvalds

syscall.h: introduce syscall_set_nr()

2025-05-12T00:48:15+00:00

Similar to syscall_set_arguments() that complements
syscall_get_arguments(), introduce syscall_set_nr() that complements
syscall_get_nr().

syscall_set_nr() is going to be needed along with syscall_set_arguments()
on all HAVE_ARCH_TRACEHOOK architectures to implement
PTRACE_SET_SYSCALL_INFO API.

Link: https://lkml.kernel.org/r/20250303112020.GD24170@strace.io
Signed-off-by: Dmitry V. Levin 
Tested-by: Charlie Jenkins 
Reviewed-by: Charlie Jenkins 
Acked-by: Helge Deller  # parisc
Reviewed-by: Maciej W. Rozycki  # mips
Cc: Alexander Gordeev 
Cc: Alexey Gladkov (Intel) 
Cc: Andreas Larsson 
Cc: anton ivanov 
Cc: Arnd Bergmann 
Cc: Borislav Betkov 
Cc: Brian Cain 
Cc: Christian Borntraeger 
Cc: Christian Zankel 
Cc: Christophe Leroy 
Cc: Dave Hansen 
Cc: Davide Berardi 
Cc: David S. Miller 
Cc: Dinh Nguyen 
Cc: Eugene Syromiatnikov 
Cc: Eugene Syromyatnikov 
Cc: Geert Uytterhoeven 
Cc: Guo Ren 
Cc: Heiko Carstens 
Cc: "H. Peter Anvin" 
Cc: Huacai Chen 
Cc: Ingo Molnar 
Cc: Johannes Berg 
Cc: John Paul Adrian Glaubitz 
Cc: Jonas Bonn 
Cc: Madhavan Srinivasan 
Cc: Max Filippov 
Cc: Michael Ellerman 
Cc: Michal Simek 
Cc: Mike Frysinger 
Cc: Naveen N Rao 
Cc: Nicholas Piggin 
Cc: Oleg Nesterov 
Cc: Renzo Davoi 
Cc: Richard Weinberger 
Cc: Rich Felker 
Cc: Russel King 
Cc: Shuah Khan 
Cc: Stafford Horne 
Cc: Stefan Kristiansson 
Cc: Sven Schnelle 
Cc: Thomas Gleinxer 
Cc: Vasily Gorbik 
Cc: Vineet Gupta 
Cc: WANG Xuerui 
Cc: Will Deacon 
Cc: Yoshinori Sato 
Signed-off-by: Andrew Morton

syscall.h: add syscall_set_arguments()

2025-05-12T00:48:15+00:00

This function is going to be needed on all HAVE_ARCH_TRACEHOOK
architectures to implement PTRACE_SET_SYSCALL_INFO API.

This partially reverts commit 7962c2eddbfe ("arch: remove unused function
syscall_set_arguments()") by reusing some of old syscall_set_arguments()
implementations.

[nathan@kernel.org: fix compile time fortify checks]
  Link: https://lkml.kernel.org/r/20250408213131.GA2872426@ax162
Link: https://lkml.kernel.org/r/20250303112009.GC24170@strace.io
Signed-off-by: Dmitry V. Levin 
Signed-off-by: Nathan Chancellor 
Tested-by: Charlie Jenkins 
Reviewed-by: Charlie Jenkins 
Acked-by: Helge Deller  # parisc
Reviewed-by: Maciej W. Rozycki 	[mips]
Cc: Alexander Gordeev 
Cc: Alexey Gladkov (Intel) 
Cc: Andreas Larsson 
Cc: anton ivanov 
Cc: Arnd Bergmann 
Cc: Borislav Betkov 
Cc: Brian Cain 
Cc: Christian Borntraeger 
Cc: Christian Zankel 
Cc: Christophe Leroy 
Cc: Dave Hansen 
Cc: Davide Berardi 
Cc: David S. Miller 
Cc: Dinh Nguyen 
Cc: Eugene Syromiatnikov 
Cc: Eugene Syromyatnikov 
Cc: Geert Uytterhoeven 
Cc: Guo Ren 
Cc: Heiko Carstens 
Cc: "H. Peter Anvin" 
Cc: Huacai Chen 
Cc: Ingo Molnar 
Cc: Johannes Berg 
Cc: John Paul Adrian Glaubitz 
Cc: Jonas Bonn 
Cc: Madhavan Srinivasan 
Cc: Max Filippov 
Cc: Michael Ellerman 
Cc: Michal Simek 
Cc: Mike Frysinger 
Cc: Naveen N Rao 
Cc: Nicholas Piggin 
Cc: Oleg Nesterov 
Cc: Renzo Davoi 
Cc: Richard Weinberger 
Cc: Rich Felker 
Cc: Russel King 
Cc: Shuah Khan 
Cc: Stafford Horne 
Cc: Stefan Kristiansson 
Cc: Sven Schnelle 
Cc: Thomas Gleinxer 
Cc: Vasily Gorbik 
Cc: Vineet Gupta 
Cc: WANG Xuerui 
Cc: Will Deacon 
Cc: Yoshinori Sato 
Signed-off-by: Andrew Morton

hexagon: add syscall_set_return_value()

2025-05-12T00:48:14+00:00

Patch series "ptrace: introduce PTRACE_SET_SYSCALL_INFO API", v7.

PTRACE_SET_SYSCALL_INFO is a generic ptrace API that complements
PTRACE_GET_SYSCALL_INFO by letting the ptracer modify details of system
calls the tracee is blocked in.

This API allows ptracers to obtain and modify system call details in a
straightforward and architecture-agnostic way, providing a consistent way
of manipulating the system call number and arguments across architectures.

As in case of PTRACE_GET_SYSCALL_INFO, PTRACE_SET_SYSCALL_INFO also does
not aim to address numerous architecture-specific system call ABI
peculiarities, like differences in the number of system call arguments for
such system calls as pread64 and preadv.

The current implementation supports changing only those bits of system
call information that are used by strace system call tampering, namely,
syscall number, syscall arguments, and syscall return value.

Support of changing additional details returned by
PTRACE_GET_SYSCALL_INFO, such as instruction pointer and stack pointer,
could be added later if needed, by using struct ptrace_syscall_info.flags
to specify the additional details that should be set.  Currently, "flags"
and "reserved" fields of struct ptrace_syscall_info must be initialized
with zeroes; "arch", "instruction_pointer", and "stack_pointer" fields are
currently ignored.

PTRACE_SET_SYSCALL_INFO currently supports only PTRACE_SYSCALL_INFO_ENTRY,
PTRACE_SYSCALL_INFO_EXIT, and PTRACE_SYSCALL_INFO_SECCOMP operations. 
Other operations could be added later if needed.

Ideally, PTRACE_SET_SYSCALL_INFO should have been introduced along with
PTRACE_GET_SYSCALL_INFO, but it didn't happen.  The last straw that
convinced me to implement PTRACE_SET_SYSCALL_INFO was apparent failure to
provide an API of changing the first system call argument on riscv
architecture [1].

ptrace(2) man page:

long ptrace(enum __ptrace_request request, pid_t pid, void *addr, void *data);
...
PTRACE_SET_SYSCALL_INFO
       Modify information about the system call that caused the stop.
       The "data" argument is a pointer to struct ptrace_syscall_info
       that specifies the system call information to be set.
       The "addr" argument should be set to sizeof(struct ptrace_syscall_info)).


This patch (of 6):

hexagon is the only architecture that provides HAVE_ARCH_TRACEHOOK but
doesn't define syscall_set_return_value().  Since this function is going
to be needed on all HAVE_ARCH_TRACEHOOK architectures to implement
PTRACE_SET_SYSCALL_INFO API, add it on hexagon, too.

Link: https://lore.kernel.org/all/59505464-c84a-403d-972f-d4b2055eeaac@gmail.com/ [1]
Link: https://lkml.kernel.org/r/20250303111953.GB24170@strace.io
Signed-off-by: Dmitry V. Levin 
Cc: Alexander Gordeev 
Cc: Alexey Gladkov (Intel) 
Cc: Andreas Larsson 
Cc: anton ivanov 
Cc: Arnd Bergmann 
Cc: Borislav Betkov 
Cc: Brian Cain 
Cc: Charlie Jenkins 
Cc: Christian Borntraeger 
Cc: Christian Zankel 
Cc: Christophe Leroy 
Cc: Dave Hansen 
Cc: Davide Berardi 
Cc: David S. Miller 
Cc: Dinh Nguyen 
Cc: Eugene Syromyatnikov 
Cc: Geert Uytterhoeven 
Cc: Guo Ren 
Cc: Heiko Carstens 
Cc: Helge Deller 
Cc: "H. Peter Anvin" 
Cc: Huacai Chen 
Cc: Ingo Molnar 
Cc: Johannes Berg 
Cc: John Paul Adrian Glaubitz 
Cc: Jonas Bonn 
Cc: Maciej W. Rozycki 
Cc: Madhavan Srinivasan 
Cc: Max Filippov 
Cc: Michael Ellerman 
Cc: Michal Simek 
Cc: Mike Frysinger 
Cc: Naveen N Rao 
Cc: Nicholas Piggin 
Cc: Oleg Nesterov 
Cc: Renzo Davoi 
Cc: Richard Weinberger 
Cc: Rich Felker 
Cc: Russel King 
Cc: Shuah Khan 
Cc: Stafford Horne 
Cc: Stefan Kristiansson 
Cc: Sven Schnelle 
Cc: Thomas Gleinxer 
Cc: Vasily Gorbik 
Cc: Vineet Gupta 
Cc: WANG Xuerui 
Cc: Will Deacon 
Cc: Yoshinori Sato 
Cc: Eugene Syromiatnikov 
Signed-off-by: Andrew Morton

mm: introduce a common definition of mk_pte()

2025-05-12T00:48:02+00:00

Most architectures simply call pfn_pte().  Centralise that as the normal
definition and remove the definition of mk_pte() from the architectures
which have either that exact definition or something similar.

Link: https://lkml.kernel.org/r/20250402181709.2386022-3-willy@infradead.org
Signed-off-by: Matthew Wilcox (Oracle) 
Acked-by: Geert Uytterhoeven  # m68k
Acked-by: David Hildenbrand 
Reviewed-by: Alexander Gordeev  # s390
Cc: Zi Yan 
Cc: Andreas Larsson 
Cc: Anton Ivanov 
Cc: Dave Hansen 
Cc: "David S. Miller" 
Cc: Johannes Berg 
Cc: Muchun Song 
Cc: Richard Weinberger 
Cc: 
Signed-off-by: Andrew Morton

mm: pgtable: convert some architectures to use tlb_remove_ptdesc()

2025-04-01T22:17:13+00:00

Now, the nine architectures of csky, hexagon, loongarch, m68k, mips,
nios2, openrisc, sh and um do not select CONFIG_MMU_GATHER_RCU_TABLE_FREE,
and just call pagetable_dtor() + tlb_remove_page_ptdesc() (the wrapper of
tlb_remove_page()).  This is the same as the implementation of
tlb_remove_{ptdesc|table}() under !CONFIG_MMU_GATHER_TABLE_FREE, so
convert these architectures to use tlb_remove_ptdesc().

The ultimate goal is to make the architecture only use tlb_remove_ptdesc()
or tlb_remove_table() for page table pages.

[zhengqi.arch@bytedance.com: v2]
  Link: https://lkml.kernel.org/r/20250303072603.45423-1-zhengqi.arch@bytedance.com
[akpm@linux-foundation.org: remove trailing semi in arch/loongarch/include/asm/pgalloc.h]
Link: https://lkml.kernel.org/r/19db3e8673b67bad2f1df1ab37f1c89d99eacfea.1740454179.git.zhengqi.arch@bytedance.com
Signed-off-by: Qi Zheng 
Suggested-by: Peter Zijlstra (Intel) 
Reviewed-by: Kevin Brodsky 
Acked-by: Geert Uytterhoeven 	[m68k]
Cc: Alexandre Ghiti 
Cc: "Aneesh Kumar K.V" 
Cc: Arnd Bergmann 
Cc: Dave Hansen 
Cc: David Hildenbrand 
Cc: Hugh Dickens 
Cc: Jann Horn 
Cc: Matthew Wilcow (Oracle) 
Cc: "Mike Rapoport (IBM)" 
Cc: Muchun Song 
Cc: Nicholas Piggin 
Cc: Rik van Riel 
Cc: Vishal Moola (Oracle) 
Cc: Will Deacon 
Cc: Yu Zhao 
Signed-off-by: Andrew Morton

hexagon: Move kernel prototypes out of uapi/asm/setup.h header

2025-01-31T02:45:45+00:00

The kernel function prototypes are of no use for userspace and
shouldn't get exposed in an uapi header, so let's move them into
an internal header instead.

Signed-off-by: Thomas Huth 
Link: https://lore.kernel.org/r/20240502173818.58152-1-thuth@redhat.com
Signed-off-by: Brian Cain 
Signed-off-by: Brian Cain

hexagon: fix using plain integer as NULL pointer warning in cmpxchg

2025-01-31T02:44:54+00:00

Sparse reports

    net/ipv4/inet_diag.c:1511:17: sparse: sparse: Using plain integer as NULL pointer

Due to this code calling cmpxchg on a non-integer type
struct inet_diag_handler *

    return !cmpxchg((const struct inet_diag_handler**)&inet_diag_table[type],
                    NULL, h) ? 0 : -EEXIST;

While hexagon's cmpxchg assigns an integer value to a variable of this
type.

    __typeof__(*(ptr)) __oldval = 0;

Update this assignment to cast 0 to the correct type.

The original issue is easily reproduced at head with the below block,
and is absent after this change.

    make LLVM=1 ARCH=hexagon defconfig
    make C=1 LLVM=1 ARCH=hexagon net/ipv4/inet_diag.o

Fixes: 99a70aa051d2 ("Hexagon: Add processor and system headers")
Reported-by: kernel test robot 
Closes: https://lore.kernel.org/oe-kbuild-all/202411091538.PGSTqUBi-lkp@intel.com/
Signed-off-by: Willem de Bruijn 
Tested-by: Christian Gmeiner 
Link: https://lore.kernel.org/r/20241203221736.282020-1-willemdebruijn.kernel@gmail.com
Signed-off-by: Brian Cain 
Signed-off-by: Brian Cain

asm-generic: pgalloc: provide generic __pgd_{alloc,free}

2025-01-26T04:22:24+00:00

We already have a generic implementation of alloc/free up to P4D level, as
well as pgd_free().  Let's finish the work and add a generic PGD-level
alloc helper as well.

Unlike at lower levels, almost all architectures need some specific magic
at PGD level (typically initialising PGD entries), so introducing a
generic pgd_alloc() isn't worth it.  Instead we introduce two new helpers,
__pgd_alloc() and __pgd_free(), and make use of them in the arch-specific
pgd_alloc() and pgd_free() wherever possible.  To accommodate as many arch
as possible, __pgd_alloc() takes a page allocation order.

Because pagetable_alloc() allocates zeroed pages, explicit zeroing in
pgd_alloc() becomes redundant and we can get rid of it.  Some trivial
implementations of pgd_free() also become unnecessary once __pgd_alloc()
is used; remove them.

Another small improvement is consistent accounting of PGD pages by using
GFP_PGTABLE_{USER,KERNEL} as appropriate.

Not all PGD allocations can be handled by the generic helpers.  In
particular, multiple architectures allocate PGDs from a kmem_cache, and
those PGDs may not be page-sized.

Link: https://lkml.kernel.org/r/20250103184415.2744423-6-kevin.brodsky@arm.com
Signed-off-by: Kevin Brodsky 
Acked-by: Dave Hansen 
Acked-by: Qi Zheng 
Cc: Andy Lutomirski 
Cc: Catalin Marinas 
Cc: Ingo Molnar 
Cc: Linus Walleij 
Cc: Matthew Wilcox (Oracle) 
Cc: Mike Rapoport (Microsoft) 
Cc: Peter Zijlstra 
Cc: Ryan Roberts 
Cc: Thomas Gleixner 
Cc: Will Deacon 
Signed-off-by: Andrew Morton

mm: pgtable: introduce pagetable_dtor()

2025-01-26T04:22:22+00:00

The pagetable_p*_dtor() are exactly the same except for the handling of
ptlock.  If we make ptlock_free() handle the case where ptdesc->ptl is
NULL and remove VM_BUG_ON_PAGE() from pmd_ptlock_free(), we can unify
pagetable_p*_dtor() into one function.  Let's introduce pagetable_dtor()
to do this.

Later, pagetable_dtor() will be moved to tlb_remove_ptdesc(), so that
ptlock and page table pages can be freed together (regardless of whether
RCU is used).  This prevents the use-after-free problem where the ptlock
is freed immediately but the page table pages is freed later via RCU.

Link: https://lkml.kernel.org/r/47f44fff9dc68d9d9e9a0d6c036df275f820598a.1736317725.git.zhengqi.arch@bytedance.com
Signed-off-by: Qi Zheng 
Originally-by: Peter Zijlstra (Intel) 
Reviewed-by: Kevin Brodsky 
Acked-by: Alexander Gordeev 	[s390]
Cc: Alexandre Ghiti 
Cc: Alexandre Ghiti 
Cc: Andreas Larsson 
Cc: Aneesh Kumar K.V (Arm) 
Cc: Arnd Bergmann 
Cc: Dave Hansen 
Cc: David Hildenbrand 
Cc: David Rientjes 
Cc: Hugh Dickins 
Cc: Jann Horn 
Cc: Lorenzo Stoakes 
Cc: Matthew Wilcox (Oracle) 
Cc: Mike Rapoport (Microsoft) 
Cc: Muchun Song 
Cc: Nicholas Piggin 
Cc: Palmer Dabbelt 
Cc: Ryan Roberts 
Cc: Thomas Gleixner 
Cc: Vishal Moola (Oracle) 
Cc: Will Deacon 
Cc: Yu Zhao 
Signed-off-by: Andrew Morton