linux-toradex.git/arch/m68k/mac/psc.c, branch v4.4.126 Linux kernel for Apalis and Colibri modules m68k/mac: Export Peripheral System Controller (PSC) base address to modules 2015-09-30T04:11:13+00:00 Geert Uytterhoeven geert@linux-m68k.org 2015-09-29T08:24:05+00:00 a77cdaaf2dbc69743bc22354f81bc4ec5e452d40 If CONFIG_MACMACE=m: ERROR: psc [drivers/net/ethernet/apple/macmace.ko] undefined! Add the missing export to fix this. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: David S. Miller <davem@davemloft.net> 
If CONFIG_MACMACE=m:

    ERROR: psc [drivers/net/ethernet/apple/macmace.ko] undefined!

Add the missing export to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
genirq: Remove irq argument from irq flow handlers 2015-09-16T13:47:51+00:00 Thomas Gleixner tglx@linutronix.de 2015-09-14T08:42:37+00:00 bd0b9ac405e1794d72533c3d487aa65b6b955a0c Most interrupt flow handlers do not use the irq argument. Those few which use it can retrieve the irq number from the irq descriptor. Remove the argument. Search and replace was done with coccinelle and some extra helper scripts around it. Thanks to Julia for her help! Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Jiang Liu <jiang.liu@linux.intel.com> 
Most interrupt flow handlers do not use the irq argument. Those few
which use it can retrieve the irq number from the irq descriptor.

Remove the argument.

Search and replace was done with coccinelle and some extra helper
scripts around it. Thanks to Julia for her help!

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Jiang Liu <jiang.liu@linux.intel.com>
m68k/irq: Prepare irq handlers for irq argument removal 2015-08-01T06:07:22+00:00 Thomas Gleixner tglx@linutronix.de 2015-07-31T19:56:10+00:00 625b86ad26ad35200adc34094c04e04672384735 The irq argument of most interrupt flow handlers is unused or merily used instead of a local variable. The handlers which need the irq argument can retrieve the irq number from the irq descriptor. Search and update was done with coccinelle and the invaluable help of Julia Lawall. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: linux-m68k@lists.linux-m68k.org 
The irq argument of most interrupt flow handlers is unused or merily
used instead of a local variable. The handlers which need the irq
argument can retrieve the irq number from the irq descriptor.

Search and update was done with coccinelle and the invaluable help of
Julia Lawall.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
m68k/psc: Fix race in installing chained IRQ handler 2015-06-25T09:57:54+00:00 Thomas Gleixner tglx@linutronix.de 2015-06-21T19:00:30+00:00 09c5cb942f7545e53819ee2ca72fe843d23880e5 Fix a race where a pending interrupt could be received and the handler called before the handler's data has been setup, by converting to irq_set_chained_handler_and_data(). Search and conversion was done with coccinelle: @@ expression E1, E2, E3; @@ ( -if (irq_set_chained_handler(E1, E3) != 0) - BUG(); | -irq_set_chained_handler(E1, E3); ) -irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2); @@ expression E1, E2, E3; @@ ( -if (irq_set_chained_handler(E1, E3) != 0) - BUG(); ... | -irq_set_chained_handler(E1, E3); ... ) -irq_set_handler_data(E1, E2); +irq_set_chained_handler_and_data(E1, E3, E2); Reported-by: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Joshua Thompson <funaho@jurai.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: linux-m68k@lists.linux-m68k.org 
Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Search and conversion was done with coccinelle:

@@
expression E1, E2, E3;
@@
(
-if (irq_set_chained_handler(E1, E3) != 0)
-   BUG();
|
-irq_set_chained_handler(E1, E3);
)
-irq_set_handler_data(E1, E2);
+irq_set_chained_handler_and_data(E1, E3, E2);

@@
expression E1, E2, E3;
@@
(
-if (irq_set_chained_handler(E1, E3) != 0)
-   BUG();
...
|
-irq_set_chained_handler(E1, E3);
...
)
-irq_set_handler_data(E1, E2);
+irq_set_chained_handler_and_data(E1, E3, E2);

Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Joshua Thompson <funaho@jurai.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
m68k: Remove superfluous inclusions of <asm/bootinfo.h> 2013-11-26T10:09:22+00:00 Geert Uytterhoeven geert@linux-m68k.org 2013-10-05T19:14:22+00:00 371001e502e8cd3543f7b9907d398a112939dff7 Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> 
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
m68k: Mark functions only called from setup_arch() __init 2013-11-26T10:08:54+00:00 Geert Uytterhoeven geert@linux-m68k.org 2013-06-25T19:15:24+00:00 a4df02a217e9787a4b967197d9d9030c3e3c1088 Some functions that are only called (indirectly) from setup_arch() lack __init annotations. Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> 
Some functions that are only called (indirectly) from setup_arch() lack
__init annotations.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
m68k/mac: cleanup mac_irq_pending 2011-12-10T18:52:46+00:00 Finn Thain fthain@telegraphics.com.au 2011-10-23T14:11:14+00:00 30c0527d15ce4edcde64581e9d062ba9fb08fe16 mac_irq_pending() has only one caller (mac_esp.c). Nothing tests for Baboon, PSC or OSS pending interrupts. Until that need arises, let's keep it simple and remove all the unused abstraction. Replace it with a routine to check for SCSI DRQ. Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> 
mac_irq_pending() has only one caller (mac_esp.c). Nothing tests for Baboon, PSC or OSS pending interrupts. Until that need arises, let's keep it simple and remove all the unused abstraction. Replace it with a routine to check for SCSI DRQ.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
m68k/mac: cleanup mac_clear_irq 2011-12-10T18:52:45+00:00 Finn Thain fthain@telegraphics.com.au 2011-10-23T14:11:13+00:00 56e63689fd866a865682fe14dc5a7e1ec3b2c3ad mac_clear_irq() is dead code and has been dead for as long as I can recall. On certain Mac models, certain irqs can't be cleared this way. Outside of irq dispatch, this code appears be unusable without busy loops or worse, and for irq dispatch we duplicate the same logic. Remove mac_clear_irq() and supporting code. Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> 
mac_clear_irq() is dead code and has been dead for as long as I can recall. On certain Mac models, certain irqs can't be cleared this way. Outside of irq dispatch, this code appears be unusable without busy loops or worse, and for irq dispatch we duplicate the same logic. Remove mac_clear_irq() and supporting code.

Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
m68k/irq: Remove obsolete m68k irq framework 2011-11-08T21:35:52+00:00 Geert Uytterhoeven geert@linux-m68k.org 2011-09-11T09:28:04+00:00 d890d73995257b4e10cdd7d55bad80e34a71ba22 Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> 
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
m68k/mac: Optimize interrupts using chain handlers 2011-11-08T21:35:50+00:00 Geert Uytterhoeven geert@linux-m68k.org 2011-08-10T10:48:29+00:00 9145db564eae98134de8eb8d64b47d7177eccfdd Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> 
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>