linux-toradex.git/arch/microblaze/kernel/kgdb.c, branch v6.3

microblaze: fix typos in comments

2022-05-02T06:36:10+00:00

Various spelling mistakes in comments.
Detected with the help of Coccinelle.

Signed-off-by: Julia Lawall 
Link: https://lore.kernel.org/r/20220430191122.8667-1-Julia.Lawall@inria.fr
Signed-off-by: Michal Simek

kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops

2018-12-30T08:33:06+00:00

checkpatch.pl reports the following:

  WARNING: struct kgdb_arch should normally be const
  #28: FILE: arch/mips/kernel/kgdb.c:397:
  +struct kgdb_arch arch_kgdb_ops = {

This report makes sense, as all other ops struct, this
one should also be const. This patch does the change.

Cc: Vineet Gupta 
Cc: Russell King 
Cc: Catalin Marinas 
Cc: Will Deacon 
Cc: Yoshinori Sato 
Cc: Richard Kuo 
Cc: Michal Simek 
Cc: Ralf Baechle 
Cc: Paul Burton 
Cc: James Hogan 
Cc: Ley Foon Tan 
Cc: Benjamin Herrenschmidt 
Cc: Paul Mackerras 
Cc: Michael Ellerman 
Cc: Rich Felker 
Cc: "David S. Miller" 
Cc: Thomas Gleixner 
Cc: Ingo Molnar 
Cc: Borislav Petkov 
Cc: x86@kernel.org
Acked-by: Daniel Thompson 
Acked-by: Paul Burton 
Signed-off-by: Christophe Leroy 
Acked-by: Borislav Petkov 
Acked-by: Michael Ellerman  (powerpc)
Signed-off-by: Daniel Thompson

microblaze: Label local function static

2015-06-08T07:57:08+00:00

Warnings found by sparse:
arch/microblaze/kernel/dma.c:157:5: warning: symbol
'dma_direct_mmap_coherent' was not declared. Should it be static?
arch/microblaze/kernel/kgdb.c:35:14: warning: symbol 'pvr' was not
declared. Should it be static?

Signed-off-by: Michal Simek

microblaze: Use unsigned type for "for" loop because of comparison-kgdb.c

2015-01-05T11:36:45+00:00

This patch removes warnings reported by W=1:
arch/microblaze/kernel/kgdb.c: In function 'pt_regs_to_gdb_regs':
arch/microblaze/kernel/kgdb.c:43:16: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare]
arch/microblaze/kernel/kgdb.c:51:16: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare]
arch/microblaze/kernel/kgdb.c: In function 'gdb_regs_to_pt_regs':
arch/microblaze/kernel/kgdb.c:77:16: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare]
arch/microblaze/kernel/kgdb.c: In function
'sleeping_thread_to_gdb_regs':
arch/microblaze/kernel/kgdb.c:99:16: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare]
arch/microblaze/kernel/kgdb.c:103:16: warning: comparison between signed
and unsigned integer expressions [-Wsign-compare]

Signed-off-by: Michal Simek

microblaze: Declare microblaze_kgdb_break in header

2015-01-05T11:36:42+00:00

This patch removes the warning:
arch/microblaze/kernel/kgdb.c:81:6: warning: no previous prototype for
'microblaze_kgdb_break' [-Wmissing-prototypes]

Signed-off-by: Michal Simek

microblaze: Don't mark arch_kgdb_ops as const.

2013-06-26T09:36:55+00:00

Other architectures don't do it, and it conflicts with the extern'd definition
in include/linux/kgdb.h.

The patch fails checkpatch but it reflects current
functions declaration and solved compilation error.

Signed-off-by: Graeme Smecher 
CC: Michal Simek 
CC: linux-kernel@vger.kernel.org
Signed-off-by: Michal Simek

microblaze: Fix coding style issues

2013-02-12T10:24:45+00:00

Fix coding style issues reported by checkpatch.pl.

Signed-off-by: Michal Simek

microblaze: KGDB little endian support

2010-10-21T05:51:58+00:00

Just need to use little-endian opcode for brki r16, 0x18

Signed-off-by: Michal Simek 
CC: Jason Wessel

microblaze: kgdb: Remove unused variable and fix return value

2010-10-21T05:51:19+00:00

I forget to remove unused variable from kgdb_arch_handle_exception.
Fix return value in microblaze_kgdb_break function.

Error log:
arch/microblaze/kernel/kgdb.c: In function 'microblaze_kgdb_break':
arch/microblaze/kernel/kgdb.c:83: warning: 'return' with a value, in function returning void
arch/microblaze/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':
arch/microblaze/kernel/kgdb.c:119: warning: unused variable 'cpu'

Signed-off-by: Michal Simek

microblaze: Add KGDB support

2010-08-04T08:45:17+00:00

Kgdb uses brki r16, 0x18 instruction to call
low level _debug_exception function which save
current state to pt_regs and call microblaze_kgdb_break
function. _debug_exception should be called only from
the kernel space. User space calling is not supported
because user application debugging uses different handling.

pt_regs_to_gdb_regs loads additional special registers
which can't be changed

 * Enable KGDB in Kconfig
 * Remove ancient not-tested KGDB support
 * Remove ancient _debug_exception code from entry.S

Only MMU KGDB support is supported.

Signed-off-by: Michal Simek 
CC: Jason Wessel 
CC: John Williams 
CC: Edgar E. Iglesias 
CC: linux-kernel@vger.kernel.org
Acked-by: Jason Wessel