linux-toradex.git/arch/mips/include/asm/mach-ralink, branch v6.7

mips: ralink: mt7620: remove clock related code

2023-06-21T12:50:23+00:00

A proper clock driver for ralink SoCs has been added. Hence there is no
need to have clock related code in 'arch/mips/ralink' folder anymore.
Since this is the last clock related code removal, remove also remaining
prototypes in 'common.h' header file.

Signed-off-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer

mips: ralink: rt3883: remove clock related code

2023-06-21T12:50:22+00:00

A properly clock driver for ralink SoCs has been added. Hence there is no
need to have clock related code in 'arch/mips/ralink' folder anymore.

Signed-off-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer

mips: ralink: rt305x: remove clock related code

2023-06-21T12:50:22+00:00

A properly clock driver for ralink SoCs has been added. Hence there is no
need to have clock related code in 'arch/mips/ralink' folder anymore.

Signed-off-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer

mips: ralink: rt288x: remove clock related code

2023-06-21T12:50:22+00:00

A properly clock driver for ralink SoCs has been added. Hence there is no
need to have clock related code in 'arch/mips/ralink' folder anymore.

Signed-off-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer

mips: ralink: mt7620: define MT7620_SYSC_BASE with __iomem

2023-03-14T16:13:51+00:00

So that MT7620_SYSC_BASE can be used later in multiple functions without
needing to repeat this __iomem declaration each time

Signed-off-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer

mips: ralink: rt288x: define RT2880_SYSC_BASE with __iomem

2023-03-14T16:13:50+00:00

 So that RT2880_SYSC_BASE can be used later in multiple functions without
 needing to repeat this __iomem declaration each time

Signed-off-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer

mips: ralink: rt3883: define RT3883_SYSC_BASE with __iomem

2023-03-14T16:13:50+00:00

So that RT3883_SYSC_BASE can be used later in multiple functions without
needing to repeat this __iomem declaration each time

Signed-off-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer

mips: ralink: rt305x: define RT305X_SYSC_BASE with __iomem

2023-03-14T16:13:50+00:00

So that RT305X_SYSC_BASE can be used later in multiple functions without
needing to repeat this __iomem declaration each time

Signed-off-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer

mips: ralink: mt7621: define MT7621_SYSC_BASE with __iomem

2022-12-01T12:32:42+00:00

So that MT7621_SYSC_BASE can be used later in multiple functions without
needing to repeat this __iomem declaration each time

Signed-off-by: John Thomson 
Signed-off-by: Thomas Bogendoerfer

MIPS: RALINK: Define pci_remap_iospace under CONFIG_PCI_DRIVERS_GENERIC

2022-05-26T08:12:11+00:00

kernel test robot reports a build error used with clang compiler and
mips-randconfig [1]:

    ld.lld: error: undefined symbol: pci_remap_iospace

we can see the following configs in the mips-randconfig file:

    CONFIG_RALINK=y
    CONFIG_SOC_MT7620=y
    CONFIG_PCI_DRIVERS_LEGACY=y
    CONFIG_PCI=y

CONFIG_RALINK is set, so pci_remap_iospace is defined in the related
arch/mips/include/asm/mach-ralink/spaces.h header file:

    #define pci_remap_iospace pci_remap_iospace

CONFIG_PCI is set, so pci_remap_iospace() in drivers/pci/pci.c is not
built due to pci_remap_iospace is defined under CONFIG_RALINK.

    #ifndef pci_remap_iospace
    int pci_remap_iospace(const struct resource *res, ...)

    $ objdump -d drivers/pci/pci.o | grep pci_remap_iospace
    00004cc8 :
        4d18:	10400008 	beqz	v0,4d3c 
        4d2c:	1040000c 	beqz	v0,4d60 
        4d70:	1000fff3 	b	4d40 

In addition, CONFIG_PCI_DRIVERS_GENERIC is not set, so pci_remap_iospace()
in arch/mips/pci/pci-generic.c is not built too.

    #ifdef pci_remap_iospace
    int pci_remap_iospace(const struct resource *res, ...)

For the above reasons, undefined reference pci_remap_iospace() looks like
reasonable.

Here are simple steps to reproduce used with gcc and defconfig:

    cd mips.git
    make vocore2_defconfig # set RALINK, SOC_MT7620, PCI_DRIVERS_LEGACY
    make menuconfig        # set PCI
    make

there exists the following build error:

      LD      vmlinux.o
      MODPOST vmlinux.symvers
      MODINFO modules.builtin.modinfo
      GEN     modules.builtin
      LD      .tmp_vmlinux.kallsyms1
    drivers/pci/pci.o: In function `devm_pci_remap_iospace':
    pci.c:(.text+0x4d24): undefined reference to `pci_remap_iospace'
    Makefile:1158: recipe for target 'vmlinux' failed
    make: *** [vmlinux] Error 1

Define pci_remap_iospace under CONFIG_PCI_DRIVERS_GENERIC can fix the build
error, with this patch, no build error remains. This patch is similar with
commit e538e8649892 ("MIPS: asm: pci: define arch-specific
'pci_remap_iospace()' dependent on 'CONFIG_PCI_DRIVERS_GENERIC'").

[1] https://lore.kernel.org/lkml/202205251247.nQ5cxSV6-lkp@intel.com/

Fixes: 09d97da660ff ("MIPS: Only define pci_remap_iospace() for Ralink")
Reported-by: kernel test robot 
Signed-off-by: Tiezhu Yang 
Acked-by: Sergio Paracuellos 
Signed-off-by: Thomas Bogendoerfer