linux-toradex.git/arch/powerpc/kernel/udbg_16550.c, branch v4.1

powerpc: Fix bad NULL pointer check in udbg_uart_getc_poll()

2014-11-12T02:47:20+00:00

We have some code in udbg_uart_getc_poll() that tries to protect
against a NULL udbg_uart_in, but gets it all wrong.

Found with the LLVM static analyzer (scan-build).

Fixes: 309257484cc1 ("powerpc: Cleanup udbg_16550 and add support for LPC PIO-only UARTs")
Signed-off-by: Anton Blanchard 
[mpe: Add some newlines for readability while we're here]
Signed-off-by: Michael Ellerman

powerpc: Remove platforms/wsp and associated pieces

2014-06-11T06:35:38+00:00

__attribute__ ((unused))

WSP is the last user of CONFIG_PPC_A2, so we remove that as well.

Although CONFIG_PPC_ICSWX still exists, it's no longer selectable for
any Book3E platform, so we can remove the code in mmu-book3e.h that
depended on it.

Signed-off-by: Michael Ellerman 
Signed-off-by: Benjamin Herrenschmidt

powerpc/wsp: Fix early debug build

2013-08-16T00:59:27+00:00

When reworking udbg_16550.c I forgot to remove the old and now useless
code for the CONFIG_PPC_EARLY_DEBUG_WSP case, which doesn't build as
a result. I also missed a cast.

Signed-off-by: Benjamin Herrenschmidt

powerpc: Cleanup udbg_16550 and add support for LPC PIO-only UARTs

2013-08-14T04:58:15+00:00

The udbg_16550 code, which we use for our early consoles and debug
backends was fairly messy. Especially for the debug consoles, it
would re-implement the "high level" getc/putc/poll functions for
each access method. It also had code to configure the UART but only
for the straight MMIO method.

This changes it to instead abstract at the register accessor level,
and have the various functions and configuration routines use these.

The result is simpler and slightly smaller code, and free support
for non-MMIO mapped PIO UARTs, which such as the ones that can be
present on a POWER 8 LPC bus.

Signed-off-by: Benjamin Herrenschmidt

powerpc: Add early debug for WSP platforms

2011-05-06T03:32:41+00:00

Signed-off-by: Jack Miller 
Signed-off-by: Michael Ellerman 
Signed-off-by: Benjamin Herrenschmidt

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

trivial: fix typo "for for" in multiple files

2009-09-21T13:14:54+00:00

trivial: fix typo "for for" in multiple files

Signed-off-by: Anand Gadiyar 
Signed-off-by: Jiri Kosina

powerpc/440: Fix warning early debug code

2009-06-26T06:55:35+00:00

The function udbg_44x_as1_flush() has the wrong prototype causing
a warning when enabling 440 early debug.

Signed-off-by: Benjamin Herrenschmidt

powerpc/udbg: Fix lost byte during console handover; change LFCR to CRLF

2009-03-11T06:11:34+00:00

When the console is on a serial port to be driven by serial8250, a
character can be lost from the end of the first line in the two-line
sequence

	serial8250.0: ttyS0 at MMIO 0xe0004500 (irq = 42) is a 16550A
	console handover: boot [udbg0] -> real [ttyS0]

This happens because udbg_puts or udbg_write stuff the last byte of
the line into the Tx FIFO and return, whereupon the serial8250
initialization code immediately empties that FIFO.  The fix: udbg_puts
and udbg_write now wait for the Tx FIFO to clear before returning.
This delays the system by one additional serial frame time for each
line written by udbg, but the effect is not noticeable, a cumulative
17 milliseconds for 200 lines of early printk output at 115200 baud.

Also, the routines in udbg_16550.c now emit CRLF instead of LFCR.
Linux makes a point of emitting CRLF because, when serial output is
captured to a file, LFCR sequences can confuse text editors.  See
http://lkml.org/lkml/2006/2/4/50 for some history.

Signed-off-by: Andrew Klossner 
Signed-off-by: Benjamin Herrenschmidt

powerpc: Unsigned speed cannot be negative in udbg_16559.c

2008-10-21T04:17:47+00:00

"unsigned int" speed cannot be negative, it's thus pointless
to test if it is.

Signed-off-by: Roel Kluin 
Signed-off-by: Benjamin Herrenschmidt