linux-toradex.git/arch/powerpc/sysdev/mpic.c, branch v4.2.7

powerpc: Constify irq_domain_ops

2015-05-11T06:58:20+00:00

The irq_domain_ops are not modified by the driver and the irqdomain core
code accepts pointer to a const data.

Signed-off-by: Krzysztof Kozlowski 
Signed-off-by: Michael Ellerman

powerpc: Drop return value of smp_ops->probe()

2015-04-10T10:02:49+00:00

smp_ops->probe() is currently supposed to return the number of cpus in
the system.

The last actual usage of the value was removed in May 2007 in e147ec8f1808
"[POWERPC] Simplify smp_space_timers". We still passed the value around
until June 2010 when even that was finally removed in c1aa687d499a
"powerpc: Clean up obsolete code relating to decrementer and timebase".

So drop that requirement, probe() now returns void, and update all
implementations.

Signed-off-by: Michael Ellerman

powerpc/mpic: Remove WHOAMI readback after EOI

2015-04-01T03:23:20+00:00

After previous discussions regarding the subject [1][2], there's no clear
explanation or reason why the call was needed in the first place. The sensible
argument is some sort of synchronization between the CPU and the MPIC, which
hasn't been pointed out precisely and is no longer required (at least on BookE
platforms).

The benefit of this change is saving a MMIO trap per interrupt when running in a
KVM guest.

[1] https://patchwork.ozlabs.org/patch/429098/
[2] https://patchwork.ozlabs.org/patch/433557/

Signed-off-by: Bogdan Purcareata 
Signed-off-by: Scott Wood

powerpc/mpic: Add get_version API both for internal and external use

2015-03-24T00:51:17+00:00

MPIC version is useful information for both mpic_alloc() and mpic_init().
The patch provide an API to get MPIC version for reusing the code.
Also, some other IP block may need MPIC version for their own use.
The API for external use is also provided.

This function had been previously added but was removed by commit
5e86bfde9cd93f2 ("powerpc/mpic: remove unused functions") due to the
lack of a user.  This function will be used by "powerpc/mpic: Add
get_version API both for internal and external use".

Signed-off-by: Jia Hongtao 
Signed-off-by: Li Yang 
[scottwood@freescale.com: changelog update]
Signed-off-by: Scott Wood

powerpc/mpic: remove unused functions

2015-03-16T07:50:18+00:00

Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(),
mpic_set_serial_int().

  + fsl_mpic_primary_get_version() is just a safe wrapper around
fsl_mpic_get_version() for SMP configurations. While the latter is
called explicitly for handling PIC initialization and setting up error
interrupt vector depending on PIC hardware version, the former isn't
used for anything.

  + As for mpic_set_clk_ratio() and mpic_set_serial_int(), they both are
almost nine years old[1] but still have no chance to be called even from
out-of-tree modules because they both are __init and of course aren't
exported.

[1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2006-June/023867.html

Signed-off-by: Arseny Solokha 
Cc: hongtao.jia@freescale.com
Signed-off-by: Michael Ellerman

powerpc: Replace cpumask_weight(cpu_possible_mask) with num_possible_cpus()

2015-01-23T03:02:51+00:00

num_possible_cpus() is just a shorthand for it.

Signed-off-by: Emil Medve 
Signed-off-by: Michael Ellerman

powerpc: Remove superfluous bootmem includes

2014-11-09T22:59:26+00:00

Lots of places included bootmem.h even when not using bootmem.

Signed-off-by: Anton Blanchard 
Tested-by: Emil Medve 
Signed-off-by: Michael Ellerman

powerpc: Make a bunch of things static

2014-09-25T13:14:41+00:00

Signed-off-by: Anton Blanchard 
Signed-off-by: Michael Ellerman

powerpc/mpic: Don't init the fsl error int until after mpic init

2014-05-22T23:08:30+00:00

Besides other potential problems, if MPIC_NO_RESET is  not set,
the error interrupt will be masked after it is requested.

Signed-off-by: Scott Wood

powerpc: Fix build failure in sysdev/mpic.c for MPIC_WEIRD=y

2014-02-11T00:24:45+00:00

Commit 446f6d06fab0b49c61887ecbe8286d6aaa796637 ("powerpc/mpic: Properly
set default triggers") breaks the mpc7447_hpc_defconfig as follows:

  CC      arch/powerpc/sysdev/mpic.o
arch/powerpc/sysdev/mpic.c: In function 'mpic_set_irq_type':
arch/powerpc/sysdev/mpic.c:886:9: error: case label does not reduce to an integer constant
arch/powerpc/sysdev/mpic.c:890:9: error: case label does not reduce to an integer constant
arch/powerpc/sysdev/mpic.c:894:9: error: case label does not reduce to an integer constant
arch/powerpc/sysdev/mpic.c:898:9: error: case label does not reduce to an integer constant

Looking at the cpp output (gcc 4.7.3), I see:

   case mpic->hw_set[MPIC_IDX_VECPRI_SENSE_EDGE] |
        mpic->hw_set[MPIC_IDX_VECPRI_POLARITY_POSITIVE]:

The pointer into an array appears because CONFIG_MPIC_WEIRD=y is set
for this platform, thus enabling the following:

  -------------------
  #ifdef CONFIG_MPIC_WEIRD
  static u32 mpic_infos[][MPIC_IDX_END] = {
        [0] = { /* Original OpenPIC compatible MPIC */

  [...]

  #define MPIC_INFO(name) mpic->hw_set[MPIC_IDX_##name]

  #else /* CONFIG_MPIC_WEIRD */

  #define MPIC_INFO(name) MPIC_##name

  #endif /* CONFIG_MPIC_WEIRD */
  -------------------

Here we convert the case section to if/else if, and also add
the equivalent of a default case to warn about unknown types.
Boot tested on sbc8548, build tested on all defconfigs.

Signed-off-by: Paul Gortmaker 
Signed-off-by: Benjamin Herrenschmidt