linux-toradex.git/arch/s390/oprofile, branch v3.0.68

oprofile: Fix uninitialized memory access when writing to writing to oprofilefs

2012-01-06T22:13:51+00:00

commit 913050b91eb94f194392dd797b1ff3779f606ac0 upstream.

If oprofilefs_ulong_from_user() is called with count equals
zero, *val remains unchanged. Depending on the implementation it
might be uninitialized.

Change oprofilefs_ulong_from_user()'s interface to return count
on success. Thus, we are able to return early if count equals
zero which avoids using *val uninitialized. Fixing all users of
oprofilefs_ulong_ from_user().

This follows write syscall implementation when count is zero:
"If count is zero ... [and if] no errors are detected, 0 will be
returned without causing any other effect." (man 2 write)

Reported-By: Mike Waychison 
Signed-off-by: Robert Richter 
Cc: Andrew Morton 
Cc: oprofile-list 
Link: http://lkml.kernel.org/r/20111219153830.GH16765@erda.amd.com
Signed-off-by: Ingo Molnar 
Signed-off-by: Greg Kroah-Hartman

[S390] hwsampler: Set a sane default sampling rate

2011-06-22T14:24:20+00:00

The sampling interval for the hardware sampler is specified in cycles.
(see SA23-2260-01 The Load-Program-Parameter and the CPU-Measurement
Facilities)
The current default value will therefore result in millions of samples.
This patch changes the default sampling interval to 4M, which will
result in ~1500 samples per second on a z196 reducing the overhead
of sampling.

Signed-off-by: Christian Borntraeger 
Signed-off-by: Martin Schwidefsky

[S390] s390: enforce HW limits for the initial sampling rate

2011-06-22T14:24:20+00:00

On specific configurations with hwsampler opcontrol --start returns an
error on "echo 1 >/dev/oprofile/enable". Turns out that the hw sampling
interval is not checked against the hardware limits.

Signed-off-by: Christian Borntraeger 
Signed-off-by: Martin Schwidefsky

[S390] hwsampler: allow cpu hotplug

2011-05-26T07:48:25+00:00

The hardware sample cpu hotplug notifier always returns NOTIFY_BAD.
That will prevent cpu hotplug if the machine is enabled for hardware
sampling even if it is not used. Fix the cpu hotplug notifier and
allow cpu hotplug if hardware sampling is unused.

Signed-off-by: Martin Schwidefsky 
Signed-off-by: Heiko Carstens

[S390] irq: merge irq.c and s390_ext.c

2011-05-26T07:48:24+00:00

Merge irq.c and s390_ext.c into irq.c. That way all external interrupt
related functions are together.

Signed-off-by: Heiko Carstens 
Signed-off-by: Martin Schwidefsky

[S390] oprofile: dont access lowcore

2011-05-23T08:24:32+00:00

The external interrupt parameter is passed as function call parameter.
No need to access lowcore.

Signed-off-by: Heiko Carstens

[S390] oprofile: add missing irq stats counter

2011-05-23T08:24:32+00:00

Count CPU measurement external interrupts as well.

Signed-off-by: Heiko Carstens

[S390] s390,oprofile: fix compile error for !CONFIG_SMP

2011-05-23T08:24:32+00:00

Use ctl_set_bit instead of the smp_ctl_set_bit (likewise for clear bit)
to prevent the following build error for !CONFIG_SMP:

  CC      arch/s390/oprofile/hwsampler.o
arch/s390/oprofile/hwsampler.c: In function ‘hwsampler_deallocate’:
arch/s390/oprofile/hwsampler.c:1012: error: implicit declaration of function ‘smp_ctl_clear_bit’
arch/s390/oprofile/hwsampler.c: In function ‘hwsampler_start_all’:
arch/s390/oprofile/hwsampler.c:1201: error: implicit declaration of function ‘smp_ctl_set_bit’
  CC      kernel/seccomp.o
make[1]: *** [arch/s390/oprofile/hwsampler.o] Error 1
make: *** [arch/s390/oprofile] Error 2

Signed-off-by: Jan Glauber 
Signed-off-by: Martin Schwidefsky

[S390] s390,oprofile: fix alert counter increment

2011-05-23T08:24:32+00:00

The counter for requested interrupts should be incremented if the
program-request-alert bit is set and not the invalid-address-entry
bit.

Signed-off-by: Jan Glauber 
Signed-off-by: Martin Schwidefsky

[S390] oprofile: fix min/max interval query checks

2011-05-10T15:13:43+00:00

oprofile_min_interval and oprofile_max_interval are unsigned, checking
for negative values doesn't work. Change hwsampler_query_min_interval
and hwsampler_query_max_interval to return an unsigned long and
check for a zero value instead.

Reported-by: Nicolas Kaiser 
Acked-by: Robert Richter 
Signed-off-by: Martin Schwidefsky