linux-toradex.git/arch/sparc/kernel/ds.c, branch v3.10.73

sparc: fix ldom_reboot buffer overflow harder

2013-10-13T23:08:32+00:00

[ Upstream commit 20928bd3f08afb036c096d9559d581926b895918 ]

The length argument to strlcpy was still wrong. It could overflow the end of
full_boot_str by 5 bytes. Instead of strcat and strlcpy, just use snprint.

Reported-by: Brad Spengler 
Signed-off-by: Kees Cook 
Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

sparc64: Fix buggy strlcpy() conversion in ldom_reboot().

2013-10-13T23:08:32+00:00

[ Upstream commit 2bd161a605f1f84a5fc8a4fe8410113a94f79355 ]

Commit 117a0c5fc9c2d06045bd217385b2b39ea426b5a6 ("sparc: kernel: using
strlcpy() instead of strcpy()") added a bug to ldom_reboot in
arch/sparc/kernel/ds.c

-		strcpy(full_boot_str + strlen("boot "), boot_command);
+				     strlcpy(full_boot_str + strlen("boot "), boot_command,
+				     			     sizeof(full_boot_str + strlen("boot ")));

That last sizeof() expression evaluates to sizeof(size_t) which is
not what was intended.

Also even the corrected:

     sizeof(full_boot_str) + strlen("boot ")

is not right as the destination buffer length is just plain
"sizeof(full_boot_str)" and that's what the final argument
should be.

Signed-off-by: David S. Miller 
Signed-off-by: Greg Kroah-Hartman

sparc: kernel: using strlcpy() instead of strcpy()

2013-06-19T09:10:29+00:00

'boot_command_line' and 'full_boot_str' has a fix length, 'cmdline_p' and
'boot_command' maybe larger than them. So use strlcpy() instead of strcpy()
to avoid memory overflow.

Signed-off-by: Zhao Hongjiang 
Signed-off-by: David S. Miller

SPARC: drivers: remove __dev* attributes.

2013-01-03T23:57:04+00:00

CONFIG_HOTPLUG is going away as an option.  As a result, the __dev*
markings need to be removed.

This change removes the use of __devinit, __devexit_p, __devinitdata,
and __devexit from these drivers.

Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.

Cc: Bill Pemberton 
Cc: "David S. Miller" 
Signed-off-by: Greg Kroah-Hartman

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc

2012-04-13T20:32:07+00:00

sparc64: Fix bootup crash on sun4v.

2012-04-13T18:56:22+00:00

The DS driver registers as a subsys_initcall() but this can be too
early, in particular this risks registering before we've had a chance
to allocate and setup module_kset in kernel/params.c which is
performed also as a subsyts_initcall().

Register DS using device_initcall() insteal.

Signed-off-by: David S. Miller 
Cc: stable@vger.kernel.org

powerpc+sparc/vio: Modernize driver registration

2012-03-28T00:33:24+00:00

This makes vio_register_driver() get the module owner & name at compile
time like PCI drivers do, and adds a name pointer directly in struct
vio_driver to avoid having to explicitly initialize the embedded
struct device.

Signed-off-by: Benjamin Herrenschmidt 
Acked-by: David S. Miller

sparc: Use vsprintf extention %pf with builtin_return_address

2012-02-28T21:08:02+00:00

Emit the function name not the address when possible.

builtin_return_address() gives an address.  When building
a kernel with CONFIG_KALLSYMS, emit the actual function
name not the address.

Signed-off-by: Joe Perches 
Signed-off-by: David S. Miller

sparc: Use kmemdup rather than duplicating its implementation

2011-12-04T18:46:56+00:00

The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer 
Signed-off-by: David S. Miller

sparc: Don't do hypervisor calls on non-sun4v in DS driver.

2011-08-12T00:58:59+00:00

Reported-by: Pieter-Paul Giesberts 
Signed-off-by: David S. Miller