linux-toradex.git/arch/um/drivers, branch tegra

um: fix ubd cow size

2011-11-11T17:43:35+00:00

commit 8535639810e578960233ad39def3ac2157b0c3ec upstream.

ubd_file_size() cannot use ubd_dev->cow.file because at this time
ubd_dev->cow.file is not initialized.
Therefore, ubd_file_size() will always report a wrong disk size when
COW files are used.
Reading from /dev/ubd* would crash the kernel.

We have to read the correct disk size from the COW file's backing
file.

Signed-off-by: Richard Weinberger 
Signed-off-by: Greg Kroah-Hartman

um: fix free_winch() mess

2011-09-15T01:09:37+00:00

while not doing free_irq() from irq handler is commendable, kfree() on the
data passed to said handler before free_irq() is Not Good(tm).  Freeing
the stack it's being run on is also not nice...  Solution: delay actually
freeing stuff.

Signed-off-by: Al Viro 
Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

um: winch_interrupt() can happen inside of free_winch()

2011-09-15T01:09:37+00:00

...  so set winch->fd to -1 before doing free_irq(), to avoid having
winch_interrupt() come from/during the latter and attempt to do
reactivate_fd() on something that's already gone.

Signed-off-by: Al Viro 
Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

um: fix oopsable race in line_close()

2011-09-15T01:09:37+00:00

tty->count is decremented only after ->close() had been called and
several tasks can hit it in parallel.  As the result, using tty->count
to check if you are the last one is broken.  We end up leaving line->tty
not reset to NULL and the next IRQ on that sucker will blow up trying to
dereference pointers from kfree'd struct tty.

Fix is obvious: we need to use a counter of our own.

Signed-off-by: Al Viro 
Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

um: drivers/xterm.c: fix a file descriptor leak

2011-09-15T01:09:37+00:00

I could use out_close1, but that seems to be the code path to close the fd
returned by os_create_unix_socket, and using it to close the fd returned
by mkstemp might lead to some confusion, so I don't do it.

Signed-off-by: Jonathan Neuschäfer 
Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

um: remove dead code

2011-07-26T03:57:13+00:00

GCC 4.6's -Wunused-but-set-variable found some dead code.

Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

um: adjust size of pid_buf

2011-07-26T03:57:13+00:00

Linux can have pids up to 4*1024*1024.  To handle such huge numbers
pid_buf needs to be larger.

Reported-by: Geert Uytterhoeven 
Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

uml: drivers/slip_user.c memory leak fix

2011-07-26T03:57:13+00:00

Do not free memory when you failed to allocate it.

Signed-off-by: Vitaliy Ivanov 
Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

uml: cow_user.c warning corrections

2011-07-26T03:57:13+00:00

Fix this warning:

  arch/um/drivers/cow_user.c: In function `absolutize':
  arch/um/drivers/cow_user.c:189:7: warning: ignoring return value of `chdir', declared with attribute warn_unused_result

[richard@nod.at: happens only with -D_FORTIFY_SOURCE=2]
Signed-off-by: Vitaliy Ivanov 
Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

uml: drivers/net_user.c memory leak fix

2011-07-26T03:57:12+00:00

Perform memory cleanup on exit.  On receiving invalid 'pid' we still
should clean 'output' variable.

Signed-off-by: Vitaliy Ivanov 
Signed-off-by: Richard Weinberger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds