linux-toradex.git/arch/x86/oprofile, branch v3.0.95

oprofile, x86: Fix wrapping bug in op_x86_get_ctrl()

2012-10-28T17:02:11+00:00

commit 44009105081b51417f311f4c3be0061870b6b8ed upstream.

The "event" variable is a u16 so the shift will always wrap to zero
making the line a no-op.

Signed-off-by: Dan Carpenter 
Signed-off-by: Robert Richter 
Signed-off-by: Greg Kroah-Hartman

oprofile, x86: Fix crash when unloading module (nmi timer mode)

2011-12-09T16:52:44+00:00

commit 97f7f8189fe54e3cfe324ef9ad35064f3d2d3bff upstream.

If oprofile uses the nmi timer interrupt there is a crash while
unloading the module. The bug can be triggered with oprofile build as
module and kernel parameter nolapic set. This patch fixes this.

oprofile: using NMI timer interrupt.
BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
IP: [] unregister_syscore_ops+0x41/0x58
PGD 42dbca067 PUD 41da6a067 PMD 0
Oops: 0002 [#1] PREEMPT SMP
CPU 5
Modules linked in: oprofile(-) [last unloaded: oprofile]

Pid: 2518, comm: modprobe Not tainted 3.1.0-rc7-00019-gb2fb49d #19 Advanced Micro Device Anaheim/Anaheim
RIP: 0010:[]  [] unregister_syscore_ops+0x41/0x58
RSP: 0018:ffff88041ef71e98  EFLAGS: 00010296
RAX: 0000000000000000 RBX: ffffffffa0017100 RCX: dead000000200200
RDX: 0000000000000000 RSI: dead000000100100 RDI: ffffffff8178c620
RBP: ffff88041ef71ea8 R08: 0000000000000001 R09: 0000000000000082
R10: 0000000000000000 R11: ffff88041ef71de8 R12: 0000000000000080
R13: fffffffffffffff5 R14: 0000000000000001 R15: 0000000000610210
FS:  00007fc902f20700(0000) GS:ffff88042fd40000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 0000000000000008 CR3: 000000041cdb6000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process modprobe (pid: 2518, threadinfo ffff88041ef70000, task ffff88041d348040)
Stack:
 ffff88041ef71eb8 ffffffffa0017790 ffff88041ef71eb8 ffffffffa0013532
 ffff88041ef71ec8 ffffffffa00132d6 ffff88041ef71ed8 ffffffffa00159b2
 ffff88041ef71f78 ffffffff81073115 656c69666f72706f 0000000000610200
Call Trace:
 [] op_nmi_exit+0x15/0x17 [oprofile]
 [] oprofile_arch_exit+0xe/0x10 [oprofile]
 [] oprofile_exit+0x1e/0x20 [oprofile]
 [] sys_delete_module+0x1c3/0x22f
 [] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [] system_call_fastpath+0x16/0x1b
Code: 20 c6 78 81 e8 c5 cc 23 00 48 8b 13 48 8b 43 08 48 be 00 01 10 00 00 00 ad de 48 b9 00 02 20 00 00 00 ad de 48 c7 c7 20 c6 78 81
 89 42 08 48 89 10 48 89 33 48 89 4b 08 e8 a6 c0 23 00 5a 5b
RIP  [] unregister_syscore_ops+0x41/0x58
 RSP 
CR2: 0000000000000008
---[ end trace 43a541a52956b7b0 ]---

Signed-off-by: Robert Richter 
Signed-off-by: Greg Kroah-Hartman

oprofile, x86: Fix nmi-unsafe callgraph support

2011-08-05T04:58:37+00:00

commit a0e3e70243f5b270bc3eca718f0a9fa5e6b8262e upstream.

Current oprofile's x86 callgraph support may trigger page faults
throwing the BUG_ON(in_nmi()) message below. This patch fixes this by
using the same nmi-safe copy-from-user code as in perf.

------------[ cut here ]------------
kernel BUG at .../arch/x86/kernel/traps.c:436!
invalid opcode: 0000 [#1] SMP
last sysfs file: /sys/devices/pci0000:00/0000:00:0a.0/0000:07:00.0/0000:08:04.0/net/eth0/broadcast
CPU 5
Modules linked in:

Pid: 8611, comm: opcontrol Not tainted 2.6.39-00007-gfe47ae7 #1 Advanced Micro Device Anaheim/Anaheim
RIP: 0010:[]  [] do_nmi+0x22/0x1ee
RSP: 0000:ffff88042fd47f28  EFLAGS: 00010002
RAX: ffff88042c0a7fd8 RBX: 0000000000000001 RCX: 00000000c0000101
RDX: 00000000ffff8804 RSI: ffffffffffffffff RDI: ffff88042fd47f58
RBP: ffff88042fd47f48 R08: 0000000000000004 R09: 0000000000001484
R10: 0000000000000001 R11: 0000000000000000 R12: ffff88042fd47f58
R13: 0000000000000000 R14: ffff88042fd47d98 R15: 0000000000000020
FS:  00007fca25e56700(0000) GS:ffff88042fd40000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000074 CR3: 000000042d28b000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process opcontrol (pid: 8611, threadinfo ffff88042c0a6000, task ffff88042c532310)
Stack:
 0000000000000000 0000000000000001 ffff88042c0a7fd8 0000000000000000
 ffff88042fd47de8 ffffffff813e897a 0000000000000020 ffff88042fd47d98
 0000000000000000 ffff88042c0a7fd8 ffff88042fd47de8 0000000000000074
Call Trace:
 
 [] nmi+0x1a/0x20
 [] ? bad_to_user+0x25/0x771
 <>
Code: ff 59 5b 41 5c 41 5d c9 c3 55 65 48 8b 04 25 88 b5 00 00 48 89 e5 41 55 41 54 49 89 fc 53 48 83 ec 08 f6 80 47 e0 ff ff 04 74 04 <0f> 0b eb fe 81 80 44 e0 ff ff 00 00 01 04 65 ff 04 25 c4 0f 01
RIP  [] do_nmi+0x22/0x1ee
 RSP 
---[ end trace ed6752185092104b ]---
Kernel panic - not syncing: Fatal exception in interrupt
Pid: 8611, comm: opcontrol Tainted: G      D     2.6.39-00007-gfe47ae7 #1
Call Trace:
   [] panic+0x8c/0x188
 [] oops_end+0x81/0x8e
 [] die+0x55/0x5e
 [] do_trap+0x11c/0x12b
 [] do_invalid_op+0x91/0x9a
 [] ? do_nmi+0x22/0x1ee
 [] ? oprofile_add_sample+0x83/0x95
 [] ? op_amd_check_ctrs+0x4f/0x2cf
 [] invalid_op+0x15/0x20
 [] ? do_nmi+0x22/0x1ee
 [] ? do_nmi+0x67/0x1ee
 [] nmi+0x1a/0x20
 [] ? bad_to_user+0x25/0x771
 <>

Cc: John Lumby 
Cc: Maynard Johnson 
Signed-off-by: Robert Richter 
Signed-off-by: Greg Kroah-Hartman

oprofile, x86: Fix race in nmi handler while starting counters

2011-06-15T12:31:29+00:00

In some rare cases, nmis are generated immediately after the nmi
handler of the cpu was started. This causes the counter not to be
enabled. Before enabling the nmi handlers we need to set variable
ctr_running first and make sure its value is written to memory.

Also, the patch makes all existing barriers a memory barrier instead
of a compiler barrier only.

Reported-by: Suravee Suthikulpanit 
Cc:  # .35+
Signed-off-by: Robert Richter

Merge branch 'urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile into perf/urgent

2011-06-08T13:49:03+00:00

oprofile, x86: Add comments to IBS LVT offset initialization

2011-05-30T14:36:54+00:00

Adding a comment in the code as IBS LVT setup is not obvious at all ...

Signed-off-by: Robert Richter

Merge branch 'urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile into perf/urgent

2011-05-27T12:08:09+00:00

oprofile, x86: Enable preemption during pci device setup in IBS init

2011-05-20T15:11:10+00:00

IBS initialization is a mix of per-core register access and per-node
pci device setup. Register access should be pinned to the cpu, but pci
setup must run with preemption enabled.

This patch better separates the code into non-/preemptible sections
and fixes sleeping with preemption disabled. See bug message below.

Fixes also freeing the eilvt entry by introducing put_eilvt().

BUG: sleeping function called from invalid context at mm/slub.c:824
in_atomic(): 1, irqs_disabled(): 0, pid: 32357, name: modprobe
INFO: lockdep is turned off.
Pid: 32357, comm: modprobe Not tainted 2.6.39-rc7+ #14
Call Trace:
 [] __might_sleep+0x112/0x117
 [] kmem_cache_alloc_trace+0x4b/0xe7
 [] kzalloc.constprop.0+0x29/0x2b
 [] pci_get_subsys+0x36/0x78
 [] ? setup_APIC_eilvt+0xfb/0x139
 [] pci_get_device+0x16/0x18
 [] op_amd_init+0xd3/0x211 [oprofile]
 [] ? 0xffffffffa064cfff
 [] op_nmi_init+0x21e/0x26a [oprofile]
 [] oprofile_arch_init+0xe/0x26 [oprofile]
 [] oprofile_init+0x10/0x42 [oprofile]
 [] do_one_initcall+0x7f/0x13a
 [] sys_init_module+0x132/0x281
 [] system_call_fastpath+0x16/0x1b

Reported-by: Dave Jones 
Cc:          [2.6.37.x]
Signed-off-by: Robert Richter

x86: Remove warning and warning_symbol from struct stacktrace_ops

2011-05-12T13:31:28+00:00

Both warning and warning_symbol are nowhere used.
Let's get rid of them.

Signed-off-by: Richard Weinberger 
Cc: Oleg Nesterov 
Cc: Andrew Morton 
Cc: Huang Ying 
Cc: Soeren Sandmann Pedersen 
Cc: Namhyung Kim 
Cc: x86 
Cc: H. Peter Anvin 
Cc: Thomas Gleixner 
Cc: Robert Richter 
Cc: Paul Mundt 
Link: http://lkml.kernel.org/r/1305205872-10321-2-git-send-email-richard@nod.at
Signed-off-by: Frederic Weisbecker

Merge branch 'core' of git://git.kernel.org/pub/scm/linux/kernel/git/rric/oprofile into perf/urgent

2011-03-29T07:32:28+00:00