linux-toradex.git/block/blk-integrity.c, branch v4.11

block: Use pointer to backing_dev_info from request_queue

2017-02-02T15:20:48+00:00

We will want to have struct backing_dev_info allocated separately from
struct request_queue. As the first step add pointer to backing_dev_info
to request_queue and convert all users touching it. No functional
changes in this patch.

Reviewed-by: Christoph Hellwig 
Signed-off-by: Jan Kara 
Signed-off-by: Jens Axboe

block, libnvdimm, nvme: provide a built-in blk_integrity nop profile

2015-10-21T20:43:45+00:00

The libnvidmm-btt and nvme drivers use blk_integrity to reserve space
for per-sector metadata, but sometimes without protection checksums.
This property is generically useful, so teach the block core to
internally specify a nop profile if one is not provided at registration
time.

Cc: Keith Busch 
Cc: Matthew Wilcox 
Suggested-by: Christoph Hellwig 
[hch: kill the local nvme nop profile as well]
Acked-by: Martin K. Petersen 
Signed-off-by: Dan Williams 
Signed-off-by: Jens Axboe

block: move blk_integrity to request_queue

2015-10-21T20:43:42+00:00

A trace like the following proceeds a crash in bio_integrity_process()
when it goes to use an already freed blk_integrity profile.

 BUG: unable to handle kernel paging request at ffff8800d31b10d8
 IP: [] 0xffff8800d31b10d8
 PGD 2f65067 PUD 21fffd067 PMD 80000000d30001e3
 Oops: 0011 [#1] SMP
 Dumping ftrace buffer:
 ---------------------------------
    ndctl-2222    2.... 44526245us : disk_release: pmem1s
 systemd--2223    4.... 44573945us : bio_integrity_endio: pmem1s
    <...>-409     4.... 44574005us : bio_integrity_process: pmem1s
 ---------------------------------
[..]
  Call Trace:
  [] ? bio_integrity_process+0x159/0x2d0
  [] bio_integrity_verify_fn+0x36/0x60
  [] process_one_work+0x1cc/0x4e0

Given that a request_queue is pinned while i/o is in flight and that a
gendisk is allowed to have a shorter lifetime, move blk_integrity to
request_queue to satisfy requests arriving after the gendisk has been
torn down.

Cc: Christoph Hellwig 
Cc: Martin K. Petersen 
[martin: fix the CONFIG_BLK_DEV_INTEGRITY=n case]
Tested-by: Ross Zwisler 
Signed-off-by: Dan Williams 
Signed-off-by: Jens Axboe

block: Inline blk_integrity in struct gendisk

2015-10-21T20:42:42+00:00

Up until now the_integrity profile has been dynamically allocated and
attached to struct gendisk after the disk has been made active.

This causes problems because NVMe devices need to register the profile
prior to the partition table being read due to a mandatory metadata
buffer requirement. In addition, DM goes through hoops to deal with
preallocating, but not initializing integrity profiles.

Since the integrity profile is small (4 bytes + a pointer), Christoph
suggested moving it to struct gendisk proper. This requires several
changes:

 - Moving the blk_integrity definition to genhd.h.

 - Inlining blk_integrity in struct gendisk.

 - Removing the dynamic allocation code.

 - Adding helper functions which allow gendisk to set up and tear down
   the integrity sysfs dir when a disk is added/deleted.

 - Adding a blk_integrity_revalidate() callback for updating the stable
   pages bdi setting.

 - The calls that depend on whether a device has an integrity profile or
   not now key off of the bi->profile pointer.

 - Simplifying the integrity support routines in DM (Mike Snitzer).

Signed-off-by: Martin K. Petersen 
Reported-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Mike Snitzer 
Cc: Dan Williams 
Signed-off-by: Dan Williams 
Signed-off-by: Jens Axboe

block: Export integrity data interval size in sysfs

2015-10-21T20:42:41+00:00

The size of the data interval was not exported in the sysfs integrity
directory. Export it so that userland apps can tell whether the interval
is different from the device's logical block size.

Signed-off-by: Martin K. Petersen 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Dan Williams 
Signed-off-by: Jens Axboe

block: Reduce the size of struct blk_integrity

2015-10-21T20:42:39+00:00

The per-device properties in the blk_integrity structure were previously
unsigned short. However, most of the values fit inside a char. The only
exception is the data interval size and we can work around that by
storing it as a power of two.

This cuts the size of the dynamic portion of blk_integrity in half.

Signed-off-by: Martin K. Petersen 
Reported-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Dan Williams 
Signed-off-by: Jens Axboe

block: Consolidate static integrity profile properties

2015-10-21T20:42:38+00:00

We previously made a complete copy of a device's data integrity profile
even though several of the fields inside the blk_integrity struct are
pointers to fixed template entries in t10-pi.c.

Split the static and per-device portions so that we can reference the
template directly.

Signed-off-by: Martin K. Petersen 
Reported-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Cc: Dan Williams 
Signed-off-by: Dan Williams 
Signed-off-by: Jens Axboe

block: Move integrity kobject to struct gendisk

2015-10-21T20:42:36+00:00

The integrity kobject purely exists to support the integrity
subdirectory in sysfs and doesn't really have anything to do with the
blk_integrity data structure. Move the kobject to struct gendisk where
it belongs.

Signed-off-by: Martin K. Petersen 
Reported-by: Christoph Hellwig 
Reviewed-by: Sagi Grimberg 
Signed-off-by: Dan Williams 
Signed-off-by: Jens Axboe

block: Refuse request/bio merges with gaps in the integrity payload

2015-09-11T15:03:04+00:00

If a driver sets the block queue virtual boundary mask, it means that
it cannot handle gaps so we must not allow those in the integrity
payload as well.

Signed-off-by: Sagi Grimberg 

Fixed up by me to have duplicate integrity merge functions, depending
on whether block integrity is enabled or not. Fixes a compilations
issue with CONFIG_BLK_DEV_INTEGRITY unset.

Signed-off-by: Jens Axboe

writeback: separate out include/linux/backing-dev-defs.h

2015-06-02T14:33:34+00:00

With the planned cgroup writeback support, backing-dev related
declarations will be more widely used across block and cgroup;
unfortunately, including backing-dev.h from include/linux/blkdev.h
makes cyclic include dependency quite likely.

This patch separates out backing-dev-defs.h which only has the
essential definitions and updates blkdev.h to include it.  c files
which need access to more backing-dev details now include
backing-dev.h directly.  This takes backing-dev.h off the common
include dependency chain making it a lot easier to use it across block
and cgroup.

v2: fs/fat build failure fixed.

Signed-off-by: Tejun Heo 
Reviewed-by: Jan Kara 
Cc: Jens Axboe 
Signed-off-by: Jens Axboe