linux-toradex.git/block/sed-opal.c, branch v4.11

block/sed: Fix opal user range check and unused variables

2017-03-08T16:56:12+00:00

Fixes check that the opal user is within the range, and cleans up unused
method variables.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: Propagate original error message to userland.

2017-02-23T18:55:44+00:00

During an error on a comannd, ex: user provides wrong pw to unlock
range, we will gracefully terminate the opal session. We want to
propagate the original error to userland instead of the result of
the session termination, which is almost always a success.

Signed-off-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: Introduce free_opal_dev to free the structure and clean up state

2017-02-23T18:55:41+00:00

Before we free the opal structure we need to clean up any saved
locking ranges that the user had told us to unlock from a suspend.

Signed-off-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block/sed: Embed function data into the function sequence

2017-02-22T18:54:49+00:00

By embedding the function data with the function sequence, we can
eliminate the external function data and state variable code. It also
made obvious some other small cleanups.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed: Check received header lengths

2017-02-22T18:54:49+00:00

Add a buffer size check against discovery and response header lengths
before we loop over their buffers.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block/sed: Add helper to qualify response tokens

2017-02-22T18:54:49+00:00

Add helper which verifies the response token is valid and matches the
expected value. Merges token_type and response_get_token.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block/sed: Use ssize_t on atom parsers to return errors

2017-02-22T18:54:49+00:00

The short atom parser can return an errno from decoding but does not
currently return the error as a signed value. Convert all of the parsers
to ssize_t.

Signed-off-by: Jon Derrick 
Reviewed-by: Scott Bauer 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Jens Axboe

block/sed-opal: allocate struct opal_dev dynamically

2017-02-17T19:41:47+00:00

Insted of bloating the containing structure with it all the time this
allocates struct opal_dev dynamically.  Additionally this allows moving
the definition of struct opal_dev into sed-opal.c.  For this a new
private data field is added to it that is passed to the send/receive
callback.  After that a lot of internals can be made private as well.

Signed-off-by: Christoph Hellwig 
Tested-by: Scott Bauer 
Reviewed-by: Scott Bauer 
Signed-off-by: Jens Axboe

block/sed-opal: tone down not supported warnings

2017-02-17T19:41:44+00:00

Not having OPAL or a sub-feature supported is an entirely normal
condition for many drives, so don't warn about it.  Keep the messages,
but tone them down to debug only.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Scott Bauer 
Signed-off-by: Jens Axboe

Move stack parameters for sed_ioctl to prevent oversized stack with CONFIG_KASAN

2017-02-15T02:47:18+00:00

When CONFIG_KASAN is enabled, compilation fails:

block/sed-opal.c: In function 'sed_ioctl':
block/sed-opal.c:2447:1: error: the frame size of 2256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=]

Moved all the ioctl structures off the stack and dynamically allocate
using _IOC_SIZE()

Fixes: 455a7b238cd6 ("block: Add Sed-opal library")

Reported-by: Arnd Bergmann 
Signed-off-by: Scott Bauer 
Signed-off-by: Jens Axboe