linux-toradex.git/block/sed-opal.c, branch v5.5-rc7

block: sed-opal: Introduce SUM_SET_LIST parameter and append it using 'add_token_u64'

2019-11-18T16:49:15+00:00

In function 'activate_lsp', rather than hard-coding the short atom
header(0x83), we need to let the function 'add_short_atom_header' append
the header based on the parameter being appended.

The parameter has been defined in Section 3.1.2.1 of
https://trustedcomputinggroup.org/wp-content/uploads/TCG_Storage-Opal_Feature_Set_Single_User_Mode_v1-00_r1-00-Final.pdf

Reviewed-by: Jon Derrick 
Signed-off-by: Revanth Rajashekar 
Signed-off-by: Jens Axboe

block: sed-opal: Introduce Opal Datastore UID

2019-11-04T14:11:32+00:00

This patch introduces Opal Datastore UID.
The generic read/write table ioctl can use this UID
to access the Opal Datastore.

Reviewed-by: Scott Bauer 
Reviewed-by: Jon Derrick 
Signed-off-by: Revanth Rajashekar 
Signed-off-by: Jens Axboe

block: sed-opal: Add support to read/write opal tables generically

2019-11-04T14:11:31+00:00

This feature gives the user RW access to any opal table with admin1
authority. The flags described in the new structure determines if the user
wants to read/write the data. Flags are checked for valid values in
order to allow future features to be added to the ioctl.

The user can provide the desired table's UID. Also, the ioctl provides a
size and offset field and internally will loop data accesses to return
the full data block. Read overrun is prevented by the initiator's
sec_send_recv() backend. The ioctl provides a private field with the
intention to accommodate any future expansions to the ioctl.

Reviewed-by: Scott Bauer 
Reviewed-by: Jon Derrick 
Signed-off-by: Revanth Rajashekar 
Signed-off-by: Jens Axboe

block: sed-opal: Generalizing write data to any opal table

2019-11-04T14:11:29+00:00

This patch refactors the existing "write_shadowmbr" func and
creates a new generalized function "generic_table_write_data",
to write data to any opal table. Also, a few cleanups are included
in this patch.

Reviewed-by: Scott Bauer 
Reviewed-by: Jon Derrick 
Signed-off-by: Revanth Rajashekar 
Signed-off-by: Jens Axboe

block: sed-opal: fix sparse warning: convert __be64 data

2019-10-03T20:21:32+00:00

sparse warns about incorrect type when using __be64 data.
It is not being converted to CPU-endian but it should be.

Fixes these sparse warnings:

../block/sed-opal.c:375:20: warning: incorrect type in assignment (different base types)
../block/sed-opal.c:375:20:    expected unsigned long long [usertype] align
../block/sed-opal.c:375:20:    got restricted __be64 const [usertype] alignment_granularity
../block/sed-opal.c:376:25: warning: incorrect type in assignment (different base types)
../block/sed-opal.c:376:25:    expected unsigned long long [usertype] lowest_lba
../block/sed-opal.c:376:25:    got restricted __be64 const [usertype] lowest_aligned_lba

Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Cc: Scott Bauer 
Cc: Rafael Antognolli 
Cc: linux-block@vger.kernel.org
Reviewed-by: Jon Derrick 
Signed-off-by: Randy Dunlap 
Signed-off-by: Jens Axboe

block: sed-opal: fix sparse warning: obsolete array init.

2019-10-03T20:21:30+00:00

Fix sparse warning: (missing '=')
../block/sed-opal.c:133:17: warning: obsolete array initializer, use C99 syntax

Fixes: ff91064ea37c ("block: sed-opal: check size of shadow mbr")
Cc: linux-block@vger.kernel.org
Cc: Jonas Rabenstein 
Cc: David Kozub 
Reviewed-by: Scott Bauer 
Reviewed-by:  Revanth Rajashekar 
Signed-off-by: Randy Dunlap 
Signed-off-by: Jens Axboe

block: sed-opal: Remove always false conditional statement

2019-08-20T15:33:21+00:00

In the function 'response_parse', num_entries will never be 0 as
slen is checked for 0. Hence, the condition 'if (num_entries == 0)'
can never be true.

Signed-off-by: Revanth Rajashekar 
Reviewed-by: Scott Bauer 
Reviewed-by: Jon Derrick 
Signed-off-by: Jens Axboe

block: sed-opal: Add/remove spaces

2019-08-20T15:33:20+00:00

Signed-off-by: Revanth Rajashekar 
Reviewed-by: Scott Bauer 
Reviewed-by: Jon Derrick 
Signed-off-by: Jens Axboe

block: sed-opal: check size of shadow mbr

2019-06-29T16:34:08+00:00

Check whether the shadow mbr does fit in the provided space on the
target. Also a proper firmware should handle this case and return an
error we may prevent problems or even damage with crappy firmwares.

Signed-off-by: Jonas Rabenstein 
Signed-off-by: David Kozub 
Reviewed-by: Scott Bauer 
Reviewed-by: Jon Derrick 
Signed-off-by: Jens Axboe

block: sed-opal: ioctl for writing to shadow mbr

2019-06-29T16:33:57+00:00

Allow modification of the shadow mbr. If the shadow mbr is not marked as
done, this data will be presented read only as the device content. Only
after marking the shadow mbr as done and unlocking a locking range the
actual content is accessible.

Co-authored-by: David Kozub 
Signed-off-by: Jonas Rabenstein 
Signed-off-by: David Kozub 
Reviewed-by: Scott Bauer 
Reviewed-by: Jon Derrick 
Signed-off-by: Jens Axboe