linux-toradex.git/block, branch v2.6.33.17

cfq-iosched: fix a rcu warning

2011-07-13T03:31:24+00:00

commit 3181faa85bda3dc3f5e630a1846526c9caaa38e3 upstream.

I got a rcu warnning at boot. the ioc->ioc_data is rcu_deferenced, but
doesn't hold rcu_read_lock.

Signed-off-by: Shaohua Li 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

cfq-iosched: fix locking around ioc->ioc_data assignment

2011-07-13T03:31:24+00:00

commit ab4bd22d3cce6977dc039664cc2d052e3147d662 upstream.

Since we are modifying this RCU pointer, we need to hold
the lock protecting it around it.

This fixes a potential reuse and double free of a cfq
io_context structure. The bug has been in CFQ for a long
time, it hit very few people but those it did hit seemed
to see it a lot.

Tracked in RH bugzilla here:

https://bugzilla.redhat.com/show_bug.cgi?id=577968

Credit goes to Paul Bolle for figuring out that the issue
was around the one-hit ioc->ioc_data cache. Thanks to his
hard work the issue is now fixed.

Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

block: export blk_{get,put}_queue()

2011-06-23T22:28:39+00:00

commit d86e0e83b32bc84600adb0b6ea1fce389b266682 upstream.

We need them in SCSI to fix a bug, but currently they are not
exported to modules. Export them.

Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

block: add proper state guards to __elv_next_request

2011-06-23T22:28:34+00:00

commit 0a58e077eb600d1efd7e54ad9926a75a39d7f8ae upstream.

blk_cleanup_queue() calls elevator_exit() and after this, we can't
touch the elevator without oopsing.  __elv_next_request() must check
for this state because in the refcounted queue model, we can still
call it after blk_cleanup_queue() has been called.

This was reported as causing an oops attributable to scsi.

Signed-off-by: James Bottomley 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

block, blk-sysfs: Fix an err return path in blk_register_queue()

2011-05-09T23:04:34+00:00

commit ed5302d3c25006a9edc7a7fbea97a30483f89ef7 upstream.

We do not call blk_trace_remove_sysfs() in err return path
if kobject_add() fails. This path fixes it.

Signed-off-by: Liu Yuan 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

cfq-iosched: Don't wait if queue already has requests.

2011-03-21T19:44:56+00:00

commit 02a8f01b5a9f396d0327977af4c232d0f94c45fd upstream.

Commit 7667aa0630407bc07dc38dcc79d29cc0a65553c1 added logic to wait for
the last queue of the group to become busy (have at least one request),
so that the group does not lose out for not being continuously
backlogged. The commit did not check for the condition that the last
queue already has some requests. As a result, if the queue already has
requests, wait_busy is set. Later on, cfq_select_queue() checks the
flag, and decides that since the queue has a request now and wait_busy
is set, the queue is expired.  This results in early expiration of the
queue.

This patch fixes the problem by adding a check to see if queue already
has requests. If it does, wait_busy is not set. As a result, time slices
do not expire early.

The queues with more than one request are usually buffered writers.
Testing shows improvement in isolation between buffered writers.

Signed-off-by: Justin TerAvest 
Reviewed-by: Gui Jianfeng 
Acked-by: Vivek Goyal 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

block: check for proper length of iov entries in blk_rq_map_user_iov()

2011-03-21T19:43:40+00:00

commit 9284bcf4e335e5f18a8bc7b26461c33ab60d0689 upstream.

Ensure that we pass down properly validated iov segments before
calling into the mapping or copy functions.

Reported-by: Dan Rosenberg 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

block: take care not to overflow when calculating total iov length

2011-03-21T19:43:39+00:00

commit 9f864c80913467312c7b8690e41fb5ebd1b50e92 upstream.

Reported-by: Dan Rosenberg 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

block: Ensure physical block size is unsigned int

2011-03-21T19:43:39+00:00

commit 892b6f90db81cccb723d5d92f4fddc2d68b206e1 upstream.

Physical block size was declared unsigned int to accomodate the maximum
size reported by READ CAPACITY(16).  Make sure we use the right type in
the related functions.

Signed-off-by: Martin K. Petersen 
Acked-by: Mike Snitzer 
Signed-off-by: Jens Axboe 
Signed-off-by: Greg Kroah-Hartman

bsg: fix incorrect device_status value

2011-03-21T19:43:23+00:00

commit 478971600e47cb83ff2d3c63c5c24f2b04b0d6a1 upstream.

bsg incorrectly returns sg's masked_status value for device_status.

[jejb: fix up expression logic]
Reported-by: Douglas Gilbert 
Signed-off-by: FUJITA Tomonori 
Signed-off-by: James Bottomley 
Signed-off-by: Greg Kroah-Hartman