linux-toradex.git/crypto/ablkcipher.c, branch v3.14.57

crypto: api - Only abort operations on fatal signal

2015-11-09T20:50:26+00:00

commit 3fc89adb9fa4beff31374a4bf50b3d099d88ae83 upstream.

Currently a number of Crypto API operations may fail when a signal
occurs.  This causes nasty problems as the caller of those operations
are often not in a good position to restart the operation.

In fact there is currently no need for those operations to be
interrupted by user signals at all.  All we need is for them to
be killable.

This patch replaces the relevant calls of signal_pending with
fatal_signal_pending, and wait_for_completion_interruptible with
wait_for_completion_killable, respectively.

Signed-off-by: Herbert Xu 
Signed-off-by: Greg Kroah-Hartman

crypto: skcipher - Use eseqiv even on UP machines

2013-10-30T01:51:45+00:00

Previously we would use eseqiv on all async ciphers in all cases,
and sync ciphers if we have more than one CPU.  This meant that
chainiv is only used in the case of sync ciphers on a UP machine.

As chainiv may aid attackers by making the IV predictable, even
though this risk itself is small, the above usage pattern causes
it to further leak information about the host.

This patch addresses these issues by using eseqiv even if we're
on a UP machine.

Signed-off-by: Herbert Xu 
Acked-by: Steffen Klassert 
Acked-by: David S. Miller

crypto: user - fix info leaks in report API

2013-02-19T12:27:03+00:00

Three errors resulting in kernel memory disclosure:

1/ The structures used for the netlink based crypto algorithm report API
are located on the stack. As snprintf() does not fill the remainder of
the buffer with null bytes, those stack bytes will be disclosed to users
of the API. Switch to strncpy() to fix this.

2/ crypto_report_one() does not initialize all field of struct
crypto_user_alg. Fix this to fix the heap info leak.

3/ For the module name we should copy only as many bytes as
module_name() returns -- not as much as the destination buffer could
hold. But the current code does not and therefore copies random data
from behind the end of the module name, as the module name is always
shorter than CRYPTO_MAX_ALG_NAME.

Also switch to use strncpy() to copy the algorithm's name and
driver_name. They are strings, after all.

Signed-off-by: Mathias Krause 
Cc: Steffen Klassert 
Signed-off-by: Herbert Xu

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net

2012-04-10T18:30:45+00:00

crypto: Stop using NLA_PUT*().

2012-04-02T08:33:42+00:00

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller

crypto: user - Fix lookup of algorithms with IV generator

2012-03-29T11:52:47+00:00

We lookup algorithms with crypto_alg_mod_lookup() when instantiating via
crypto_add_alg(). However, algorithms that are wrapped by an IV genearator
(e.g. aead or genicv type algorithms) need special care. The userspace
process hangs until it gets a timeout when we use crypto_alg_mod_lookup()
to lookup these algorithms. So export the lookup functions for these
algorithms and use them in crypto_add_alg().

Signed-off-by: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: algapi - Fix build problem with NET disabled

2011-11-10T22:57:06+00:00

The report functions use NLA_PUT so we need to ensure that NET
is enabled.

Reported-by: Luis Henriques 
Signed-off-by: Herbert Xu

crypto: Add userspace report for givcipher type algorithms

2011-10-21T12:24:05+00:00

Signed-off-by: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: Add userspace report for ablkcipher type algorithms

2011-10-21T12:24:05+00:00

Signed-off-by: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: skcipher - remove redundant NULL check

2011-01-29T04:09:43+00:00

Signed-off-by: Davidlohr Bueso 
Acked-by: David S. Miller 
Signed-off-by: Herbert Xu