linux-toradex.git/crypto/ansi_cprng.c, branch v3.14.7

crypto: ansi_cprng - Fix off by one error in non-block size request

2013-09-23T20:02:23+00:00

Stephan Mueller reported to me recently a error in random number generation in
the ansi cprng. If several small requests are made that are less than the
instances block size, the remainder for loop code doesn't increment
rand_data_valid in the last iteration, meaning that the last bytes in the
rand_data buffer gets reused on the subsequent smaller-than-a-block request for
random data.

The fix is pretty easy, just re-code the for loop to make sure that
rand_data_valid gets incremented appropriately

Signed-off-by: Neil Horman 
Reported-by: Stephan Mueller 
CC: Stephan Mueller 
CC: Petr Matousek 
CC: Herbert Xu 
CC: "David S. Miller" 
Signed-off-by: Herbert Xu

crypto: ansi_cprng - use crypto_[un]register_algs

2012-08-01T09:47:25+00:00

Combine all crypto_alg to be registered and use new crypto_[un]register_algs
functions. This simplifies init/exit code.

Cc: Neil Horman 
Signed-off-by: Jussi Kivilinna 
Signed-off-by: Herbert Xu

crypto: ansi_cprng - enforce key != seed in fips mode

2011-11-09T04:04:06+00:00

Apparently, NIST is tightening up its requirements for FIPS validation
with respect to RNGs. Its always been required that in fips mode, the
ansi cprng not be fed key and seed material that was identical, but
they're now interpreting FIPS 140-2, section AS07.09 as requiring that
the implementation itself must enforce the requirement. Easy fix, we
just do a memcmp of key and seed in fips_cprng_reset and call it a day.

v2: Per Neil's advice, ensure slen is sufficiently long before we
compare key and seed to avoid looking at potentially unallocated mem.

CC: Stephan Mueller 
CC: Steve Grubb 
Signed-off-by: Jarod Wilson 
Acked-by: Neil Horman 
Signed-off-by: Herbert Xu

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi

crypto: ansi_cprng - Move FIPS functions under CONFIG_CRYPTO_FIPS

2009-11-23T12:25:50+00:00

fips_cprng_get_random and fips_cprng_reset is used only by
CONFIG_CRYPTO_FIPS. This also fixes compilation warnings:

 crypto/ansi_cprng.c:360: warning: ‘fips_cprng_get_random’ defined but not used
 crypto/ansi_cprng.c:393: warning: ‘fips_cprng_reset’ defined but not used

Signed-off-by: Jaswinder Singh Rajput 
Acked-by: Neil Horman 
Signed-off-by: Herbert Xu

crypto: ansi_cprng - Fix test in get_prng_bytes

2009-10-27T10:51:33+00:00

size_t nbytes cannot be less than 0 and the test was redundant.

Signed-off-by: Roel Kluin 
Acked-by: Neil Horman 
Signed-off-by: Herbert Xu

crypto: ansi_cprng - Add FIPS wrapper

2009-10-19T02:57:02+00:00

Patch to add fips(ansi_cprng) alg, which is ansi_cprng plus a continuous test

Signed-off-by: Neil Horman 
Acked-by: Jarod Wilson 
Signed-off-by: Herbert Xu

crypto: ansi_cprng - Fix module initialization

2009-08-29T07:36:25+00:00

Return the value we got from crypto_register_alg() instead of
returning 0 in any case.

Signed-off-by: Steffen Klassert 
Acked-by: Neil Horman 
Signed-off-by: Herbert Xu

crypto: ansi_prng - alloc cipher just in init

2009-07-03T04:10:47+00:00

As reported by Eric Sesterhenn the re-allocation of the cipher in reset leads
to:
|BUG: sleeping function called from invalid context at kernel/rwsem.c:21
|in_atomic(): 1, irqs_disabled(): 0, pid: 4926, name: modprobe
|INFO: lockdep is turned off.
|Pid: 4926, comm: modprobe Tainted: G   M 2.6.31-rc1-22297-g5298976 #24
|Call Trace:
| [] __might_sleep+0xf9/0x101
| [] down_read+0x16/0x68
| [] crypto_alg_lookup+0x16/0x34
| [] crypto_larval_lookup+0x30/0xf9
| [] crypto_alg_mod_lookup+0x1d/0x62
| [] crypto_alloc_base+0x1e/0x64
| [] reset_prng_context+0xab/0x13f
| [] ? __spin_lock_init+0x27/0x51
| [] cprng_init+0x2a/0x42
| [] __crypto_alloc_tfm+0xfa/0x128
| [] crypto_alloc_base+0x33/0x64
| [] alg_test_cprng+0x30/0x1f4
| [] alg_test+0x12f/0x19f
| [] ? __alloc_pages_nodemask+0x14d/0x481
| [] do_test+0xf9d/0x163f [tcrypt]
| [] do_test+0x3a1/0x163f [tcrypt]
| [] tcrypt_mod_init+0x35/0x7c [tcrypt]
| [] _stext+0x54/0x12c
| [] ? tcrypt_mod_init+0x0/0x7c [tcrypt]
| [] ? up_read+0x16/0x2b
| [] ? __blocking_notifier_call_chain+0x40/0x4c
| [] sys_init_module+0xa9/0x1bf
| [] sysenter_do_call+0x12/0x32

because a spin lock is held and crypto_alloc_base() may sleep.
There is no reason to re-allocate the cipher, the state is resetted in
->setkey(). This patches makes the cipher allocation a one time thing and
moves it to init.

Reported-by: Eric Sesterhenn 
Signed-off-by: Sebastian Andrzej Siewior 
Acked-by: Neil Horman 
Signed-off-by: Herbert Xu

crypto: ansi_prng - Use just a BH lock

2009-07-03T04:09:41+00:00

The current code uses a mix of sping_lock() & spin_lock_irqsave(). This can
lead to deadlock with the correct timming & cprng_get_random() + cprng_reset()
sequence.
I've converted them to bottom half locks since all three user grab just a BH
lock so this runs probably in softirq :)

Signed-off-by: Sebastian Andrzej Siewior 
Acked-by: Neil Horman 
Signed-off-by: Herbert Xu