linux-toradex.git/crypto/asymmetric_keys/Makefile, branch master

certs: Add ECDSA signature verification self-test

2024-05-14T02:01:04+00:00

Commit c27b2d2012e1 ("crypto: testmgr - allow ecdsa-nist-p256 and -p384
in FIPS mode") enabled support for ECDSA in crypto/testmgr.c. The
PKCS#7 signature verification API builds upon the KCAPI primitives to
perform its high-level operations. Therefore, this change in testmgr.c
also allows ECDSA to be used by the PKCS#7 signature verification API
(in FIPS mode).

However, from a FIPS perspective, the PKCS#7 signature verification API
is a distinct "service" from the KCAPI primitives. This is because the
PKCS#7 API performs a "full" signature verification, which consists of
both hashing the data to be verified, and the public key operation.
On the other hand, the KCAPI primitive does not perform this hashing
step - it accepts pre-hashed data from the caller and only performs the
public key operation.

For this reason, the ECDSA self-tests in crypto/testmgr.c are not
sufficient to cover ECDSA signature verification offered by the PKCS#7
API. This is reflected by the self-test already present in this file
for RSA PKCS#1 v1.5 signature verification.

The solution is simply to add a second self-test here for ECDSA. P-256
with SHA-256 hashing was chosen as those parameters should remain
FIPS-approved for the foreseeable future, while keeping the performance
impact to a minimum. The ECDSA certificate and PKCS#7 signed data was
generated using OpenSSL. The input data is identical to the input data
for the existing RSA self-test.

Signed-off-by: Joachim Vandersmissen 
Reviewed-by: Jarkko Sakkinen 
Acked-by: Herbert Xu 
Signed-off-by: Jarkko Sakkinen

certs: Move RSA self-test data to separate file

2024-05-14T02:01:03+00:00

In preparation of adding new ECDSA self-tests, the existing data for
the RSA self-tests is moved to a separate file. This file is only
compiled if the new CONFIG_FIPS_SIGNATURE_SELFTEST_RSA configuration
option is set, which ensures that the required dependencies (RSA,
SHA-256) are present. Otherwise, the kernel would panic when trying to
execute the self-test.
The introduction of this new option, rather than adding the
dependencies to the existing CONFIG_FIPS_SIGNATURE_SELFTEST option,
allows for additional self-tests to be added for different algorithms.
The kernel can then be configured to only execute the self-tests for
those algorithms that are included.

Signed-off-by: Joachim Vandersmissen 
Reviewed-by: Jarkko Sakkinen 
Acked-by: Herbert Xu 
Signed-off-by: Jarkko Sakkinen

certs: Break circular dependency when selftest is modular

2023-10-27T10:04:24+00:00

The modular build fails because the self-test code depends on pkcs7
which in turn depends on x509 which contains the self-test.

Split the self-test out into its own module to break the cycle.

Fixes: 3cde3174eb91 ("certs: Add FIPS selftests")
Signed-off-by: Herbert Xu 
Reviewed-by: Jarkko Sakkinen 
Signed-off-by: Herbert Xu

certs: Add FIPS selftests

2022-06-21T15:05:12+00:00

Add some selftests for signature checking when FIPS mode is enabled.  These
need to be done before we start actually using the signature checking for
things and must panic the kernel upon failure.

Note that the tests must not check the blacklist lest this provide a way to
prevent a kernel from booting by installing a hash of a test key in the
appropriate UEFI table.

Reported-by: Simo Sorce 
Signed-off-by: David Howells 
Reviewed-by: Simo Sorce 
Reviewed-by: Herbert Xu 
cc: keyrings@vger.kernel.org
cc: linux-crypto@vger.kernel.org
Link: https://lore.kernel.org/r/165515742832.1554877.2073456606206090838.stgit@warthog.procyon.org.uk/

certs: Move load_certificate_list() to be with the asymmetric keys code

2022-06-21T15:05:06+00:00

Move load_certificate_list(), which loads a series of binary X.509
certificates from a blob and inserts them as keys into a keyring, to be
with the asymmetric keys code that it drives.

This makes it easier to add FIPS selftest code in which we need to load up
a private keyring for the tests to use.

Signed-off-by: David Howells 
Reviewed-by: Simo Sorce 
Reviewed-by: Herbert Xu 
cc: keyrings@vger.kernel.org
cc: linux-crypto@vger.kernel.org
Link: https://lore.kernel.org/r/165515742145.1554877.13488098107542537203.stgit@warthog.procyon.org.uk/

KEYS: remove support for asym_tpm keys

2022-03-08T11:55:52+00:00

asym_tpm keys are tied to TPM v1.2, which uses outdated crypto and has
been deprecated in favor of TPM v2.0 for over 7 years.  A very quick
look at this code also immediately found some memory safety bugs
(https://lore.kernel.org/r/20220113235440.90439-2-ebiggers@kernel.org).
Note that this code is reachable by unprivileged users.

According to Jarkko (one of the keyrings subsystem maintainers), this
code has no practical use cases, and he isn't willing to maintain it
(https://lore.kernel.org/r/YfFZPbKkgYJGWu1Q@iki.fi).

Therefore, let's remove it.

Note that this feature didn't have any documentation or tests, so we
don't need to worry about removing those.

Cc: David Howells 
Cc: Denis Kenzior 
Cc: James Morris 
Cc: Jarkko Sakkinen 
Cc: Marcel Holtmann 
Signed-off-by: Eric Biggers 
Reviewed-by: Jarkko Sakkinen 
Acked-by: Ard Biesheuvel 
Signed-off-by: Jarkko Sakkinen

KEYS: Add parser for TPM-based keys [ver #2]

2018-10-26T08:30:46+00:00

For TPM based keys, the only standard seems to be described here:
http://david.woodhou.se/draft-woodhouse-cert-best-practice.html#rfc.section.4.4

Quote from the relevant section:
"Rather, a common form of storage for "wrapped" keys is to encode the
binary TCPA_KEY structure in a single ASN.1 OCTET-STRING, and store the
result in PEM format with the tag "-----BEGIN TSS KEY BLOB-----". "

This patch implements the above behavior.  It is assumed that the PEM
encoding is stripped out by userspace and only the raw DER/BER format is
provided.  This is similar to how PKCS7, PKCS8 and X.509 keys are
handled.

Signed-off-by: Denis Kenzior 
Signed-off-by: David Howells 
Tested-by: Marcel Holtmann 
Reviewed-by: Marcel Holtmann 
Signed-off-by: James Morris

KEYS: asym_tpm: add skeleton for asym_tpm [ver #2]

2018-10-26T08:30:46+00:00

This patch adds the basic skeleton for the asym_tpm asymmetric key
subtype.

Signed-off-by: Denis Kenzior 
Signed-off-by: David Howells 
Tested-by: Marcel Holtmann 
Reviewed-by: Marcel Holtmann 
Signed-off-by: James Morris

KEYS: Implement PKCS#8 RSA Private Key parser [ver #2]

2018-10-26T08:30:46+00:00

Implement PKCS#8 RSA Private Key format [RFC 5208] parser for the
asymmetric key type.  For the moment, this will only support unencrypted
DER blobs.  PEM and decryption can be added later.

PKCS#8 keys can be loaded like this:

	openssl pkcs8 -in private_key.pem -topk8 -nocrypt -outform DER | \
	  keyctl padd asymmetric foo @s

Signed-off-by: David Howells 
Tested-by: Marcel Holtmann 
Reviewed-by: Marcel Holtmann 
Reviewed-by: Denis Kenzior 
Tested-by: Denis Kenzior 
Signed-off-by: James Morris

kbuild: rename -asn1.[ch] to .asn1.[ch]

2018-04-07T10:04:02+00:00

Our convention is to distinguish file types by suffixes with a period
as a separator.

*-asn1.[ch] is a different pattern from other generated sources such
as *.lex.c, *.tab.[ch], *.dtb.S, etc.  More confusing, files with
'-asn1.[ch]' are generated files, but '_asn1.[ch]' are checked-in
files:
  net/netfilter/nf_conntrack_h323_asn1.c
  include/linux/netfilter/nf_conntrack_h323_asn1.h
  include/linux/sunrpc/gss_asn1.h

Rename generated files to *.asn1.[ch] for consistency.

Signed-off-by: Masahiro Yamada

linux-toradex.git/crypto/asymmetric_keys/Makefile, branch master

certs: Add ECDSA signature verification self-test

certs: Move RSA self-test data to separate file

certs: Break circular dependency when selftest is modular

certs: Add FIPS selftests

certs: Move load_certificate_list() to be with the asymmetric keys code

KEYS: remove support for asym_tpm keys

KEYS: Add parser for TPM-based keys [ver #2]

KEYS: asym_tpm: add skeleton for asym_tpm [ver #2]

KEYS: Implement PKCS#8 RSA Private Key parser [ver #2]

kbuild: rename *-asn1.[ch] to *.asn1.[ch]

kbuild: rename -asn1.[ch] to .asn1.[ch]