linux-toradex.git/crypto/blkcipher.c, branch v4.4.93

crypto: skcipher - Fix blkcipher walk OOM crash

2016-09-30T08:18:34+00:00

commit acdb04d0b36769b3e05990c488dc74d8b7ac8060 upstream.

When we need to allocate a temporary blkcipher_walk_next and it
fails, the code is supposed to take the slow path of processing
the data block by block.  However, due to an unrelated change
we instead end up dereferencing the NULL pointer.

This patch fixes it by moving the unrelated bsize setting out
of the way so that we enter the slow path as inteded.

Fixes: 7607bd8ff03b ("[CRYPTO] blkcipher: Added blkcipher_walk_virt_block")
Reported-by: xiakaixu 
Reported-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu 
Tested-by: Ard Biesheuvel 
Signed-off-by: Greg Kroah-Hartman

crypto: skcipher - Copy iv from desc even for 0-len walks

2015-12-09T12:16:22+00:00

Some ciphers actually support encrypting zero length plaintexts. For
example, many AEAD modes support this. The resulting ciphertext for
those winds up being only the authentication tag, which is a result of
the key, the iv, the additional data, and the fact that the plaintext
had zero length. The blkcipher constructors won't copy the IV to the
right place, however, when using a zero length input, resulting in
some significant problems when ciphers call their initialization
routines, only to find that the ->iv parameter is uninitialized. One
such example of this would be using chacha20poly1305 with a zero length
input, which then calls chacha20, which calls the key setup routine,
which eventually OOPSes due to the uninitialized ->iv member.

Signed-off-by: Jason A. Donenfeld 
Cc: 
Signed-off-by: Herbert Xu

crypto: blkcipher - Include crypto/aead.h

2015-05-13T02:31:34+00:00

All users of AEAD should include crypto/aead.h instead of
include/linux/crypto.h.

Signed-off-by: Herbert Xu

crypto: allow blkcipher walks over AEAD data

2014-03-10T12:17:11+00:00

This adds the function blkcipher_aead_walk_virt_block, which allows the caller
to use the blkcipher walk API to handle the input and output scatterlists.

Signed-off-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu

crypto: remove direct blkcipher_walk dependency on transform

2014-03-10T12:17:10+00:00

In order to allow other uses of the blkcipher walk API than the blkcipher
algos themselves, this patch copies some of the transform data members to the
walk struct so the transform is only accessed at walk init time.

Signed-off-by: Ard Biesheuvel 
Signed-off-by: Herbert Xu

crypto: user - fix info leaks in report API

2013-02-19T12:27:03+00:00

Three errors resulting in kernel memory disclosure:

1/ The structures used for the netlink based crypto algorithm report API
are located on the stack. As snprintf() does not fill the remainder of
the buffer with null bytes, those stack bytes will be disclosed to users
of the API. Switch to strncpy() to fix this.

2/ crypto_report_one() does not initialize all field of struct
crypto_user_alg. Fix this to fix the heap info leak.

3/ For the module name we should copy only as many bytes as
module_name() returns -- not as much as the destination buffer could
hold. But the current code does not and therefore copies random data
from behind the end of the module name, as the module name is always
shorter than CRYPTO_MAX_ALG_NAME.

Also switch to use strncpy() to copy the algorithm's name and
driver_name. They are strings, after all.

Signed-off-by: Mathias Krause 
Cc: Steffen Klassert 
Signed-off-by: Herbert Xu

crypto: use ERR_CAST

2013-02-04T13:16:53+00:00

Replace PTR_ERR followed by ERR_PTR by ERR_CAST, to be more concise.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression err,x;
@@
-       err = PTR_ERR(x);
        if (IS_ERR(x))
-                return ERR_PTR(err);
+                return ERR_CAST(x);
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Herbert Xu

crypto: Stop using NLA_PUT*().

2012-04-02T08:33:42+00:00

These macros contain a hidden goto, and are thus extremely error
prone and make code hard to audit.

Signed-off-by: David S. Miller

crypto: remove the second argument of k[un]map_atomic()

2012-03-20T13:48:16+00:00

Signed-off-by: Cong Wang

crypto: algapi - Fix build problem with NET disabled

2011-11-10T22:57:06+00:00

The report functions use NLA_PUT so we need to ensure that NET
is enabled.

Reported-by: Luis Henriques 
Signed-off-by: Herbert Xu