linux-toradex.git/crypto/gf128mul.c, branch v4.15

crypto: gf128mul - The x8_ble multiplication functions

2017-11-03T13:50:43+00:00

It multiply GF(2^128) elements in the ble format.
It will be used by chelsio driver to speed up gf multiplication.

Signed-off-by: Harsh Jain 
Signed-off-by: Herbert Xu

crypto: gf128mul - define gf128mul_x_* in gf128mul.h

2017-04-05T13:58:35+00:00

The gf128mul_x_ble function is currently defined in gf128mul.c, because
it depends on the gf128mul_table_be multiplication table.

However, since the function is very small and only uses two values from
the table, it is better for it to be defined as inline function in
gf128mul.h. That way, the function can be inlined by the compiler for
better performance.

For consistency, the other gf128mul_x_* functions are also moved to the
header file. In addition, the code is rewritten to be constant-time.

After this change, the speed of the generic 'xts(aes)' implementation
increased from ~225 MiB/s to ~235 MiB/s (measured using 'cryptsetup
benchmark -c aes-xts-plain64' on an Intel system with CRYPTO_AES_X86_64
and CRYPTO_AES_NI_INTEL disabled).

Signed-off-by: Ondrej Mosnacek 
Reviewd-by: Eric Biggers 
Signed-off-by: Herbert Xu

crypto: gf128mul - constify 4k and 64k multiplication tables

2017-03-09T10:34:16+00:00

Constify the multiplication tables passed to the 4k and 64k
multiplication functions, as they are not modified by these functions.

Cc: Alex Cope 
Signed-off-by: Eric Biggers 
Signed-off-by: Herbert Xu

crypto: gf128mul - rename the byte overflow tables

2017-03-09T10:34:15+00:00

Though the GF(2^128) byte overflow tables were named the "lle" and "bbe"
tables, they are not actually tied to these element formats
specifically, but rather to particular a "bit endianness".  For example,
the bbe table is actually used for both bbe and ble multiplication.
Therefore, rename the tables to "le" and "be" and update the comment to
explain this.

Cc: Alex Cope 
Signed-off-by: Eric Biggers 
Signed-off-by: Herbert Xu

crypto: gf128mul - remove xx() macro

2017-03-09T10:34:15+00:00

The xx() macro serves no purpose and can be removed.

Cc: Alex Cope 
Signed-off-by: Eric Biggers 
Signed-off-by: Herbert Xu

crypto: gf128mul - fix some comments

2017-03-09T10:34:14+00:00

Fix incorrect references to GF(128) instead of GF(2^128), as these are
two entirely different fields, and fix a few other incorrect comments.

Cc: Alex Cope 
Signed-off-by: Eric Biggers 
Signed-off-by: Herbert Xu

crypto: gf128mul - Zero memory when freeing multiplication table

2016-11-17T15:34:59+00:00

GF(2^128) multiplication tables are typically used for secret
information, so it's a good idea to zero them on free.

Signed-off-by: Alex Cope 
Signed-off-by: Eric Biggers 
Signed-off-by: Herbert Xu

crypto: gf128mul - remove dead gf128mul_64k_lle code

2016-11-13T09:45:06+00:00

This code is unlikely to be useful in the future because transforms
don't know how often keys will be changed, new algorithms are unlikely
to use lle representation, and tables should be replaced with
carryless multiplication instructions when available.

Signed-off-by: Alex Cope 
Signed-off-by: Herbert Xu

crypto: gf128mul - fix call to memset()

2011-07-08T09:21:21+00:00

In gf128mul_lle() and gf128mul_bbe() r isn't completely initialized with
zero because the size argument passed to memset() is the size of the
pointer, not the structure it points to.

Luckily there are no in-kernel users of those functions so the ABI
change implied by this fix should break no existing code.

Based on a patch by the PaX Team.

Signed-off-by: Mathias Krause 
Cc: PaX Team 
Acked-by: David S. Miller 
Signed-off-by: Herbert Xu

Fix common misspellings

2011-03-31T14:26:23+00:00

Fixes generated by 'codespell' and manually reviewed.

Signed-off-by: Lucas De Marchi