linux-toradex.git/drivers/acpi/acpi_memhotplug.c, branch v3.16-rc7

ACPI / scan: always register memory hotplug scan handler

2014-05-30T14:04:36+00:00

Prevent platform devices from being created for ACPI memory device
objects if CONFIG_ACPI_HOTPLUG_MEMORY is unset by compiling out the
memory hotplug scan handler's callbacks only in that case and still
compiling its device ID list in and registering the scan handler in
either case.

Also unset the memory hotplug scan handler's .attach() callback
if acpi_no_memhotplug is set, but still register the scan handler to
avoid creating platform devices for ACPI memory devices in that case
too.

This change is based on a prototype from Zhang Rui.

Signed-off-by: Rafael J. Wysocki 
Reviewed-by: Mika Westerberg

ACPI / memhotplug: add parameter to disable memory hotplug

2014-01-16T00:43:49+00:00

When booting a kexec/kdump kernel on a system that has specific memory
hotplug regions the boot will fail with warnings like:

 swapper/0: page allocation failure: order:9, mode:0x84d0
 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.10.0-65.el7.x86_64 #1
 Hardware name: QCI QSSC-S4R/QSSC-S4R, BIOS QSSC-S4R.QCI.01.00.S013.032920111005 03/29/2011
  0000000000000000 ffff8800341bd8c8 ffffffff815bcc67 ffff8800341bd950
  ffffffff8113b1a0 ffff880036339b00 0000000000000009 00000000000084d0
  ffff8800341bd950 ffffffff815b87ee 0000000000000000 0000000000000200
 Call Trace:
  [] dump_stack+0x19/0x1b
  [] warn_alloc_failed+0xf0/0x160
  [] ?  __alloc_pages_direct_compact+0xac/0x196
  [] __alloc_pages_nodemask+0x7ff/0xa00
  [] vmemmap_alloc_block+0x62/0xba
  [] vmemmap_alloc_block_buf+0x15/0x3b
  [] vmemmap_populate+0xb4/0x21b
  [] sparse_mem_map_populate+0x27/0x35
  [] sparse_add_one_section+0x7a/0x185
  [] __add_pages+0xaf/0x240
  [] arch_add_memory+0x59/0xd0
  [] add_memory+0xb9/0x1b0
  [] acpi_memory_device_add+0x18d/0x26d
  [] acpi_bus_device_attach+0x7d/0xcd
  [] acpi_ns_walk_namespace+0xc8/0x17f
  [] ? acpi_bus_type_and_status+0x90/0x90
  [] ? acpi_bus_type_and_status+0x90/0x90
  [] acpi_walk_namespace+0x95/0xc5
  [] acpi_bus_scan+0x8b/0x9d
  [] acpi_scan_init+0x63/0x160
  [] acpi_init+0x25d/0x2a6
  [] ? acpi_sleep_proc_init+0x2a/0x2a
  [] do_one_initcall+0xe2/0x190
  [] kernel_init_freeable+0x17c/0x207
  [] ? do_early_param+0x88/0x88
  [] ? rest_init+0x80/0x80
  [] kernel_init+0xe/0x180
  [] ret_from_fork+0x7c/0xb0
  [] ? rest_init+0x80/0x80
 Mem-Info:
 Node 0 DMA per-cpu:
 CPU    0: hi:    0, btch:   1 usd:   0
 Node 0 DMA32 per-cpu:
 CPU    0: hi:   42, btch:   7 usd:   0
 active_anon:0 inactive_anon:0 isolated_anon:0
  active_file:0 inactive_file:0 isolated_file:0
  unevictable:0 dirty:0 writeback:0 unstable:0
  free:872 slab_reclaimable:13 slab_unreclaimable:1880
  mapped:0 shmem:0 pagetables:0 bounce:0
  free_cma:0

because the system has run out of memory at boot time.  This occurs
because of the following sequence in the boot:

Main kernel boots and sets E820 map.  The second kernel is booted with a
map generated by the kdump service using memmap= and memmap=exactmap.
These parameters are added to the kernel parameters of the kexec/kdump
kernel.   The kexec/kdump kernel has limited memory resources so as not
to severely impact the main kernel.

The system then panics and the kdump/kexec kernel boots (which is a
completely new kernel boot).  During this boot ACPI is initialized and the
kernel (as can be seen above) traverses the ACPI namespace and finds an
entry for a memory device to be hotadded.

ie)

  [] __add_pages+0xaf/0x240
  [] arch_add_memory+0x59/0xd0
  [] add_memory+0xb9/0x1b0
  [] acpi_memory_device_add+0x18d/0x26d
  [] acpi_bus_device_attach+0x7d/0xcd
  [] acpi_ns_walk_namespace+0xc8/0x17f
  [] ? acpi_bus_type_and_status+0x90/0x90
  [] ? acpi_bus_type_and_status+0x90/0x90
  [] acpi_walk_namespace+0x95/0xc5
  [] acpi_bus_scan+0x8b/0x9d
  [] acpi_scan_init+0x63/0x160
  [] acpi_init+0x25d/0x2a6

At this point the kernel adds page table information and the the kexec/kdump
kernel runs out of memory.

This can also be reproduced by using the memmap=exactmap and mem=X
parameters on the main kernel and booting.

This patchset resolves the problem by adding a kernel parameter,
acpi_no_memhotplug, to disable ACPI memory hotplug.

Signed-off-by: Prarit Bhargava 
Acked-by: Vivek Goyal 
Acked-by: Toshi Kani 
Acked-by: David Rientjes 
Signed-off-by: Rafael J. Wysocki

ACPI / bind: Pass struct acpi_device pointer to acpi_bind_one()

2013-12-07T00:05:50+00:00

There is no reason to pass an ACPI handle to acpi_bind_one() instead
of a struct acpi_device pointer to the target device object, so
modify that function to take a struct acpi_device pointer as its
second argument and update all code depending on it accordingly.

Signed-off-by: Rafael J. Wysocki 
Tested-by: Lan Tianyu  # for USB/ACPI

Merge branch 'acpi-hotplug'

2013-10-28T00:12:41+00:00

* acpi-hotplug:
  ACPI / memhotplug: Use defined marco METHOD_NAME__STA
  ACPI / hotplug: Use kobject_init_and_add() instead of _init() and _add()
  ACPI / hotplug: Don't set kobject parent pointer explicitly
  ACPI / hotplug: Set kobject name via kobject_add(), not kobject_set_name()
  hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock()
  hotplug / x86: Disable ARCH_CPU_PROBE_RELEASE on x86
  hotplug / x86: Add hotplug lock to missing places
  hotplug / x86: Fix online state in cpu0 debug interface

ACPI / memhotplug: Use defined marco METHOD_NAME__STA

2013-10-10T00:32:33+00:00

We already have predefined marco for method name "_STA', so
using the marco instead of directly using the string.

Signed-off-by: Zhang Yanfei 
Signed-off-by: Rafael J. Wysocki

ACPI / mm: use NUMA_NO_NODE

2013-09-23T23:40:38+00:00

Use more appropriate NUMA_NO_NODE instead of -1

Signed-off-by: Jianguo Wu 
Acked-by: David Rientjes 
Signed-off-by: Rafael J. Wysocki

ACPI / memhotplug: Fix a stale pointer in error path

2013-07-14T23:26:18+00:00

device->driver_data needs to be cleared when releasing its data,
mem_device, in an error path of acpi_memory_device_add().

The function evaluates the _CRS of memory device objects, and fails
when it gets an unexpected resource or cannot allocate memory.  A
kernel crash or data corruption may occur when the kernel accesses
the stale pointer.

Signed-off-by: Toshi Kani 
Reviewed-by: Yasuaki Ishimatsu 
Cc: 2.6.32+ 
Signed-off-by: Rafael J. Wysocki

Memory hotplug / ACPI: Simplify memory removal

2013-06-01T19:37:10+00:00

Now that the memory offlining should be taken care of by the
companion device offlining code in acpi_scan_hot_remove(), the
ACPI memory hotplug driver doesn't need to offline it in
remove_memory() any more.  Moreover, since the return value of
remove_memory() is not used, it's better to make it be a void
function and trigger a BUG() if the memory scheduled for removal is
not offline.

Change the code in accordance with the above observations.

Signed-off-by: Rafael J. Wysocki 
Reviewed-by: Toshi Kani

ACPI / memhotplug: Bind removable memory blocks to ACPI device nodes

2013-05-12T12:14:38+00:00

During ACPI memory hotplug configuration bind memory blocks residing
in modules removable through the standard ACPI mechanism to struct
acpi_device objects associated with ACPI namespace objects
representing those modules.  Accordingly, unbind those memory blocks
from the struct acpi_device objects when the memory modules in
question are being removed.

When "offline" operation for devices representing memory blocks is
introduced, this will allow the ACPI core's device hot-remove code to
use it to carry out remove_memory() for those memory blocks and check
the results of that before it actually removes the modules holding
them from the system.

Since walk_memory_range() is used for accessing all memory blocks
corresponding to a given ACPI namespace object, it is exported from
memory_hotplug.c so that the code in acpi_memhotplug.c can use it.

Signed-off-by: Rafael J. Wysocki 
Tested-by: Vasilis Liaskovitis 
Reviewed-by: Toshi Kani

ACPI / memhotplug: Remove info->failed bit

2013-03-24T23:36:25+00:00

acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.

The patch removes acpi_memory_info->failed bit.

Signed-off-by: yasuaki ishimatsu 
Acked-by: Toshi Kani 
Signed-off-by: Rafael J. Wysocki