linux-toradex.git/drivers/acpi/acpi_watchdog.c, branch v6.8

ACPI: watchdog: fix kernel-doc warnings

2023-12-12T19:27:20+00:00

Fix kernel-doc warnings found when using "W=1".

acpi_watchdog.c:85: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
acpi_watchdog.c:85: warning: missing initial short description on line:
 * Returns true if this system should prefer ACPI based watchdog instead of

Signed-off-by: Randy Dunlap 
Signed-off-by: Rafael J. Wysocki

ACPI: watchdog: Replace open coded variant of resource_union()

2020-11-17T17:06:29+00:00

Since we have resource_union() helper, let's utilize it here.

Signed-off-by: Andy Shevchenko 
Reviewed-by: Hanjun Guo 
Tested-by: Hanjun Guo 
Reviewed-by: Mika Westerberg 
Signed-off-by: Rafael J. Wysocki

ACPI: watchdog: Put the watchdog action table after parsing

2020-05-09T09:29:17+00:00

The mapped watchdog action table should be released after the
successfully parsing, and the failure path in the driver
initialization.

Signed-off-by: Hanjun Guo 
Signed-off-by: Rafael J. Wysocki

ACPI: watchdog: Fix gas->access_width usage

2020-02-13T22:51:30+00:00

ACPI Generic Address Structure (GAS) access_width field is not in bytes
as the driver seems to expect in few places so fix this by using the
newly introduced macro ACPI_ACCESS_BYTE_WIDTH().

Fixes: b1abf6fc4982 ("ACPI / watchdog: Fix off-by-one error at resource assignment")
Fixes: 058dfc767008 ("ACPI / watchdog: Add support for WDAT hardware watchdog")
Reported-by: Jean Delvare 
Signed-off-by: Mika Westerberg 
Reviewed-by: Jean Delvare 
Cc: 4.16+  # 4.16+
Signed-off-by: Rafael J. Wysocki

ACPI: watchdog: Allow disabling WDAT at boot

2020-02-10T01:23:50+00:00

In case the WDAT interface is broken, give the user an option to
ignore it to let a native driver bind to the watchdog device instead.

Signed-off-by: Jean Delvare 
Acked-by: Mika Westerberg 
Signed-off-by: Rafael J. Wysocki

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500

2019-06-19T15:09:55+00:00

Based on 2 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation #

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 4122 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Enrico Weigelt 
Reviewed-by: Kate Stewart 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
Signed-off-by: Greg Kroah-Hartman

ACPI / watchdog: Prefer iTCO_wdt always when WDAT table uses RTC SRAM

2018-05-24T08:52:49+00:00

After we added quirk for Lenovo Z50-70 it turns out there are at least
two more systems where WDAT table includes instructions accessing RTC
SRAM. Instead of quirking each system separately, look for such
instructions in the table and automatically prefer iTCO_wdt if found.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=199033
Reported-by: Arnold Guy 
Reported-by: Alois Nespor 
Reported-by: Yury Pakin 
Reported-by: Ihor Chyhin 
Signed-off-by: Mika Westerberg 
Acked-by: Guenter Roeck 
Signed-off-by: Rafael J. Wysocki

ACPI / watchdog: Prefer iTCO_wdt on Lenovo Z50-70

2018-04-24T09:12:59+00:00

WDAT table on Lenovo Z50-70 is using RTC SRAM (ports 0x70 and 0x71) to
store state of the timer. This conflicts with Linux RTC driver
(rtc-cmos.c) who fails to reserve those ports for itself preventing RTC
from functioning. In addition the WDAT table seems not to be fully
functional because it does not reset the system when the watchdog times
out.

On this system iTCO_wdt works just fine so we simply prefer to use it
instead of WDAT. This makes RTC working again and also results working
watchdog via iTCO_wdt.

Reported-by: Peter Milley 
Link: https://bugzilla.kernel.org/show_bug.cgi?id=199033
Signed-off-by: Mika Westerberg 
Signed-off-by: Rafael J. Wysocki

ACPI / watchdog: Fix off-by-one error at resource assignment

2018-03-19T22:17:07+00:00

The resource allocation in WDAT watchdog has off-one-by error, it sets
one byte more than the actual end address.  This may eventually lead
to unexpected resource conflicts.

Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
Cc: 4.9+  # 4.9+
Signed-off-by: Takashi Iwai 
Acked-by: Mika Westerberg 
Acked-by: Guenter Roeck 
Signed-off-by: Rafael J. Wysocki

ACPI / watchdog: properly initialize resources

2017-09-18T23:49:02+00:00

We copy a local resource structure into a list, but only
initialize some of its members, as pointed out by gcc-4.4:

drivers/acpi/acpi_watchdog.c: In function 'acpi_watchdog_init':
drivers/acpi/acpi_watchdog.c:105: error: 'res.child' may be used uninitialized in this function
drivers/acpi/acpi_watchdog.c:105: error: 'res.sibling' may be used uninitialized in this function
drivers/acpi/acpi_watchdog.c:105: error: 'res.parent' may be used uninitialized in this function
drivers/acpi/acpi_watchdog.c:105: error: 'res.desc' may be used uninitialized in this function
drivers/acpi/acpi_watchdog.c:105: error: 'res.name' may be used uninitialized in this function

Newer compilers can presumably optimize the uninitialized access
away entirely and don't warn at all, but rely on the kzalloc()
to zero the structure first. This adds an explicit initialization
to force consistent behavior.

Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
Signed-off-by: Arnd Bergmann 
Acked-by: Guenter Roeck 
Acked-by: Mika Westerberg 
Signed-off-by: Rafael J. Wysocki