linux-toradex.git/drivers/acpi/apei/hest.c, branch v6.11

ACPI: APEI: Skip initialization of GHES_ASSIST structures for Machine Check Architecture

2024-02-29T17:34:40+00:00

To support GHES_ASSIST on Machine Check Architecture (MCA) error sources,
a set of GHES structures is provided by the system firmware for each MCA
error source. Each of these sets consists of a GHES structure for each MCA
bank on each logical CPU, with all structures of a set sharing a common
Related Source ID, equal to the Source ID of one of the MCA error source
structures.[1] On SOCs with large core counts, this typically equates to
tens of thousands of GHES_ASSIST structures for MCA under
"/sys/bus/platform/drivers/GHES".

Support for GHES_ASSIST however, hasn't been implemented in the kernel. As
such, the information provided through these structures is not consumed by
Linux. Moreover, these GHES_ASSIST structures for MCA, which are supposed
to provide supplemental information in context of an error reported by
hardware, are setup as independent error sources by the kernel during HEST
initialization.

Additionally, if the Type field of the Notification structure, associated
with these GHES_ASSIST structures for MCA, is set to Polled, the kernel
sets up a timer for each individual structure. The duration of the timer
is derived from the Poll Interval field of the Notification structure. On
SOCs with high core counts, this will result in tens of thousands of
timers expiring periodically causing unnecessary preemptions and wastage
of CPU cycles. The problem will particularly intensify if Poll Interval
duration is not sufficiently high.

Since GHES_ASSIST support is not present in kernel, skip initialization
of GHES_ASSIST structures for MCA to eliminate their performance impact.

[1] ACPI specification 6.5, section 18.7

Signed-off-by: Avadhut Naik 
Reviewed-by: Yazen Ghannam 
Reviewed-by: Tony Luck 
Signed-off-by: Rafael J. Wysocki

ACPI: APEI: fix return value of __setup handlers

2022-03-08T18:43:39+00:00

__setup() handlers should return 1 to indicate that the boot option
has been handled. Returning 0 causes a boot option to be listed in
the Unknown kernel command line parameters and also added to init's
arg list (if no '=' sign) or environment list (if of the form 'a=b').

Unknown kernel command line parameters "erst_disable
  bert_disable hest_disable BOOT_IMAGE=/boot/bzImage-517rc6", will be
  passed to user space.

 Run /sbin/init as init process
   with arguments:
     /sbin/init
     erst_disable
     bert_disable
     hest_disable
   with environment:
     HOME=/
     TERM=linux
     BOOT_IMAGE=/boot/bzImage-517rc6

Fixes: a3e2acc5e37b ("ACPI / APEI: Add Boot Error Record Table (BERT) support")
Fixes: a08f82d08053 ("ACPI, APEI, Error Record Serialization Table (ERST) support")
Fixes: 9dc966641677 ("ACPI, APEI, HEST table parsing")
Signed-off-by: Randy Dunlap 
Reported-by: Igor Zhbanov 
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Reviewed-by: "Huang, Ying" 
Signed-off-by: Rafael J. Wysocki

ACPI: APEI: mark apei_hest_parse() static

2021-10-27T18:34:47+00:00

apei_hest_parse() is only used in hest.c, so mark it static.

Signed-off-by: Christoph Hellwig 
[ rjw: Minor subject and changelog edits ]
Signed-off-by: Rafael J. Wysocki

ACPI: fix various typos in comments

2021-03-19T16:45:49+00:00

Fix trivial ACPI driver comment typos.

s/notifcations/notifications/
s/Ajust/Adjust/
s/preform/perform/
s/atrributes/attributes/
s/Souce/Source/
s/Evalutes/Evaluates/
s/Evalutes/Evaluates/
s/specifiy/specify/
s/promixity/proximity/
s/presuambly/presumably/
s/Evalute/Evaluate/
s/specificed/specified/
s/rountine/routine/
s/previosuly/previously/

Change comment referencing pcc_send_cmd to send_pcc_cmd.

Signed-off-by: Tom Saeger 
Reviewed-by: Randy Dunlap 
Signed-off-by: Rafael J. Wysocki

ACPI: APEI: Add is_generic_error() to identify GHES sources

2021-01-27T18:01:53+00:00

Refactor duplicated GHES identity logic into is_generic_error().

Signed-off-by: Yazen Ghannam 
Reviewed-by: Robert Richter 
Co-developed-by: Terry Bowman 
Signed-off-by: Terry Bowman 
Acked-by: Borislav Petkov 
Signed-off-by: Rafael J. Wysocki

ACPI: APEI: remove redundant assignment to variable rc

2020-07-27T13:22:58+00:00

The variable rc is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King 
Signed-off-by: Rafael J. Wysocki

ACPI: APEI: Put the HEST table for error path

2020-05-09T09:29:17+00:00

hest_tab will be used after hest_init(), but we need to release
it for error path.

Signed-off-by: Hanjun Guo 
Signed-off-by: Rafael J. Wysocki

acpi: Use pr_warn instead of pr_warning

2019-10-18T13:00:19+00:00

As said in commit f2c2cbcc35d4 ("powerpc: Use pr_warn instead of
pr_warning"), removing pr_warning so all logging messages use a
consistent _warn style. Let's do it.

Link: http://lkml.kernel.org/r/20191018031850.48498-8-wangkefeng.wang@huawei.com
To: linux-kernel@vger.kernel.org
Cc: "Rafael J. Wysocki" 
Cc: Len Brown 
Cc: James Morse 
Signed-off-by: Kefeng Wang 
Reviewed-by: Sergey Senozhatsky 
[pmladek@suse.com: two more indentation fixes]
Signed-off-by: Petr Mladek

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174

2019-05-30T18:26:41+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation this program is
  distributed in the hope that it will be useful but without any
  warranty without even the implied warranty of merchantability or
  fitness for a particular purpose see the gnu general public license
  for more details

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

has been chosen to replace the boilerplate/reference in 655 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Allison Randal 
Reviewed-by: Kate Stewart 
Reviewed-by: Richard Fontana 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190527070034.575739538@linutronix.de
Signed-off-by: Greg Kroah-Hartman

ACPI / APEI: Make estatus pool allocation a static size

2019-02-07T22:10:45+00:00

Adding new NMI-like notifications duplicates the calls that grow
and shrink the estatus pool. This is all pretty pointless, as the
size is capped to 64K. Allocate this for each ghes and drop
the code that grows and shrinks the pool.

Suggested-by: Borislav Petkov 
Signed-off-by: James Morse 
Reviewed-by: Borislav Petkov 
Signed-off-by: Rafael J. Wysocki