linux-toradex.git/drivers/acpi/hotkey.c, branch v2.6.19.3 Linux kernel for Apalis and Colibri modules ACPI: hotkey.c fixes, fix for potential crash of hotkey.c 2006-08-16T22:08:06+00:00 Handle X xhandle@gmail.com 2006-08-15T05:37:27+00:00 5672bde6355f2d12c49df1eec083d25afe489063 While going through the code, I found out some memory leaks and potential crashes in drivers/acpi/hotkey.c Please find the patch to fix them. This patch does the following, 1. Fixes memory leaks in error paths of hotkey_write_config 2. Fixes freeing unallocated pointers in the error paths of hotkey_write_config 3. Uses a loop instead of linear searching for parsing the userspace input in get_params 4. Uses array of char * instead of passing 4 pointer parameters explicitly into the init_{poll_}hotkey_* static functions Signed-off-by: Andrew Morton <akpm@osdl.org> Acked-by: Luming Yu <luming.yu@intel.com> Signed-off-by: Len Brown <len.brown@intel.com> 
While going through the code, I found out some memory leaks and potential
crashes in drivers/acpi/hotkey.c Please find the patch to fix them.

This patch does the following,

1. Fixes memory leaks in error paths of hotkey_write_config

2. Fixes freeing unallocated pointers in the error paths of hotkey_write_config

3. Uses a loop instead of linear searching for parsing the userspace
   input in get_params

4. Uses array of char * instead of passing 4 pointer parameters
   explicitly into the init_{poll_}hotkey_* static functions

Signed-off-by: Andrew Morton <akpm@osdl.org>
Acked-by: Luming Yu <luming.yu@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
ACPI: add 'const' to several ACPI file_operations 2006-07-10T04:04:29+00:00 Arjan van de Ven arjan@infradead.org 2006-07-04T17:06:00+00:00 d75080328affb4b268da430b7074cc8139cc662a Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> Signed-off-by: Len Brown <len.brown@intel.com> 
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
ACPI: delete tracing macros from drivers/acpi/*.c 2006-06-27T04:41:40+00:00 Patrick Mochel mochel@linux.intel.com 2006-06-27T04:41:40+00:00 d550d98d3317378d93a4869db204725d270ec812 Signed-off-by: Len Brown <len.brown@intel.com> 
Signed-off-by: Len Brown <len.brown@intel.com>
ACPI: un-export ACPI_ERROR() -- use printk(KERN_ERR...) 2006-06-27T04:01:06+00:00 Len Brown len.brown@intel.com 2006-06-27T03:41:38+00:00 6468463abd7051fcc29f3ee7c931f9bbbb26f5a4 Signed-off-by: Len Brown <len.brown@intel.com> 
Signed-off-by: Len Brown <len.brown@intel.com>
ACPI: un-export ACPI_WARNING() -- use printk(KERN_WARNING...) 2006-06-27T04:00:54+00:00 Len Brown len.brown@intel.com 2006-06-27T03:04:31+00:00 cece92969762b8ed7930d4e23008b76b06411dee Signed-off-by: Len Brown <len.brown@intel.com> 
Signed-off-by: Len Brown <len.brown@intel.com>
ACPI: Enable ACPI error messages w/o CONFIG_ACPI_DEBUG 2006-06-27T03:58:43+00:00 Thomas Renninger trenn@suse.de 2006-06-27T03:58:43+00:00 a6fc67202e0224e6c9d1d285cc0b444bce887ed5 Signed-off-by: Thomas Renninger <trenn@suse.de> Signed-off-by: Len Brown <len.brown@intel.com> 
Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Len Brown <len.brown@intel.com>
[ACPI] drivers/acpi/hotkey.c: check kmalloc return value 2006-03-31T06:02:39+00:00 Irwan Djajadi irwan.djajadi@iname.com 2006-01-20T20:28:00+00:00 1fee94034917aa711fcbd4ebf4c36f7ebd9fa7d6 Signed-off-by: Irwan Djajadi <irwan.djajadi@iname.com> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Len Brown <len.brown@intel.com> 
Signed-off-by: Irwan Djajadi <irwan.djajadi@iname.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Len Brown <len.brown@intel.com>
[ACPI] Lindent all ACPI files 2005-08-05T04:45:14+00:00 Len Brown len.brown@intel.com 2005-08-05T04:44:28+00:00 4be44fcd3bf648b782f4460fd06dfae6c42ded4b Signed-off-by: Len Brown <len.brown@intel.com> 
Signed-off-by: Len Brown <len.brown@intel.com>
[ACPI] CONFIG_ACPI_HOTKEY is now "n" by default 2005-08-03T22:11:22+00:00 Luming Yu luming.yu@intel.com 2005-08-03T22:07:59+00:00 79cda7d0e1c8629996242c036d6fe0466038d8ba For 2.6.12 behaviour, this (EXPERIMENTAL) driver should not be built. Update the driver source with latest from Luming. Signed-off-by: Luming Yu <luming.yu@intel.com> Signed-off-by: Len Brown <len.brown@intel.com> 
For 2.6.12 behaviour, this (EXPERIMENTAL) driver
should not be built.

Update the driver source with latest from Luming.

Signed-off-by: Luming Yu <luming.yu@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
[ACPI] fix debug-mode build warning in acpi/hotkey.c 2005-07-12T03:59:34+00:00 Andrew Morton akpm@osdl.org 2005-03-31T03:53:30+00:00 8de7a63b69a263b7549599be882d7aa15397f8b3 drivers/acpi/hotkey.c: In function `create_polling_proc': drivers/acpi/hotkey.c:334: warning: ISO C90 forbids mixed declarations and code Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Len Brown <len.brown@intel.com> 
drivers/acpi/hotkey.c: In function `create_polling_proc':
drivers/acpi/hotkey.c:334: warning: ISO C90 forbids mixed declarations and code

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Len Brown <len.brown@intel.com>