linux-toradex.git/drivers/ata/ata_piix.c, branch tegra-10.9.9

ata_piix: fix MWDMA handling on PIIX3

2010-01-28T23:02:16+00:00

commit 6938594374ee506e91a4c03117a034ea0ed66783 upstream.

Fix erroneous check for ap->udma_mask in do_pata_set_dmamode()
resulting in controller not being programmed properly for MWDMA.

Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ata_piix: parallel scanning on PATA needs an extra locking

2009-09-01T03:25:00+00:00

Commit log for commit 517d3cc15b36392e518abab6bacbb72089658313
("[libata] ata_piix: Enable parallel scan") says:

    This patch turns on parallel scanning for the ata_piix driver.
    This driver is used on most netbooks (no AHCI for cheap storage it seems).
    The scan is the dominating time factor in the kernel boot for these
    devices; with this flag it gets cut in half for the device I used
    for testing (eeepc).
    Alan took a look at the driver source and concluded that it ought to be safe
    to do for this driver.  Alan has also checked with the hardware team.

and it is all true but once we put all things together additional
constraints for PATA controllers show up (some hardware registers
have per-host not per-port atomicity) and we risk misprogramming
the controller.

I used the following test to check whether the issue is real:

  @@ -736,8 +736,20 @@ static void piix_set_piomode(struct ata_
   			(timings[pio][1] << 8);
   	}
   	pci_write_config_word(dev, master_port, master_data);
  -	if (is_slave)
  +	if (is_slave) {
  +		if (ap->port_no == 0) {
  +			u8 tmp = slave_data;
  +
  +			while (slave_data == tmp) {
  +				pci_read_config_byte(dev, slave_port, &tmp);
  +				msleep(50);
  +			}
  +
  +			dev_printk(KERN_ERR, &dev->dev, "PATA parallel scan "
  +				   "race detected\n");
  +		}
   		pci_write_config_byte(dev, slave_port, slave_data);
  +	}

   	/* Ensure the UDMA bit is off - it will be turned back on if
   	   UDMA is selected */

and it indeed triggered the error message.

Lets fix all such races by adding an extra locking to ->set_piomode
and ->set_dmamode methods for PATA controllers.

[ Alan: would be better to take the host lock in libata-core for these
  cases so that we fix all the adapters in one swoop.  "Looks fine as a
  temproary quickfix tho" ]

Cc: Arjan van de Ven 
Acked-by: Alan Cox 
Cc: Jeff Garzik 
Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Linus Torvalds

ata_piix: Add new short cable ID

2009-07-29T01:06:53+00:00

OriginalAuthor: Tony Espy 
Signed-off-by: Steve Conklin 
Signed-off-by: Jeff Garzik

ata_piix: Add new laptop short cable IDs

2009-07-29T01:06:43+00:00

OriginalAuthor: Michael Frey 
Signed-off-by: Steve Conklin 
Signed-off-by: Jeff Garzik

[libata] ata_piix: Enable parallel scan

2009-06-10T15:05:34+00:00

This patch turns on parallel scanning for the ata_piix driver.
This driver is used on most netbooks (no AHCI for cheap storage it seems).
The scan is the dominating time factor in the kernel boot for these
devices; with this flag it gets cut in half for the device I used
for testing (eeepc).
Alan took a look at the driver source and concluded that it ought to be safe
to do for this driver.  Alan has also checked with the hardware team.

Signed-off-by: Arjan van de Ven 
Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik

ata_piix: Remove stale comment

2009-06-10T11:50:18+00:00

Combined mode pci quirk hacks went away - so the table to keep in sync
no longer exists.

Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik

ata_piix: Turn on hotplugging support for older chips

2009-06-10T11:50:17+00:00

We can't do this for the later ones as they have all sorts of magic boot
time stuff that needs reviewing and the like. However we can do it for the
older ones and it turns out we need to as some IBM docking stations have a
second PIIX series device in them and without this change you can't use it
very well

Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik

ata_piix: Add HP Compaq nc6000 to the broken poweroff list

2009-06-05T18:41:13+00:00

HP Compaq nc6000 suffers from the double disk spindown issue.
Add it to the broken poweroff DMI list.

Signed-off-by: Ville Syrjala 
Signed-off-by: Jeff Garzik

ata_piix: The Sony TZ90 needs the cable type hardcoding

2009-05-11T18:31:36+00:00

The Sony TZ90 needs the cable type hardcoding. See bug #12734

Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik

ata_piix: ICH7 does not support correct MWDMA timings

2009-05-11T18:31:34+00:00

See Errata documentation. The recommended workaround is to use PIO4 instead
which will we automatically do by flagging this mode not available.

Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik