linux-toradex.git/drivers/ata/libata-core.c, branch v2.6.27.4

libata: Fix a large collection of DMA mode mismatches

2008-08-22T06:27:49+00:00

Dave Müller sent a diff for the pata_oldpiix that highlighted a problem
where a lot of the ATA drivers assume dma_mode == 0 means "no DMA" while
the core code uses 0xFF.

This turns out to have other consequences such as code doing >= XFER_UDMA_0
also catching 0xFF as UDMAlots. Fortunately it doesn't generally affect
set_dma_mode, although some drivers call back into their own set mode code
from other points.

Having been through the drivers I've added helpers for using_udma/using_mwdma
dma_enabled so that people don't open code ranges that may change (eg if UDMA8
appears somewhere)

Thanks to David for the initial bits
[and added fix for pata_oldpiix from and signed-off-by Dave Mueller
   -jg]

Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik

libata: restore SControl on detach

2008-08-22T06:19:46+00:00

Save SControl during probing and restore it on detach.  This prevents
adjustments made by libata drivers to seep into the next driver which
gets attached (be it a libata one or not).

It's not clear whether SControl also needs to be restored on suspend.
The next system to have control (ACPI or kexec'd kernel) would
probably like to see the original SControl value but there's no
guarantee that a link is gonna keep working after SControl is adjusted
without a reset and adding a reset and modified recovery cycle soley
for this is an overkill.  For now, do it only for detach.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

libata: implement no[hs]rst force params

2008-08-22T06:07:43+00:00

Implement force params nohrst, nosrst and norst.  This is to work
around reset related problems and ease debugging.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

pata_it821x: Driver updates and reworking

2008-07-31T06:04:50+00:00

- Add support for the RDC 1010 variant
- Rework the core library to have a read_id method. This allows the hacky
  bits of it821x to go and prepares us for pata_hd
- Switch from WARN to BUG in ata_id_string as it will reboot if you get
  it wrong so WARN won't be seen
- Allow the issue of command 0xFC on the 821x. This is needed to query
  rebuild status.
- Tidy up printk formatting
- Do more ident rewriting on RAID volumes to handle firmware provided
  ident data which is rather wonky
- Report the firmware revision and device layout in RAID mode
- Don't try and disable raid on the 8211 or RDC - they don't have the
  relevant bits

Signed-off-by: Alan Cox 
Signed-off-by: Jeff Garzik

libata-core: make sure that ata_force_tbl is freed in case of an error

2008-07-31T05:47:12+00:00

Fix a potential memory leak when ata_init() encounters an error.

Signed-off-by: Elias Oltmanns 
Cc: Tejun Heo 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik

libata: update atapi disable handling

2008-07-31T05:47:05+00:00

Global and per-LLD ATAPI disable checks were done in the command issue
path probably because it was left out during EH conversion.  On
affected machines, this can cause lots of warning messages.  Move them
to where they belong - the probing path.

Reported by Chunbo Luo.

Signed-off-by: Tejun Heo 
Cc: Chunbo Luo 
Signed-off-by: Jeff Garzik

libata: improve EH internal command timeout handling

2008-07-14T19:59:32+00:00

ATA_TMOUT_INTERNAL which was 30secs were used for all internal
commands which is way too long when something goes wrong.  This patch
implements command type based stepped timeouts.  Different command
types can use different timeouts and each command type can use
different timeout values after timeouts.

ie. the initial timeout is set to a value which should cover most of
the cases but not too long so that run away cases don't delay things
too much.  After the first try times out, the second try can use
longer timeout and if that one times out too, it can go for full 30sec
timeout.

IDENTIFYs use 5s - 10s - 30s timeout and all other commands use 5s -
10s timeouts.

This patch significantly cuts down the needed time to handle failure
cases while still allowing libata to work with nut job devices through
retries.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

libata: consistently use msecs for time durations

2008-07-14T19:59:32+00:00

libata has been using mix of jiffies and msecs for time druations.
This is getting confusing.  As writing sub HZ values in jiffies is
PITA and msecs_to_jiffies() can't be used as initializer, unify unit
for all time durations to msecs.  So, durations are in msecs and
deadlines are in jiffies.  ata_deadline() is added to compute deadline
from a start time and duration in msecs.

While at it, drop now superflous _msec suffix from arguments and
rename @timeout to @deadline if it represents a fixed point in time
rather than duration.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

libata: don't check whether to use DMA or not for no data commands

2008-06-19T00:27:49+00:00

There's no reason to check whether to use DMA or not for no data
commands.  Don't do it.  While at it, make local variable using_pio in
atapi_xlat() set iff ATAPI_PROT_PIO is going to be used and rename
ata_check_atapi_dma() to atapi_check_dma() for consistency.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik

ata: Convert to static DEFINE_SPINLOCK(lock)

2008-05-30T16:37:43+00:00

Replace deprecated static spinlock_t instance to static DEFINE_SPINLOCK(lock).

Signed-off-by: Pradeep Singh 
Signed-off-by: Jeff Garzik