linux-toradex.git/drivers/ata/libata-core.c, branch v3.4.45

libata: Set max sector to 65535 for Slimtype DVD A DS8A8SH drive

2013-04-12T16:38:44+00:00

commit a32450e127fc6e5ca6d958ceb3cfea4d30a00846 upstream.

The Slimtype DVD A  DS8A8SH drive locks up when max sector is smaller than
65535, and the blow backtrace is observed on locking up:

INFO: task flush-8:32:1130 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
flush-8:32      D ffffffff8180cf60     0  1130      2 0x00000000
 ffff880273aef618 0000000000000046 0000000000000005 ffff880273aee000
 ffff880273aee000 ffff880273aeffd8 ffff880273aee010 ffff880273aee000
 ffff880273aeffd8 ffff880273aee000 ffff88026e842ea0 ffff880274a10000
Call Trace:
 [] schedule+0x5d/0x70
 [] io_schedule+0x8c/0xd0
 [] get_request+0x731/0x7d0
 [] ? cfq_allow_merge+0x50/0x90
 [] ? wake_up_bit+0x40/0x40
 [] ? bio_attempt_back_merge+0x33/0x110
 [] blk_queue_bio+0x23a/0x3f0
 [] generic_make_request+0xc6/0x120
 [] submit_bio+0x138/0x160
 [] ? bio_alloc_bioset+0x96/0x120
 [] submit_bh+0x1f1/0x220
 [] __block_write_full_page+0x228/0x340
 [] ? attach_nobh_buffers+0xc0/0xc0
 [] ? I_BDEV+0x10/0x10
 [] ? I_BDEV+0x10/0x10
 [] block_write_full_page_endio+0xe6/0x100
 [] block_write_full_page+0x15/0x20
 [] blkdev_writepage+0x18/0x20
 [] __writepage+0x17/0x40
 [] write_cache_pages+0x34a/0x4a0
 [] ? set_page_dirty+0x70/0x70
 [] generic_writepages+0x51/0x80
 [] do_writepages+0x20/0x50
 [] __writeback_single_inode+0xa6/0x2b0
 [] writeback_sb_inodes+0x311/0x4d0
 [] __writeback_inodes_wb+0x86/0xd0
 [] wb_writeback+0x1a3/0x330
 [] ? _raw_spin_lock_irqsave+0x3f/0x50
 [] ? get_nr_inodes+0x52/0x70
 [] wb_do_writeback+0x1dc/0x260
 [] ? schedule_timeout+0x204/0x240
 [] bdi_writeback_thread+0x102/0x2b0
 [] ? wb_do_writeback+0x260/0x260
 [] kthread+0xc0/0xd0
 [] ? kthread_worker_fn+0x1b0/0x1b0
 [] ret_from_fork+0x7c/0xb0
 [] ? kthread_worker_fn+0x1b0/0x1b0

 The above trace was triggered by
   "dd if=/dev/zero of=/dev/sr0 bs=2048 count=32768"

 It was previously working by accident, since another bug introduced
 by 4dce8ba94c7 (libata: Use 'bool' return value for ata_id_XXX) caused
 all drives to use maxsect=65535.

Signed-off-by: Shan Hai 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: set dma_mode to 0xff in reset

2013-01-17T16:50:44+00:00

commit 5416912af75de9cba5d1c75b99a7888b0bbbd2fb upstream.

ata_device->dma_mode's initial value is zero, which is not a valid dma
mode, but ata_dma_enabled will return true for this value. This patch
sets dma_mode to 0xff in reset function, so that ata_dma_enabled will
not return true for this case, or it will cause problem for pata_acpi.

The corrsponding bugzilla page is at:
https://bugzilla.kernel.org/show_bug.cgi?id=49151

Reported-by: Phillip Wood 
Signed-off-by: Aaron Lu 
Tested-by: Szymon Janc 
Tested-by: Dutra Julio 
Acked-by: Alan Cox 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: Prevent interface errors with Seagate FreeAgent GoFlex

2012-10-02T17:30:35+00:00

commit c531077f40abc9f2129c4c83a30b3f8d6ce1c0e7 upstream.

When using my Seagate FreeAgent GoFlex eSATAp external disk enclosure,
interface errors are always seen until 1.5Gbps is negotiated [1]. This
occurs using any disk in the enclosure, and when the disk is connected
directly with a generic passive eSATAp cable, we see stable 3Gbps
operation as expected.

Blacklist 3Gbps mode to avoid dataloss and the ~30s delay bus reset
and renegotiation incurs.

Signed-off-by: Daniel J Blueman 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: add a host flag to ignore detected ATA devices

2012-06-17T18:21:29+00:00

commit db63a4c8115a0bb904496e1cdd3e7488e68b0d06 upstream.

Where devices are visible via more than one host we sometimes wish to
indicate that cirtain devices should be ignored on a specific host.  Add a
host flag indicating that this host wishes to ignore ATA specific devices.

Signed-off-by: Andy Whitcroft 
Signed-off-by: Jeff Garzik 
Cc: Victor Miasnikov 
Signed-off-by: Greg Kroah-Hartman

libata: init ata_print_id to 0

2012-05-03T18:07:59+00:00

When comparing the dmesg between 3.4-rc3 and 3.4-rc4 I found the
following differences:

 -ata1: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff100 irq 47
 -ata2: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff180 irq 47
 -ata3: DUMMY
 +ata2: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff100 irq 47
 +ata3: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff180 irq 47
  ata4: DUMMY
  ata5: DUMMY
 -ata6: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff380 irq 47
 +ata6: DUMMY
 +ata7: SATA max UDMA/133 abar m2048@0xf9fff000 port 0xf9fff380 irq 47

The change of numbering comes from commit 85d6725b7c0d7e3f ("libata:
make ata_print_id atomic") that changed lines like

	ap->print_id = ata_print_id++;
		to
	ap->print_id = atomic_inc_return(&ata_print_id);

As the latter behaves like ++ata_print_id, we must initialize
it to zero to start the numbering from one.

Signed-off-by: Tero Roponen 
Acked-by: Dan Williams 
Signed-off-by: Jeff Garzik

libata: make ata_print_id atomic

2012-04-12T19:57:51+00:00

This variable is incremented from multiple contexts (module_init via
libata-lldds and the libsas discovery thread).  Make it atomic to head
off any chance of libsas and libata creating duplicate ids.

Acked-by: Jacek Danecki 
Signed-off-by: Dan Williams 
Signed-off-by: Jeff Garzik

[SCSI] libsas: async ata scanning

2012-02-29T21:35:41+00:00

libsas ata error handling is already async but this does not help the
scan case.  Move initial link recovery out from under host->scan_mutex,
and delay synchronization with eh until after all port probe/recovery
work has been queued.

Device ordering is maintained with scan order by still calling
sas_rphy_add() in order of domain discovery.

Since we now scan the domain list when invoking libata-eh we need to be
careful to check for fully initialized ata ports.

Acked-by: Jack Wang 
Acked-by: Jeff Garzik 
Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

[libata] add DVRTD08A and DVR-215 to NOSETXFER device quirk list

2012-01-18T01:50:07+00:00

Signed-off-by: Jeff Garzik

ata: add ata port hibernate callbacks

2012-01-09T00:14:59+00:00

Signed-off-by: Lin Ming 
Signed-off-by: Jeff Garzik

ata: update ata port's runtime status during system resume

2012-01-09T00:14:59+00:00

The ata port is brought back to full power state during system resume.
So its runtime PM status will have to be updated to reflect
the actual post-system sleep status.

This also fixes below warning during system suspend/resume.

WARNING: at /work/linux/drivers/ata/libata-eh.c:4034
ata_scsi_port_error_handler+0x89/0x557()

4034         WARN_ON(!(ap->pflags & ATA_PFLAG_SUSPENDED));

Signed-off-by: Lin Ming 
Signed-off-by: Jeff Garzik