linux-toradex.git/drivers/ata/libata-scsi.c, branch v2.6.32.51

libata: set queue DMA alignment to sector size for ATAPI too

2011-05-09T22:55:41+00:00

commit 729a6a300e628a48cf12bac93a964a535e83cd1d upstream.

ata_pio_sectors() expects buffer for each sector to be contained in a
single page; otherwise, it ends up overrunning the first page.  This
is achieved by setting queue DMA alignment.  If sector_size is smaller
than PAGE_SIZE and all buffers are sector_size aligned, buffer for
each sector is always contained in a single page.

This wasn't applied to ATAPI devices but IDENTIFY_PACKET is executed
as ATA_PROT_PIO and thus uses ata_pio_sectors().  Newer versions of
udev issue IDENTIFY_PACKET with unaligned buffer triggering the
problem and causing oops.

This patch fixes the problem by setting sdev->sector_size to
ATA_SECT_SIZE on ATATPI devices and always setting DMA alignment to
sector_size.  While at it, add a warning for the unlikely but still
possible scenario where sector_size is larger than PAGE_SIZE, in which
case the alignment wouldn't be enough.

Signed-off-by: Tejun Heo 
Reported-by: John Stanley 
Tested-by: John Stanley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Jonathan Liu 
Signed-off-by: Greg Kroah-Hartman

libata: fix NULL sdev dereference race in atapi_qc_complete()

2010-12-09T21:26:52+00:00

commit 2a5f07b5ec098edc69e05fdd2f35d3fbb1235723 upstream.

SCSI commands may be issued between __scsi_add_device() and dev->sdev
assignment, so it's unsafe for ata_qc_complete() to dereference
dev->sdev->locked without checking whether it's NULL or not.  Fix it.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata-scsi passthru: fix bug which truncated LBA48 return values

2010-12-09T21:26:52+00:00

commit bc496ed00ab1411d3efaf295b72e0c9eb343e1a3 upstream.

Fix assignment which overwrote SAT ATA PASS-THROUGH command EXTEND
bit setting (ATA_TFLAG_LBA48)

Signed-off-by: Douglas Gilbert 
Signed-off-by: Jeff Garzik 
Cc: Kerin Millar 
Signed-off-by: Greg Kroah-Hartman

libata: unbreak TPM filtering by reorganizing ata_scsi_pass_thru()

2009-09-09T01:17:43+00:00

ata_scsi_pass_thru() was checking for input sanity and disallowed
commands while initializaing qc from scmd.  TPM filtering was added
right after protocol check at which point tf wasn't initialized
properly.  This means that TPM filtering has never really worked.

This patch fixes the bug by reorganizing ata_scsi_pass_thru() such
that qc is fully initialized before checking for invalid conditions
which is way less error prone.

Discovered while Thilo-Alexander Ginkel was trying debug patches for
bko#13416.

Signed-off-by: Tejun Heo 
Cc: Thilo-Alexander Ginkel 
Signed-off-by: Jeff Garzik

libata: Delegate nonrot flag setting to SCSI

2009-09-01T23:47:20+00:00

Now that the SCSI disk driver correctly handles non-rotational devices
we can move setting the queue flag to SCSI.

Signed-off-by: Martin K. Petersen 
Signed-off-by: Jeff Garzik

libata: remove spindown skipping and warning

2009-09-01T23:47:20+00:00

This was a hack to give userland shutdown tools time to drop manual
spindown.  All popular distros updated quite some time ago and the due
is well passed.  Drop it.

Signed-off-by: Tejun Heo 
Cc: Jaswinder Singh Rajput 
Signed-off-by: Jeff Garzik

Merge branch 'master' into for-2.6.31

2009-05-22T18:25:34+00:00

Conflicts:
	drivers/block/hd.c
	drivers/block/mg_disk.c

Signed-off-by: Jens Axboe

libata: Media rotation rate and form factor heuristics

2009-05-15T18:14:56+00:00

This patch provides new heuristics for parsing both the form factor and
media rotation rate ATA IDENFITY words.

The reported ATA version must be 7 or greater and the device must return
values defined as valid in the standard.  Only then are the
characteristics reported to SCSI via the VPD B1 page.

This seems like a reasonable compromise to me considering that we have
been shipping several kernel releases that key off the rotation rate bit
without any version checking whatsoever.  With no complaints so far.

Signed-off-by: Martin K. Petersen 
Signed-off-by: Jeff Garzik

libata: Report disk alignment and physical block size

2009-05-15T18:14:22+00:00

For disks with 4KB sectors, report the correct block size and alignment
when filling out the READ CAPACITY(16) response.

This patch is based upon code from Matthew Wilcox' 4KB ATA tree.  I
fixed the bug I reported a while back caused by ATA and SCSI using
different approaches to describing the alignment.

Signed-off-by: Martin K. Petersen 
Signed-off-by: Jeff Garzik

Avoid world-writable sysfs files in libata driver.

2009-05-11T18:31:31+00:00

Signed-off-by: Vitaly Mayatskikh 
Signed-off-by: Jeff Garzik