linux-toradex.git/drivers/ata/libata-scsi.c, branch v3.4.66

libata: fix Null pointer dereference on disk error

2013-01-17T16:50:44+00:00

commit 26cd4d65deba587f3cf2329b6869ce02bcbe68ec upstream.

Following oops were observed when disk error happened:

[ 4272.896937] sd 0:0:0:0: [sda] Unhandled error code
[ 4272.896939] sd 0:0:0:0: [sda] Result: hostbyte=DID_BAD_TARGET driverbyte=DRIVER_OK
[ 4272.896942] sd 0:0:0:0: [sda] CDB: Read(10): 28 00 00 5a de a7 00 00 08 00
[ 4272.896951] end_request: I/O error, dev sda, sector 5955239
[ 4291.574947] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 4291.658305] IP: [] ahci_activity_show+0x1/0x40
[ 4291.730090] PGD 76dbbc067 PUD 6c4fba067 PMD 0
[ 4291.783408] Oops: 0000 [#1] SMP
[ 4291.822100] last sysfs file: /sys/devices/pci0000:00/0000:00:1f.2/host0/target0:0:0/0:0:0:0/sw_activity
[ 4291.934235] CPU 9
[ 4291.958301] Pid: 27942, comm: hwinfo ......

ata_scsi_find_dev could return NULL, so ata_scsi_activity_{show,store} should check if atadev is NULL.

Signed-off-by: Xiaotian Feng 
Cc: James Bottomley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

[SCSI] libsas, libata: fix start of life for a sas ata_port

2012-04-23T11:11:47+00:00

This changes the ordering of initialization and probing events from:
  1/ allocate rphy in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN
  2/ allocate ata_port and schedule port probe in DISCE_PROBE
...to:
  1/ allocate ata_port in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN
  2/ allocate rphy in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN
  3/ schedule port probe in DISCE_PROBE

This ordering prevents PHYE_SIGNAL_LOSS_EVENTS from sneaking in to
destrory ata devices before they have been fully initialized:

  BUG: unable to handle kernel paging request at 0000000000003b10
  IP: [] sas_ata_end_eh+0x12/0x5e [libsas]
  ...
  [] sas_unregister_common_dev+0x78/0xc9 [libsas]
  [] sas_unregister_dev+0x4f/0xad [libsas]
  [] sas_unregister_domain_devices+0x7f/0xbf [libsas]
  [] sas_deform_port+0x61/0x1b8 [libsas]
  [] sas_phye_loss_of_signal+0x29/0x2b [libsas]

...and kills the awkward "sata domain_device briefly existing in the
domain without an ata_port" state.

Reported-by: Michal Kosciowski 
Signed-off-by: Dan Williams 
Acked-by: Jeff Garzik 
Signed-off-by: James Bottomley

[SCSI] libata: Pass correct DMA device to scsi host

2012-04-22T18:00:21+00:00

Use scsi_add_host_with_dma in ata_scsi_add_hosts to pass in the
correct DMA device(ATA host).

Bug report: http://marc.info/?l=linux-ide&m=133177818318187&w=2

Reported-and-tested-by: Jörg Sommer 
Acked-by: Jeff Garzik 
Signed-off-by: Lin Ming 
Signed-off-by: James Bottomley

libata: make ata_print_id atomic

2012-04-12T19:57:51+00:00

This variable is incremented from multiple contexts (module_init via
libata-lldds and the libsas discovery thread).  Make it atomic to head
off any chance of libsas and libata creating duplicate ids.

Acked-by: Jacek Danecki 
Signed-off-by: Dan Williams 
Signed-off-by: Jeff Garzik

[SCSI] libsas: async ata scanning

2012-02-29T21:35:41+00:00

libsas ata error handling is already async but this does not help the
scan case.  Move initial link recovery out from under host->scan_mutex,
and delay synchronization with eh until after all port probe/recovery
work has been queued.

Device ordering is maintained with scan order by still calling
sas_rphy_add() in order of domain discovery.

Since we now scan the domain list when invoking libata-eh we need to be
careful to check for fully initialized ata ports.

Acked-by: Jack Wang 
Acked-by: Jeff Garzik 
Signed-off-by: Dan Williams 
Signed-off-by: James Bottomley

ata: add ata port runtime PM callbacks

2012-01-09T00:14:58+00:00

Add ata port runtime suspend/resume/idle callbacks.
Set ->eh_noresume to skip the runtime PM calls on scsi host
in the error handler to avoid dead lock.

Acked-by: Tejun Heo 
Signed-off-by: Lin Ming 
Signed-off-by: Jeff Garzik

ata: make ata port as parent device of scsi host

2012-01-09T00:14:57+00:00

Currently, the device tree of ata port and scsi host looks as below,

        /sys/devices/pci0000:00/0000:00:1f.2    (ahci controller)
        |-- ata1                                (ata port)
        |-- host0                               (scsi host)
           |-- target0:0:0                      (scsi target)
               |-- 0:0:0:0                      (disk)

This patch makes ata port as parent device of scsi host, then it becomes

        /sys/devices/pci0000:00/0000:00:1f.2    (ahci controller)
        |-- ata1                                (ata port)
            |-- host0                           (scsi host)
                |-- target0:0:0                 (scsi target)
                    |-- 0:0:0:0                 (disk)

With this change, the ata port runtime PM is easier.
For example, the ata port runtime suspend will happen as,

disk suspend --> scsi target suspend --> scsi host suspend --> ata port
suspend.

Acked-by: Tejun Heo 
Signed-off-by: Lin Ming 
Signed-off-by: Jeff Garzik

[libata] libata-scsi.c: Add function parameter documentation

2011-11-09T06:32:27+00:00

Add the documentation of parameters of ata_change_queue_depth to silence the warning of make xmldocs

Signed-off-by: Marcos paulo de Souza 
Acked-by: Randy Dunlap 
Signed-off-by: Jeff Garzik

ide/ata: Add export.h for EXPORT_SYMBOL/THIS_MODULE where needed

2011-10-31T23:31:37+00:00

They were getting this implicitly by an include of module.h
from device.h -- but we are going to clean that up and break
that include chain, so include export.h explicitly now.

Signed-off-by: Paul Gortmaker

[SCSI] libsas,libata: fix ->change_queue_{depth|type} for sata devices

2011-10-02T17:30:30+00:00

Pass queue_depth change requests to libata, and prevent queue_type
changes for ATA devices.

Otherwise:
1/ we do not honor the libata specific restrictions on the queue depth
2/ libsas drivers that do not set sdev->tagged_supported are unable to
   change the queue_depth of ata devices via sysfs

Signed-off-by: Dan Williams 
Acked-by: Jeff Garzik 
Signed-off-by: James Bottomley