linux-toradex.git/drivers/ata/pata_ftide010.c, branch v7.0-rc2

ata: pata_ftide010: Fix some DMA timings

2026-02-04T11:23:23+00:00

The FTIDE010 has been missing some timing settings since its
inception, since the upstream OpenWrt patch was missing these.

The community has since come up with the appropriate timings.

Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
Cc: stable@vger.kernel.org
Signed-off-by: Linus Walleij 
Signed-off-by: Niklas Cassel

ata: Switch back to struct platform_driver::remove()

2024-10-17T07:55:08+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all platform drivers below drivers/ata/ to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.

While touching these files, make indention of the struct initializer
consistent in several files.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Damien Le Moal 
Link: https://lore.kernel.org/r/20241016141609.27329-2-u.kleine-koenig@baylibre.com
Signed-off-by: Niklas Cassel

ata: pata_ftide010: Enable module autoloading

2024-09-01T23:05:36+00:00

Add MODULE_DEVICE_TABLE(), so modules can be properly autoloaded based
on the alias from of_device_id table.

Signed-off-by: Liao Chen 
Reviewed-by: Sergey Shtylyov 
Reviewed-by: Linus Walleij 
Signed-off-by: Damien Le Moal

ata: pata_ftide010: Add missing MODULE_DESCRIPTION

2023-08-24T23:21:03+00:00

Add the missing MODULE_DESCRIPTION() to avoid warnings such as:

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/ata/pata_ftide010.o

when compiling with W=1.

Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal 
Reviewed-by: Linus Walleij

ata: pata_ftide010: Convert to platform remove callback returning void

2023-08-02T08:53:21+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal

ata: pata_ftide010: Use devm_platform_get_and_ioremap_resource()

2023-08-02T08:37:06+00:00

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Yangtao Li 
Reviewed-by: Linus Walleij 
Reviewed-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal

ata: Explicitly include correct DT includes

2023-08-02T08:37:05+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Signed-off-by: Damien Le Moal

scsi: ata: Declare SCSI host templates const

2023-03-24T23:19:19+00:00

Make it explicit that ATA host templates are not modified.

Reviewed-by: Linus Walleij 
Acked-by: Damien Le Moal 
Reviewed-by: Serge Semin  (for DWC AHCI SATA)
Reviewed-by: John Garry 
Reviewed-by: Jon Hunter  (for Tegra)
Cc: Christoph Hellwig 
Cc: Ming Lei 
Cc: Hannes Reinecke 
Cc: John Garry 
Cc: Mike Christie 
Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20230322195515.1267197-5-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

ata: pata_ftide010: Remove build dependency on OF

2022-10-17T23:05:10+00:00

The pata_ftide010 can be built without CONFIG_OF being enabled, as long
as the macro of_match_ptr() is not used when initializing the platform
driver .of_match_table field.

Remove the use of this macro and the build dependency on OF.

Signed-off-by: Damien Le Moal 
Reviewed-by: Linus Walleij 
Reviewed-by: Sergey Shtylyov

ata: pata_ftide010: Remove unneeded ERROR check before clk_disable_unprepare

2022-05-16T11:22:37+00:00

ERROR check is already in clk_disable() and clk_unprepare() by using
IS_ERR_OR_NULL. Remove unneeded ERROR check for ftide->pclk here.

Signed-off-by: Wan Jiabing 
Reviewed-by: Sergey Shtylyov 
Reviewed-by: Linus Walleij 
Signed-off-by: Damien Le Moal