linux-toradex.git/drivers/ata/pata_it821x.c, branch v6.3-rc4

ata: fix read_id() ata port operation interface

2022-01-14T06:17:16+00:00

Drivers that need to tweak a device IDENTIFY data implement the
read_id() port operation. The IDENTIFY data buffer is passed as an
argument to the read_id() operation for drivers to use. However, when
this operation is called, the IDENTIFY data is not yet converted to CPU
endian and contains le16 words.

Change the interface of the read_id operation to pass a __le16 * pointer
to the IDENTIFY data buffer to clarify the buffer endianness. Fix the
pata_netcell, pata_it821x, ahci_xgene, ahci_ceva and ahci_brcm drivers
implementation of this operation and modify the code to corretly deal
with identify data words manipulation to avoid sparse warnings such as:

drivers/ata/ahci_xgene.c:262:33: warning: invalid assignment: &=
drivers/ata/ahci_xgene.c:262:33:    left side has type unsigned short
drivers/ata/ahci_xgene.c:262:33:    right side has type restricted __le16

Signed-off-by: Damien Le Moal 
Reviewed-by: Hannes Reinecke

ata: pata_it821x: convert printk() calls

2022-01-05T10:33:03+00:00

Convert printk() calls to structured logging.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: pata_it821x: Fix possible doc-rotted function names

2021-03-31T02:21:25+00:00

Fixes the following W=1 kernel build warning(s):

 drivers/ata/pata_it821x.c:346: warning: expecting prototype for it821x_passthru_dma_start(). Prototype was for it821x_passthru_bmdma_start() instead
 drivers/ata/pata_it821x.c:369: warning: expecting prototype for it821x_passthru_dma_stop(). Prototype was for it821x_passthru_bmdma_stop() instead

Cc: Jens Axboe 
Cc: Alan Cox 
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones 
Link: https://lore.kernel.org/r/20210318085150.3131936-6-lee.jones@linaro.org
Signed-off-by: Jens Axboe

pata_it821x: Delete an error message for a failed memory allocation in it821x_firmware_command()

2018-02-18T13:26:07+00:00

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Tejun Heo

ata: pata_it821x: Replace mdelay with usleep_range in it821x_firmware_command

2018-01-25T15:28:23+00:00

After checking all possible call chains to it821x_firmware_command here,
my tool finds that it821x_firmware_command
is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
And it821x_firmware_command calls kmalloc(GFP_KERNEL),
so it proves again that it821x_firmware_command
can call functions which can sleep.
Thus mdelay can be replaced with usleep_range to avoid busy wait.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai 
Signed-off-by: Tejun Heo

pata_it821x: use "const char *" for string literals

2015-10-15T14:58:53+00:00

Some string literals are pointed to by "char *".  This patch fixes
that.

tj: Updated patch title and description.

Signed-off-by: LABBE Corentin 
Signed-off-by: Tejun Heo

ata: use CONFIG_PM_SLEEP instead of CONFIG_PM where applicable in host drivers

2014-05-10T02:37:49+00:00

This patch fixes host drivers to use CONFIG_PM_SLEEP instead of CONFIG_PM
where applicable.  Benefits of this change:

* unused code is not being compiled in for CONFIG_PM=y, CONFIG_PM_SLEEP=n
  and CONFIG_PM_RUNTIME=y configurations

* easier transition to use struct dev_pm_ops and SIMPLE_DEV_PM_OPS() in
  the future

* more consistent code (there are host drivers which are using the correct
  CONFIG_PM_SLEEP checks already)

The patch leaves the core libata code and ->port_[suspend,resume] support
in sata_[inic162x,nv,sil24].c alone for now.

Signed-off-by: Bartlomiej Zolnierkiewicz 
Signed-off-by: Tejun Heo

ata: delete non-required instances of include

2014-02-13T21:40:56+00:00

None of these files are actually using any __init type directives
and hence don't need to include .  Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.

Cc: linux-ide@vger.kernel.org
Signed-off-by: Paul Gortmaker 
Signed-off-by: Tejun Heo

ata: use pci_get_drvdata()

2013-06-03T05:22:03+00:00

Use the wrapper function for getting the driver data using pci_dev
instead of using dev_get_drvdata() with &pdev->dev, so we can directly
pass a struct pci_dev.  This is a purely cosmetic change.

Signed-off-by: Jingoo Han 
Signed-off-by: Tejun Heo

ata: use module_pci_driver

2012-07-25T19:12:11+00:00

This patch converts the drivers in drivers/ata/* to use module_pci_driver()
macro which makes the code smaller and a bit simpler.

Signed-off-by: Axel Lin 
Cc: Alan Cox 
Cc: Jeff Garzik 
Cc: Mikael Pettersson 
Cc: Mark Lord 
Cc: Jeremy Higdon 
Cc: Benjamin Herrenschmidt 
Signed-off-by: Jeff Garzik