linux-toradex.git/drivers/ata/pata_pxa.c, branch v7.0-rc2

ata: pata_pxa: Fix potential NULL pointer dereference in pxa_ata_probe()

2025-04-08T03:36:03+00:00

devm_ioremap() returns NULL on error. Currently, pxa_ata_probe() does
not check for this case, which can result in a NULL pointer dereference.

Add NULL check after devm_ioremap() to prevent this issue.

Fixes: 2dc6c6f15da9 ("[ARM] pata_pxa: DMA-capable PATA driver")
Signed-off-by: Henry Martin 
Signed-off-by: Damien Le Moal

ata: Switch back to struct platform_driver::remove()

2024-10-17T07:55:08+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all platform drivers below drivers/ata/ to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.

While touching these files, make indention of the struct initializer
consistent in several files.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Damien Le Moal 
Link: https://lore.kernel.org/r/20241016141609.27329-2-u.kleine-koenig@baylibre.com
Signed-off-by: Niklas Cassel

ata: pata_pxa: convert not to use dma_request_slave_channel()

2023-11-20T00:28:25+00:00

dma_request_slave_channel() is deprecated. dma_request_chan() should
be used directly instead.

Switch to the preferred function and update the error handling accordingly.
While at it, also propagate the error code that is now available.

Signed-off-by: Christophe JAILLET 
Reviewed-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal

ata: pata_pxa: Convert to platform remove callback returning void

2023-08-02T08:55:52+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal

scsi: ata: Declare SCSI host templates const

2023-03-24T23:19:19+00:00

Make it explicit that ATA host templates are not modified.

Reviewed-by: Linus Walleij 
Acked-by: Damien Le Moal 
Reviewed-by: Serge Semin  (for DWC AHCI SATA)
Reviewed-by: John Garry 
Reviewed-by: Jon Hunter  (for Tegra)
Cc: Christoph Hellwig 
Cc: Ming Lei 
Cc: Hannes Reinecke 
Cc: John Garry 
Cc: Mike Christie 
Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20230322195515.1267197-5-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

ata: pata_pxa: Use platform_get_irq() to get the interrupt

2022-03-10T02:17:59+00:00

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypasses the hierarchical setup and messes up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Reported-by: Zeal Robot 
Signed-off-by: Minghao Chi 
Reviewed-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal

ata: make qc_prep return ata_completion_errors

2019-11-01T14:50:51+00:00

In case a driver wants to return an error from qc_prep, return enum
ata_completion_errors. sata_mv is one of those drivers -- see the next
patch. Other drivers return the newly defined AC_ERR_OK.

[v2] use enum ata_completion_errors and AC_ERR_OK.

Signed-off-by: Jiri Slaby 
Cc: Jens Axboe 
Cc: linux-ide@vger.kernel.org
Signed-off-by: Jens Axboe

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18

2019-05-21T09:28:46+00:00

Based on 1 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license as published by
  the free software foundation either version 2 or at your option any
  later version this program is distributed in the hope that it will
  be useful but without any warranty without even the implied warranty
  of merchantability or fitness for a particular purpose see the gnu
  general public license for more details you should have received a
  copy of the gnu general public license along with this program see
  the file copying if not write to the free software foundation 675
  mass ave cambridge ma 02139 usa

extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-or-later

has been chosen to replace the boilerplate/reference in 52 file(s).

Signed-off-by: Thomas Gleixner 
Reviewed-by: Jilayne Lovejoy 
Reviewed-by: Steve Winslow 
Reviewed-by: Kate Stewart 
Reviewed-by: Allison Randal 
Cc: linux-spdx@vger.kernel.org
Link: https://lkml.kernel.org/r/20190519154042.342335923@linutronix.de
Signed-off-by: Greg Kroah-Hartman

ata: pxa: Drop include

2018-12-05T00:15:20+00:00

This driver does not use GPIO or anything from the GPIO header.
Drop the include.

Signed-off-by: Linus Walleij 
Signed-off-by: Jens Axboe

ata: pata_pxa: remove the dmaengine compat need

2018-06-18T19:32:07+00:00

As the pxa architecture switched towards the dmaengine slave map, the
old compatibility mechanism to acquire the dma requestor line number and
priority are not needed anymore.

This patch simplifies the dma resource acquisition, using the more
generic function dma_request_slave_channel().

Signed-off-by: Robert Jarzmik 
Acked-by: Bartlomiej Zolnierkiewicz