linux-toradex.git/drivers/ata/sata_gemini.c, branch v7.2-rc5

ata: sata_gemini: unwind clocks on IDE pinctrl errors

2026-07-03T04:44:18+00:00

gemini_sata_bridge_init() prepares and enables both SATA PCLKs, then
disables them again while keeping the clocks prepared for later bridge
start and stop operations. If gemini_setup_ide_pins() fails after that,
gemini_sata_probe() returns directly and skips the existing
out_unprep_clk unwind path.

Route the IDE pinctrl failure through out_unprep_clk so the clocks
prepared by gemini_sata_bridge_init() are unprepared before probe
fails.

Fixes: d872ced29d5f ("ata: sata_gemini: Introduce explicit IDE pin control")
Co-developed-by: Ijae Kim 
Signed-off-by: Ijae Kim 
Signed-off-by: Myeonghun Pak 
Reviewed-by: Niklas Cassel 
Reviewed-by: Linus Walleij 
Signed-off-by: Damien Le Moal

ata: sata_gemini: Remove remaining reset glue

2024-12-16T13:36:27+00:00

Now that gemini_sata_reset_bridge() is gone, we can remove
the sata0/1_reset members and the code that creates them.

Signed-off-by: Dr. David Alan Gilbert 
Reviewed-by: Linus Walleij 
Signed-off-by: Damien Le Moal

ata: sata_gemini: Remove unused gemini_sata_reset_bridge()

2024-12-11T04:18:25+00:00

gemini_sata_reset_bridge() was added in 2017 by the initial
commit be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
but has never been used.

Remove it.

Signed-off-by: Dr. David Alan Gilbert 
Signed-off-by: Damien Le Moal

ata: Switch back to struct platform_driver::remove()

2024-10-17T07:55:08+00:00

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers.

Convert all platform drivers below drivers/ata/ to use .remove(), with
the eventual goal to drop struct platform_driver::remove_new(). As
.remove() and .remove_new() have the same prototypes, conversion is done
by just changing the structure member name in the driver initializer.

While touching these files, make indention of the struct initializer
consistent in several files.

Signed-off-by: Uwe Kleine-König 
Reviewed-by: Damien Le Moal 
Link: https://lore.kernel.org/r/20241016141609.27329-2-u.kleine-koenig@baylibre.com
Signed-off-by: Niklas Cassel

ata: sata_gemini: Enable module autoloading

2024-09-01T23:06:23+00:00

Add MODULE_DEVICE_TABLE(), so modules can be properly autoloaded based
on the alias from of_device_id table.

Signed-off-by: Liao Chen 
Reviewed-by: Linus Walleij 
Signed-off-by: Damien Le Moal

ata: sata_gemini: Check clk_enable() result

2024-04-04T03:42:00+00:00

The call to clk_enable() in gemini_sata_start_bridge() can fail.
Add a check to detect such failure.

Signed-off-by: Chen Ni 
Signed-off-by: Damien Le Moal

ata: sata_gemini: Add missing MODULE_DESCRIPTION

2023-08-24T23:21:29+00:00

Add the missing MODULE_DESCRIPTION() to avoid warnings such as:

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/ata/sata_gemini.o

when compiling with W=1.

Fixes: be4e456ed3a5 ("ata: Add driver for Faraday Technology FTIDE010")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal 
Reviewed-by: Linus Walleij

ata: sata_gemini: Convert to platform remove callback returning void

2023-08-02T08:55:52+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Damien Le Moal

ata: Explicitly include correct DT includes

2023-08-02T08:37:05+00:00

The DT of_device.h and of_platform.h date back to the separate
of_platform_bus_type before it as merged into the regular platform bus.
As part of that merge prepping Arm DT support 13 years ago, they
"temporarily" include each other. They also include platform_device.h
and of.h. As a result, there's a pretty much random mix of those include
files used throughout the tree. In order to detangle these headers and
replace the implicit includes with struct declarations, users need to
explicitly include the correct includes.

Signed-off-by: Rob Herring 
Signed-off-by: Damien Le Moal

ata: sata_gemini: Remove dependency on OF for compile tests

2022-10-17T23:04:46+00:00

If CONFIG_OF is disabled, then using the macro of_match_ptr() results
in the gemini_sata_of_match variable being unused, which generates a
compilation warning and a compilation error if CONFIG_WERROR is enabled.

Removing the use of this macro by directly assigning the
gemini_sata_of_match match table to the .of_match_table field in the
platform driver definition allows removing the dependency on OF for
compile tests, thus improving compile test coverage.

Fixes: f7220eac752f ("ata: Kconfig: fix sata gemini compile test condition")
Signed-off-by: Damien Le Moal 
Reviewed-by: Linus Walleij