linux-toradex.git/drivers/ata/sata_mv.c, branch v6.7

ata: sata_mv: aspeed: fix value check in mv_platform_probe()

2023-10-11T08:51:53+00:00

In mv_platform_probe(), check the return value of clk_prepare_enable()
and return the error code if clk_prepare_enable() returns an
unexpected value.

Signed-off-by: Ma Ke 
Reviewed-by: Niklas Cassel 
Signed-off-by: Damien Le Moal

ata: sata_mv: Fix incorrect string length computation in mv_dump_mem()

2023-09-11T06:13:35+00:00

snprintf() returns the "number of characters which *would* be generated for
the given input", not the size *really* generated.

In order to avoid too large values for 'o' (and potential negative values
for "sizeof(linebuf) o") use scnprintf() instead of snprintf().

Note that given the "w < 4" in the for loop, the buffer can NOT
overflow, but using the *right* function is always better.

Signed-off-by: Christophe JAILLET 
Signed-off-by: Damien Le Moal

ata: sata_mv: Convert to platform remove callback returning void

2023-08-02T08:55:52+00:00

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Damien Le Moal

ata: fix debounce timings type

2023-08-02T08:37:06+00:00

sata_deb_timing_{hotplug|long|normal}[] store 'unsigned long' debounce
timeouts in ms, while sata_link_debounce() eventually uses those timeouts
by calling ata_{deadline|msleep}( which take just 'unsigned int'.  Change
the debounce timeout table element's type to 'unsigned int' -- all these
timeouts happily fit into 'unsigned int'...

Signed-off-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal

scsi: ata: Declare SCSI host templates const

2023-03-24T23:19:19+00:00

Make it explicit that ATA host templates are not modified.

Reviewed-by: Linus Walleij 
Acked-by: Damien Le Moal 
Reviewed-by: Serge Semin  (for DWC AHCI SATA)
Reviewed-by: John Garry 
Reviewed-by: Jon Hunter  (for Tegra)
Cc: Christoph Hellwig 
Cc: Ming Lei 
Cc: Hannes Reinecke 
Cc: John Garry 
Cc: Mike Christie 
Signed-off-by: Bart Van Assche 
Link: https://lore.kernel.org/r/20230322195515.1267197-5-bvanassche@acm.org
Signed-off-by: Martin K. Petersen

ata: sata_mv: Fixes expected number of resources now IRQs are gone

2022-08-02T22:59:12+00:00

The commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ
resource from DT core") stopped IRQ resources being available as
platform resources. This broke the sanity check for the expected
number of resources in the Marvell SATA driver which expected two
resources, the IO memory and the interrupt.

Change the sanity check to only expect the IO memory.

Cc: Lad Prabhakar 
Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
Cc: 
Signed-off-by: Andrew Lunn 
Signed-off-by: Damien Le Moal

ata: Drop commas after OF match table sentinels

2022-03-07T02:49:10+00:00

It does not make sense to have a comma after a sentinel, as any new
elements must be added before the sentinel.

Add comments to clarify the purpose of the empty elements.
Rewrap entries to a single line to have a consistent style.

Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Sergey Shtylyov 
Acked-by: Florian Fainelli  [ahci_brcm]
Reviewed-by: Kieran Bingham 
Reviewed-by: Linus Walleij 
Signed-off-by: Damien Le Moal

ata: libata: make ata_host_suspend() void

2022-02-19T02:18:35+00:00

ata_host_suspend() always returns 0, so the result checks in many drivers
look pointless.  Let's make this function return *void* instead of *int*.

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Signed-off-by: Sergey Shtylyov 
Acked-by: Uwe Kleine-König 
Reviewed-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: sata_mv: convert remaining printk() to structured logging

2022-01-05T10:33:03+00:00

Refactor the .reset_hc() callback and convert the remaining printk()
calls to structured logging.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal

ata: sata_mv: Drop pointless VPRINTK() call and convert the remaining one

2022-01-05T10:33:02+00:00

Drop pointless VPRINTK() call and convert the remaining one to dev_dbg().

Signed-off-by: Hannes Reinecke 
Signed-off-by: Damien Le Moal