linux-toradex.git/drivers/ata/sata_rcar.c, branch v5.15-rc2

ata: sata_rcar: Fix DMA boundary mask

2020-10-16T15:32:11+00:00

Before commit 9495b7e92f716ab2 ("driver core: platform: Initialize
dma_parms for platform devices"), the R-Car SATA device didn't have DMA
parameters.  Hence the DMA boundary mask supplied by its driver was
silently ignored, as __scsi_init_queue() doesn't check the return value
of dma_set_seg_boundary(), and the default value of 0xffffffff was used.

Now the device has gained DMA parameters, the driver-supplied value is
used, and the following warning is printed on Salvator-XS:

    DMA-API: sata_rcar ee300000.sata: mapping sg segment across boundary [start=0x00000000ffffe000] [end=0x00000000ffffefff] [boundary=0x000000001ffffffe]
    WARNING: CPU: 5 PID: 38 at kernel/dma/debug.c:1233 debug_dma_map_sg+0x298/0x300

(the range of start/end values depend on whether IOMMU support is
 enabled or not)

The issue here is that SATA_RCAR_DMA_BOUNDARY doesn't have bit 0 set, so
any typical end value, which is odd, will trigger the check.

Fix this by increasing the DMA boundary value by 1.

This also fixes the following WRITE DMA EXT timeout issue:

    # dd if=/dev/urandom of=/mnt/de1/file1-1024M bs=1M count=1024
    ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
    ata1.00: failed command: WRITE DMA EXT
    ata1.00: cmd 35/00:00:00:e6:0c/00:0a:00:00:00/e0 tag 0 dma 1310720 out
    res 40/00:01:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
    ata1.00: status: { DRDY }

as seen by Shimoda-san since commit 429120f3df2dba2b ("block: fix
splitting segments on boundary masks").

Fixes: 8bfbeed58665dbbf ("sata_rcar: correct 'sata_rcar_sht'")
Fixes: 9495b7e92f716ab2 ("driver core: platform: Initialize dma_parms for platform devices")
Fixes: 429120f3df2dba2b ("block: fix splitting segments on boundary masks")
Signed-off-by: Geert Uytterhoeven 
Tested-by: Lad Prabhakar 
Tested-by: Yoshihiro Shimoda 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Greg Kroah-Hartman 
Reviewed-by: Sergei Shtylyov 
Reviewed-by: Ulf Hansson 
Cc: stable 
Signed-off-by: Jens Axboe

sata_rcar: handle pm_runtime_get_sync failure cases

2020-06-05T03:14:50+00:00

Calling pm_runtime_get_sync increments the counter even in case of
failure, causing incorrect ref count. Call pm_runtime_put if
pm_runtime_get_sync fails.

Signed-off-by: Navid Emamdoost 
Signed-off-by: Jens Axboe

ata: make qc_prep return ata_completion_errors

2019-11-01T14:50:51+00:00

In case a driver wants to return an error from qc_prep, return enum
ata_completion_errors. sata_mv is one of those drivers -- see the next
patch. Other drivers return the newly defined AC_ERR_OK.

[v2] use enum ata_completion_errors and AC_ERR_OK.

Signed-off-by: Jiri Slaby 
Cc: Jens Axboe 
Cc: linux-ide@vger.kernel.org
Signed-off-by: Jens Axboe

sata_rcar: Remove ata_host_alloc() error printing

2019-05-09T17:19:32+00:00

ata_host_alloc() can only fail due to memory allocation failures.
Hence there is no need to print a message, as the memory allocation core
code already takes care of that.

Reviewed-by: Simon Horman 
Reviewed-by: Sergei Shtylyov 
Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Jens Axboe

sata_rcar: fix deferred probing

2018-12-10T18:10:31+00:00

The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver would fail the probe
permanently instead of the deferred probing. Switch to propagating the
error code upstream, still checking/overriding IRQ0 as libata regards it
as "no IRQ" (thus polling) anyway...

Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Reviewed-by: Simon Horman 
Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Sergei Shtylyov 
Signed-off-by: Jens Axboe

sata_rcar: convert to SPDX identifiers

2018-11-08T13:32:16+00:00

This patch updates license to use SPDX-License-Identifier
instead of verbose license text.

Signed-off-by: Kuninori Morimoto 
Signed-off-by: Jens Axboe

ata: sata_rcar: exclude setting of PHY registers in Gen3

2018-08-06T17:25:34+00:00

According to documentation, setting of PHY registers is unnecessary with
R-Car Gen3. The registers are not even described. So, don't initialize
them.

Signed-off-by: Masaharu Hayakawa 
[wsa: updated commit message]
Signed-off-by: Wolfram Sang 
Reviewed-by: Sergei Shtylyov 
Signed-off-by: Tejun Heo

ata: sata_rcar: really mask all interrupts on Gen2 and later

2018-08-06T17:25:01+00:00

Since R-Car Gen2, a new bit has been introduced to the interrupt mask
register. Update the code to handle it properly as well.

Signed-off-by: Wolfram Sang 
Reviewed-by: Sergei Shtylyov 
Signed-off-by: Tejun Heo

ata: sata_rcar: Add rudimentary Runtime PM support

2018-07-23T15:18:43+00:00

Replace the explicit clock handling to enable/disable the SATA module by
calls to Runtime PM.

This makes the driver independent of actual SoC clock/power hierarchies,
and is needed to support virtualization, where the guest is not in full
control of power management.

Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Sergei Shtylyov 
Signed-off-by: Tejun Heo

ata: sata_rcar: Provide a short-hand for &pdev->dev

2018-07-23T15:18:43+00:00

No functional changes.

Signed-off-by: Geert Uytterhoeven 
Reviewed-by: Sergei Shtylyov 
Signed-off-by: Tejun Heo