linux-toradex.git/drivers/ata, branch v2.6.23.12

libata: kill spurious NCQ completion detection

2007-12-14T17:51:15+00:00

patch 459ad68893a84fb0881e57919340b97edbbc3dc7 in mainline.

Spurious NCQ completion detection implemented in ahci was incorrect.
On AHCI receving and processing FISes and raising interrupts are not
interlocked and spurious interrupts are expected.

For example, if an interrupt occurs while interrupt handler is running
and the running interrupt handler handles the event the new IRQ
indicated, after IRQ handler finishes, it will be executed again
because IRQ pending bit is set by the new interrupt but there won't be
anything to process.

Please read the following message for more information.

  http://article.gmane.org/gmane.linux.ide/26012

This patch...

* Removes all spurious IRQ whining from ahci.  Spurious NCQ completion
  detection was completely wrong.  Spurious D2H Register FIS taught us
  that some early drives send spurious D2H Register FIS with I bit set
  while NCQ commands are in progress but none of recent drives does
  that and even the ones which show such behavior can do NCQ fine.

* Kills all NCQ blacklist entries which were added because of spurious
  NCQ completions.  I tracked down each commit and verified all
  removed ones are actually added because of spurious completions.

  WD740ADFD-00NLR1 wasn't deleted but moved upward because the drive
  not only had spurious NCQ completions but also is slow on sequential
  data transfers if NCQ is enabled.

  Maxtor 7V300F0 was added by 0e3dbc01d53940fe10e5a5cfec15ede3e929c918
  from Alan Cox.  I can only find evidences that the drive only had
  troubles with spuruious completions by searching the mailing list.
  This entry needs to be verified and removed if it doesn't have other
  NCQ related problems.

Signed-off-by: Tejun Heo 
Cc: Alan Cox 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: sata_sis: use correct S/G table size

2007-11-26T17:42:30+00:00

patch 96af154710d44b574515431a0bb014888398a741 in mainline.

[libata] sata_sis: use correct S/G table size

sata_sis has the same restrictions as other SFF controllers, and so must
use LIBATA_MAX_PRD to denote that SCSI may only fill ATA_MAX_PRD/2
entries, due to our need to handle IOMMU merging.

Signed-off-by: Jeff Garzik 
Cc: Tobias Powalowski 
Signed-off-by: Greg Kroah-Hartman

sata_sis: fix SCR read breakage

2007-11-26T17:42:30+00:00

patch aaa092a114696f4425cd57c4d7fa05110007e247 in mainline.

sata_sis: fix SCR read breakage

SCR read for controllers which uses PCI configuration space for SCR
access got broken while adding @val argument to SCR accessors.  Fix
it.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik 
Cc: Tobias Powalowski 
Signed-off-by: Greg Kroah-Hartman

libata: backport ATA_FLAG_NO_SRST and ATA_FLAG_ASSUME_ATA, part 2

2007-11-16T17:30:25+00:00

Differs from mainline, but the functionality is already there.

P5W-DH Deluxe has ICH7R which doesn't have PMP support but SIMG 4726
hardwired to the second port of AHCI controller at PCI device 1f.2.
The 4726 doesn't work as PMP but as a storage processor which can do
hardware RAID on downstream ports.

When no device is attached to the downstream port of the 4726, pseudo
ATA device for configuration appears.  Unfortunately, ATA emulation on
the device is very lousy and causes long hang during boot.

This patch implements workaround for the board.  If the mainboard is
P5W-DH Deluxe (matched using DMI), only hardreset is used on the
second port of AHCI controller @ 1f.2 and the hardreset doesn't depend
on receiving the first FIS and just proceed to IDENTIFY.

This workaround fixes bugzilla #8923.

  http://bugzilla.kernel.org/show_bug.cgi?id=8923

Signed-off-by: Tejun Heo 
Cc: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: backport ATA_FLAG_NO_SRST and ATA_FLAG_ASSUME_ATA

2007-11-16T17:30:25+00:00

Differs from mainline, but the functionality is already there.

Backport ATA_FLAG_NO_SRST and ATA_FLAG_ASSUME_ATA.  These are
originally link flags (ATA_LFLAG_*) but link abstraction doesn't exist
on 2.6.23, so make it port flags.

This is for the following workaround for ASUS P5W DH Deluxe.

These new flags don't introduce any behavior change unless set and
nobody sets them yet.

Signed-off-by: Tejun Heo 
Cc: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: add HTS542525K9SA00 to NCQ blacklist

2007-11-16T17:30:24+00:00

patch e14cbfa630cd3ab2631ee21b718b290928f47868 in mainline.

Another one doing spurious NCQ completions.  Blacklist it.

Signed-off-by: Tejun Heo 
Cc: Luca Tettamanti 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: sync NCQ blacklist with upstream

2007-11-16T17:30:21+00:00

Synchronize NCQ blacklist with the current upstream.  Based on changes
already in Linus's 2.6.24-rc kernel tree.

Signed-off-by: Tejun Heo 
Cc: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: sata_mv: more S/G fixes

2007-10-12T16:23:18+00:00

commit 6c08772e49622e90d39903e7ff0be1a0f463ac86 in mainline.

* corruption fix: we only want the lower 16 bits of length (0 == 64kb)

* ditto: the upper layer sets max-phys-segments to LIBATA_MAX_PRD,
  so we must reset it to own hw-specific length.

* delete unused mv_fill_sg() return value

Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

sata_mv: correct S/G table limits

2007-10-09T19:38:26+00:00

The recent mv_fill_sg() rewrite, to fix a data corruption problem
related to IOMMU virtual merging, forgot to account for the
potentially-increased size of the scatter/gather table after its run.

Additionally, the DMA boundary is reduced from 0xffffffff to 0xffff
to more closely match the needs of mv_fill_sg().

Signed-off-by: Jeff Garzik 
Signed-off-by: Linus Torvalds

drivers/ata/pata_ixp4xx_cf.c: ioremap return code check

2007-10-03T18:43:28+00:00

Add missing ioremap return checks.

Signed-off-by: Scott Thompson  hushmail.com>
Acked-by: Tejun Heo 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Jeff Garzik