linux-toradex.git/drivers/ata, branch v2.6.32-rc3

trivial: fix comment typo in drivers/ata/pata_hpt37x.c

2009-09-21T13:15:53+00:00

A comment fix in drivers/ata/pata_hpt37x.c.

Signed-off-by: Krzysztof Ha³asa 
Signed-off-by: Jiri Kosina

libata: Add pata_atp867x driver for Artop/Acard ATP867X controllers

2009-09-17T20:47:06+00:00

This is a new pata driver for ARTOP 867X 64bit 4-channel UDMA133 ATA ctrls.
Based on the Atp867 data sheet rev 1.2, Acard, and in part on early ide codes
from Eric Uhrhane .

Signed-off-by: John(Jung-Ik) Lee 
Reviewed-by:  Grant Grundler 
Reviewed-by:  Gwendal Gringo 
Signed-off-by: Jeff Garzik

pata_amd: do not filter out valid modes in nv_mode_filter

2009-09-17T20:46:41+00:00

On a Compaq Presario V3000 laptop (NVIDIA MCP51 chipset), pata_amd selects
PIO0 mode for the PATA DVD-RAM drive instead of MWDMA2 which it supports:

ata4.00: ATAPI: HL-DT-ST DVDRAM GSA-4084N, KQ09, max MWDMA2
ata4: nv_mode_filter: 0x39f&0x7001->0x1, BIOS=0x0 (0x0) ACPI=0x7001 (60:600:0x11)
ata4.00: configured for PIO0

For some reason, the BIOS-set UDMA configuration returns 0 and the ACPI _GTM
reports that UDMA2 and PIO0 are enabled. This causes nv_mode_filter to end up
allowing only PIO0 and UDMA0-2. Since the drive doesn't support UDMA we end up
using PIO0.

Since the controllers should always support PIO4, MWDMA2 and UDMA2 regardless
of what cable type is used, let's make sure we don't filter out these modes
regardless of what wacky settings the BIOS is using.

Signed-off-by: Robert Hancock 
Cc: stable@kernel.org
Signed-off-by: Jeff Garzik

sata_promise: update reset code

2009-09-17T20:46:34+00:00

sata_promise's reset code has deviated quite a bit from
the Promise reference driver's, and it has been observed
to fail to recover from errors in some cases.

This patch thus updates the reset code to more closely
match the reference driver:

- soft reset (pdc_reset_port):
  * wait for ATA engine to not be in packet command mode
    (2nd gen only)
  * write reset bit in PDC_CTLSTAT before the first read
    in the loop
  * for 2nd gen SATA follow up with FPDMA reset and clearing
    error status registers
- hard reset (pdc_sata_hardreset):
  * wait for ATA engine to not be in packet command mode
    (2nd gen only)
  * reset ATA engine via the PCI control register
  * Tejun's change to use non-waiting hardreset + follow-up SRST

I'm not changing the hotplug mask bits since they are taken care
of by sata_promise's ->freeze() and ->thaw() operations. And I'm
not writing the PMP port # because that's always zero (for now).

Tested here on various controllers. In particular, one disk
which used to timeout and fail to recover from certain hdparm
and smartmonctl commands now works nicely.

Signed-off-by: Mikael Pettersson 
Signed-off-by: Jeff Garzik

sata_promise: disable hotplug on 1st gen chips

2009-09-17T20:46:12+00:00

1st generation Promise SATA chips are prone to generating spurious
hotplug events which can disrupt normal operation. This has been
observed on 20376 and 20378 chips. This patch thus disables hotplug
support on 1st gen chips while leaving it enabled for 2nd gen chips.

The pdc_sata_hotplug_offset() function becomes redundant so it is
removed.

Tested on 1st gen 20376 and 20378 mainboard chips and on a 2nd gen
SATA300 PCI card.

Signed-off-by: Mikael Pettersson 
Tested-by: Kurt Roeckx 
Signed-off-by: Jeff Garzik

libata: fix spurious WARN_ON_ONCE() on port freeze

2009-09-17T20:45:40+00:00

Commit 54c38444fad6a99b4b19512f8f0055d69115e69e makes libata abort qcs
after the port is frozen.  This is necessary to guarantee that TF
registers are accessed after the DMA engine is shutdown after an
error.  However, this triggers WARN_ON_ONCE() check in
ata_qc_complete() spuriously.  Move WARN_ON_ONCE() downwards such that
failing commands while frozen doesn't trigger it.

Signed-off-by: Tejun Heo 
Cc: stable 
Signed-off-by: Jeff Garzik

ahci: restore pci_intx() handling

2009-09-17T20:45:38+00:00

Commit a5bfc4714b3f01365aef89a92673f2ceb1ccf246 dropped explicit
pci_intx() manipulation from ahci because it seemed unnecessary and
ahci doesn't seem to be the right place to be tweaking it if it were.
This was largely okay but there are exceptions.  There was one on an
embedded platform which was fixed via firmware and now bko#14124
reports it on a HP DL320.

  http://bugzilla.kernel.org/show_bug.cgi?id=14124

I still think this isn't something libata drivers should be caring
about (the only ones which are calling pci_intx() explicitly are
libata ones and one other driver) but for now reverting the change
seems to be the right thing to do.

Signed-off-by: Tejun Heo 
Reported-by: Thomas Jarosch 
Signed-off-by: Jeff Garzik

pata_rz1000: use printk_once

2009-09-11T06:33:59+00:00

Signed-off-by: Marcin Slusarz 
Signed-off-by: Jeff Garzik

ahci: kill @force_restart and refine CLO for ahci_kick_engine()

2009-09-11T06:31:52+00:00

This patch refines ahci_kick_engine() after discussion with Tejun about
FBS(FIS-based switching) support preparation:
a. Kill @force_restart and always kick the engine. The only case where
   @force_restart is zero is when it's called from ahci_p5wdh_hardreset()
   Actually at that point, BSY is pretty much guaranteed to be set.
b. If PMP is attached, ignore busy and always do CLO. (AHCI-1.3 9.2)

Signed-off-by: Shane Huang 
Acked-by: Tejun Heo 
Signed-off-by: Jeff Garzik

pata_cs5535: add pci id for AMD based CS5535 controllers

2009-09-11T06:31:31+00:00

Signed-off-by: Otavio Salvador 
Signed-off-by: Jeff Garzik