linux-toradex.git/drivers/ata, branch v2.6.32.22

libata: skip EH autopsy and recovery during suspend

2010-09-20T20:17:51+00:00

commit e2f3d75fc0e4a0d03c61872bad39ffa2e74a04ff upstream.

For some mysterious reason, certain hardware reacts badly to usual EH
actions while the system is going for suspend.  As the devices won't
be needed until the system is resumed, ask EH to skip usual autopsy
and recovery and proceed directly to suspend.

Signed-off-by: Tejun Heo 
Tested-by: Stephan Diestelhorst 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

sata_mv: fix broken DSM/TRIM support (v2)

2010-09-20T20:17:44+00:00

commit 44b733809a5aba7f6b15a548d31a56d25bf3851c upstream.

Fix DSM/TRIM commands in sata_mv (v2).
These need to be issued using old-school "BM DMA",
rather than via the EDMA host queue.

Since the chips don't have proper BM DMA status,
we need to be more careful with setting the ATA_DMA_INTR bit,
since DSM/TRIM often has a long delay between "DMA complete"
and "command complete".

GEN_I chips don't have BM DMA, so no TRIM for them.

Signed-off-by: Mark Lord 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ata_piix: fix locking around SIDPR access

2010-08-13T20:19:30+00:00

commit 213373cf974fe69e78ec894b07f45ae2f5a3a078 upstream.

SIDPR window registers are shared across ports and as each access is
done in two steps, accesses to different ports under EH may race.
This primarily is caused by incorrect host locking in EH context and
should be fixed by defining locking requirements for each EH operation
which can be used during EH and enforcing them but for now work around
the problem by adding a dedicated SIDPR lock and grabbing it for each
SIDPR access.

Signed-off-by: Tejun Heo 
Reported-by: Mark Knecht 
Reported-by: Paul Check 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

sata_via: magic vt6421 fix for transmission problems w/ WD drives

2010-07-05T18:11:05+00:00

commit 8b27ff4cf6d15964aa2987aeb58db4dfb1f87a19 upstream.

vt6421 has problems talking to recent WD drives.  It causes a lot of
transmission errors while high bandwidth transfer as reported in the
following bugzilla entry.

  https://bugzilla.kernel.org/show_bug.cgi?id=15173

Joseph Chan provided the following fix.  I don't have any idea what it
does but I can verify the issue is gone with the patch applied.

Signed-off-by: Tejun Heo 
Originally-from: Joseph Chan 
Reported-by: Jorrit Tijben 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

sata_nv: don't diddle with nIEN on mcp55

2010-07-05T18:11:05+00:00

commit f3faf8fc3fab45c3526efe8c9e99bb23f8723350 upstream.

On mcp55, nIEN gets stuck once set and liteon blueray rom iHOS104-08
violates ATA specification and fails to set I on D2H Reg FIS if nIEN
is set when the command was issued.  When the other party is following
the spec, both devices can work fine but when the two flaws are put
together, they can't talk to each other.

mcp55 has its own IRQ masking mechanism and there's no reason to mess
with nIEN in the first place.  Fix it by dropping nIEN diddling from
nv_mcp55_freeze/thaw().

This was originally reported by Cengiz.  Although Cengiz hasn't
verified the fix yet, I could reproduce this problem and verfiy the
fix.  Even if Cengiz is experiencing different or additional problems,
this patch is needed.

Signed-off-by: Tejun Heo 
Reported-by: Cengiz Günay 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: don't flush dcache on slab pages

2010-07-05T18:10:31+00:00

commit 3842e835490cdf17013b30a788f6311bdcfd0571 upstream.

page_mapping() check this via VM_BUG_ON(PageSlab(page)) so we bug here
with the according debuging turned on.

Future TODO: replace this with a flush_dcache_page_for_pio() API

Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: disable ATAPI AN by default

2010-07-05T18:10:31+00:00

commit e7ecd435692ca9bde9d124be30b3a26e672ea6c2 upstream.

There are ATAPI devices which raise AN when hit by commands issued by
open().  This leads to infinite loop of AN -> MEDIA_CHANGE uevent ->
udev open() to check media -> AN.

Both ACS and SerialATA standards don't define in which case ATAPI
devices are supposed to raise or not raise AN.  They both list media
insertion event as a possible use case for ATAPI ANs but there is no
clear description of what constitutes such events.  As such, it seems
a bit too naive to export ANs directly to userland as MEDIA_CHANGE
events without further verification (which should behave similarly to
windows as it apparently is the only thing that some hardware vendors
are testing against).

This patch adds libata.atapi_an module parameter and disables ATAPI AN
by default for now.

Signed-off-by: Tejun Heo 
Cc: Kay Sievers 
Cc: Nick Bowler 
Cc: David Zeuthen 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

sata_nv: use ata_pci_sff_activate_host() instead of ata_host_activate()

2010-07-05T18:10:27+00:00

commit 95cc2c70c139936a2142bcd583da8af6f9d88efb upstream.

sata_nv was incorrectly using ata_host_activate() instead of
ata_pci_sff_activate_host() leading to IRQ assignment failure in
legacy mode.  Fix it.

Signed-off-by: Tejun Heo 
Cc: Robert Hancock 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: ensure NCQ error result taskfile is fully initialized before returning it via qc->result_tf.

2010-05-12T21:57:00+00:00

commit a09bf4cd53b8ab000197ef81f15d50f29ecf973c upstream.

Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: fix locking around blk_abort_request()

2010-05-12T21:56:59+00:00

commit fa41efdae7de61191a7bda3a00e88ef69afb5bb9 upstream.

blk_abort_request() expectes queue lock to be held by the caller.
Grab it before calling the function.

Lack of this synchronization led to infinite loop on corrupt
q->timeout_list.

Signed-off-by: Tejun Heo 
Cc: Jens Axboe 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman