linux-toradex.git/drivers/ata, branch v2.6.32.41

libata: set queue DMA alignment to sector size for ATAPI too

2011-05-09T22:55:41+00:00

commit 729a6a300e628a48cf12bac93a964a535e83cd1d upstream.

ata_pio_sectors() expects buffer for each sector to be contained in a
single page; otherwise, it ends up overrunning the first page.  This
is achieved by setting queue DMA alignment.  If sector_size is smaller
than PAGE_SIZE and all buffers are sector_size aligned, buffer for
each sector is always contained in a single page.

This wasn't applied to ATAPI devices but IDENTIFY_PACKET is executed
as ATA_PROT_PIO and thus uses ata_pio_sectors().  Newer versions of
udev issue IDENTIFY_PACKET with unaligned buffer triggering the
problem and causing oops.

This patch fixes the problem by setting sdev->sector_size to
ATA_SECT_SIZE on ATATPI devices and always setting DMA alignment to
sector_size.  While at it, add a warning for the unlikely but still
possible scenario where sector_size is larger than PAGE_SIZE, in which
case the alignment wouldn't be enough.

Signed-off-by: Tejun Heo 
Reported-by: John Stanley 
Tested-by: John Stanley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Jonathan Liu 
Signed-off-by: Greg Kroah-Hartman

sata_via: Delay on vt6420 when starting ATAPI DMA write

2011-05-09T22:55:40+00:00

commit a55ab496ea9c820b7192c15ef1fbf3291edfe638 upstream.

When writing a disc on certain lite-on dvd-writers (also rebadged
as optiarc/LG/...) connected to a vt6420, the ATAPI CDB ends
up in the datastream and on the disc, causing silent corruption.
Delaying between sending the CDB and starting DMA seems to
prevent this.

I do not know if there are burners that do not suffer from
this, but the patch should be safe for those as well.

There are many reports of this issue, but AFAICT no solution was
found before. For example:
http://lkml.indiana.edu/hypermail/linux/kernel/0802.3/0561.html

Signed-off-by: Bart Hartgers 
Signed-off-by: Jeff Garzik 
[bwh: Remove version bump for 2.6.32]
Signed-off-by: Greg Kroah-Hartman

ahci: AHCI mode SATA patch for Intel Patsburg SATA RAID controller

2011-03-23T20:16:42+00:00

commit 64a3903d0885879ba8706a8bcf71c5e3e7664db2 upstream.

This patch adds an updated SATA RAID DeviceID for the Intel Patsburg PCH.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ahci: AHCI mode SATA patch for Intel DH89xxCC DeviceIDs

2011-03-23T20:16:41+00:00

commit a4a461a6df6c0481d5a3d61660ed97f5b539cf16 upstream.

This patch adds the AHCI-mode SATA DeviceID for the Intel DH89xxCC PCH.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

ahci: AHCI and RAID mode SATA patch for Intel Patsburg DeviceIDs

2011-03-23T20:16:41+00:00

commit 992b3fb9b5391bc4de5b42bb810dc6dd583a6c4a upstream.

This patch adds the Intel Patsburg (PCH) SATA AHCI and RAID Controller
DeviceIDs.

Signed-off-by: Seth Heasley 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: no special completion processing for EH commands

2011-03-23T20:16:37+00:00

commit f08dc1ac6b15c681f4643d8da1700e06c3855608 upstream.

ata_qc_complete() contains special handling for certain commands.  For
example, it schedules EH for device revalidation after certain
configurations are changed.  These shouldn't be applied to EH
commands but they were.

In most cases, it doesn't cause an actual problem because EH doesn't
issue any command which would trigger special handling; however, ACPI
can issue such commands via _GTF which can cause weird interactions.

Restructure ata_qc_complete() such that EH commands are always passed
on to __ata_qc_complete().

stable: Please apply to -stable only after 2.6.38 is released.

Signed-off-by: Tejun Heo 
Reported-by: Kyle McMartin 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

pata_mpc52xx: inherit from ata_bmdma_port_ops

2011-02-17T23:37:10+00:00

commit 77c5fd19075d299fe820bb59bb21b0b113676e20 upstream.

pata_mpc52xx supports BMDMA but inherits ata_sff_port_ops which
triggers BUG_ON() when a DMA command is issued.  Fix it.

Signed-off-by: Tejun Heo 
Reported-by: Roman Fietze 
Cc: Sergei Shtylyov 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata: fix NULL sdev dereference race in atapi_qc_complete()

2010-12-09T21:26:52+00:00

commit 2a5f07b5ec098edc69e05fdd2f35d3fbb1235723 upstream.

SCSI commands may be issued between __scsi_add_device() and dev->sdev
assignment, so it's unsafe for ata_qc_complete() to dereference
dev->sdev->locked without checking whether it's NULL or not.  Fix it.

Signed-off-by: Tejun Heo 
Signed-off-by: Jeff Garzik 
Signed-off-by: Greg Kroah-Hartman

libata-scsi passthru: fix bug which truncated LBA48 return values

2010-12-09T21:26:52+00:00

commit bc496ed00ab1411d3efaf295b72e0c9eb343e1a3 upstream.

Fix assignment which overwrote SAT ATA PASS-THROUGH command EXTEND
bit setting (ATA_TFLAG_LBA48)

Signed-off-by: Douglas Gilbert 
Signed-off-by: Jeff Garzik 
Cc: Kerin Millar 
Signed-off-by: Greg Kroah-Hartman

ata_generic: implement ATA_GEN_* flags and force enable DMA on MBP 7,1

2010-12-09T21:26:41+00:00

commit 1529c69adce1e95f7ae72f0441590c226bbac7fc upstream.

IDE mode of MCP89 on MBP 7,1 doesn't set DMA enable bits in the BMDMA
status register.  Make the following changes to work around the problem.

* Instead of using hard coded 1 in id->driver_data as class code
  match, use ATA_GEN_CLASS_MATCH and carry the matched id in
  host->private_data.

* Instead of matching PCI_VENDOR_ID_CENATEK, use ATA_GEN_FORCE_DMA
  flag in id instead.

* Add ATA_GEN_FORCE_DMA to the id entry of MBP 7,1.

Signed-off-by: Tejun Heo 
Cc: Peer Chen 
Reported-by: Anders Østhus 
Reported-by: Andreas Graf 
Reported-by: Benoit Gschwind 
Reported-by: Damien Cassou 
Reported-by: tixetsal@juno.com
Signed-off-by: Jeff Garzik 
Cc: Nobuhiro Iwamatsu 
Signed-off-by: Greg Kroah-Hartman