linux-toradex.git/drivers/atm, branch v4.4.93

atm: iphase: fix misleading indention

2015-10-13T02:56:27+00:00

Fix a smatch warning:
drivers/atm/iphase.c:1178 rx_pkt() warn: curly braces intended?

The code is correct, the indention is misleading. In case the allocation
of skb fails, we want to skip to the end.

Signed-off-by: Tillmann Heidsieck 
Signed-off-by: David S. Miller

atm: iphase: return -ENOMEM instead of -1 in case of failed kmalloc()

2015-10-13T02:56:26+00:00

Smatch complains about returning hard coded error codes, silence this
warning.

drivers/atm/iphase.c:115 ia_enque_rtn_q() warn: returning -1 instead of -ENOMEM is sloppy

Signed-off-by: Tillmann Heidsieck 
Signed-off-by: David S. Miller

solos-pci: Increase headroom on received packets

2015-09-18T04:29:07+00:00

A comment in include/linux/skbuff.h says that:

 * Various parts of the networking layer expect at least 32 bytes of
 * headroom, you should not reduce this.

This was demonstrated by a panic when handling fragmented IPv6 packets:
http://marc.info/?l=linux-netdev&m=144236093519172&w=2

It's not entirely clear if that comment is still valid — and if it is,
perhaps netif_rx() ought to be enforcing it with a warning.

But either way, it is rather stupid from a performance point of view
for us to be receiving packets into a buffer which doesn't have enough
room to prepend an Ethernet header — it means that *every* incoming
packet is going to be need to be reallocated. So let's fix that.

Signed-off-by: David Woodhouse 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller

atm: he: drop null test before destroy functions

2015-09-15T23:49:43+00:00

Remove unneeded NULL test.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// 
@@ expression x; @@
-if (x != NULL)
  \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
// 

Signed-off-by: Julia Lawall 
Signed-off-by: David S. Miller

atm: idt77105: Use setup_timer

2015-06-11T05:46:34+00:00

Use the timer API function setup_timer instead of structure field
assignments to initialize a timer.

A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:

@change@
expression e1, e2, a;
@@

-init_timer(&e1);
+setup_timer(&e1, a, 0UL);
... when != a = e2
-e1.function = a;

Signed-off-by: Vaishali Thakkar 
Signed-off-by: David S. Miller

atm: use msecs_to_jiffies for conversions

2015-06-08T22:48:45+00:00

API compliance scanning with coccinelle flagged:
./drivers/atm/iphase.c:2621:4-20:
        WARNING: timeout (50) seems HZ dependent

Numeric constants passed to schedule_timeout() make the effective
timeout HZ dependent which does not seem intended.
Fixed up by converting the constant to jiffies with msecs_to_jiffies()
As this driver was introduced in the early 2.3 series it is most
likely assuming HZ=100 so the constant 50 is converted to 500ms.

Signed-off-by: Nicholas Mc Guire 
Signed-off-by: David S. Miller

atm:he - Do not initialise statics to 0.

2015-06-04T22:43:10+00:00

According to  false is always '0' and
Static variables are initialised to 0 by GCC.

Signed-off-by: Shailendra Verma 
Signed-off-by: David S. Miller

atm:he - Change 1 to true for bool type variable.

2015-05-25T20:34:35+00:00

The variable irq_coalesce is bool type.
So assign the value true instead of 1.

Signed-off-by: Shailendra Verma 
Signed-off-by: David S. Miller

drivers: atm: nicstar: remove ifdef'd out skb destructors

2015-03-10T17:34:53+00:00

remove dead code.

Signed-off-by: Florian Westphal 
Signed-off-by: David S. Miller

atm: remove deprecated use of pci api

2015-01-18T05:28:41+00:00

Signed-off-by: Chas Williams - CONTRACTOR 
Signed-off-by: David S. Miller