linux-toradex.git/drivers/atm, branch v4.9.16

atm: fix improper return value

2016-12-05T19:53:46+00:00

It returns variable "error" when ioremap_nocache() returns a NULL
pointer. The value of "error" is 0 then, which will mislead the callers
to believe that there is no error. This patch fixes the bug, returning
"-ENOMEM".

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189021

Signed-off-by: Pan Bian 
Signed-off-by: David S. Miller

atm: lanai: set error code when ioremap fails

2016-12-05T18:27:33+00:00

In function lanai_dev_open(), when the call to ioremap() fails, the
value of return variable result is 0. 0 means no error in this context.
This patch fixes the bug, assigning "-ENOMEM" to result when ioremap()
returns a NULL pointer.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188791

Signed-off-by: Pan Bian 
Signed-off-by: David S. Miller

atm: iphase: fix newline escape and minor tweak to source formatting

2016-09-15T23:15:55+00:00

The newline escape is incorrect and needs fixing. Also adjust source
formatting / indentation and add { } to trailing else.

Signed-off-by: Colin Ian King 
Signed-off-by: David S. Miller

ATM-ZeitNet: Fix indentation for one DPRINTK() call in start_rx()

2016-09-11T04:46:07+00:00

Adjust the indentation for a call of the macro "DPRINTK" in this function.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller

ATM-ZeitNet: Replace one kzalloc() call by kcalloc()

2016-09-11T04:46:07+00:00

* The script "checkpatch.pl" can point information out like the following.

  WARNING: Prefer kcalloc over kzalloc with multiply

  Thus fix the affected source code place.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

* Delete the local variable "size" which became unnecessary with
  this refactoring.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller

ATM-ZeitNet: Improve a size determination in zatm_open()

2016-09-11T04:46:06+00:00

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller

ATM-ZeitNet: Use kmalloc_array() in start_tx()

2016-09-11T04:46:06+00:00

* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kmalloc_array".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller

ATM-nicstar: Refactor a dev_alloc_skb() call in dequeue_rx()

2016-09-11T04:45:25+00:00

The script "checkpatch.pl" can point out that assignments should usually
not be performed within condition checks.
Thus move an assignment for a local variable to a separate statement
in this function.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller

ATM-nicstar: Refactor a kmalloc() call in ns_init_card()

2016-09-11T04:45:25+00:00

* The script "checkpatch.pl" can point out that assignments should usually
  not be performed within condition checks.
  Thus move an assignment for a local variable to a separate statement
  in this function.

* Replace the specification of a data structure by a pointer dereference
  as the parameter for the operator "sizeof" to make the corresponding size
  determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller

ATM-nicstar: Improve another size determination in ns_init_card()

2016-09-11T04:45:24+00:00

Replace the specification of a data structure by a reference for a field
in a local variable as the parameter for the operator "sizeof" to make
the corresponding size determination a bit safer according to
the Linux coding style convention.

Signed-off-by: Markus Elfring 
Signed-off-by: David S. Miller