linux-toradex.git/drivers/auxdisplay/hd44780_common.c, branch v6.1

auxdisplay: Change gotoxy calling interface

2020-11-04T10:04:04+00:00

Change the calling interface for gotoxy from supplying the x and y
coordinates in the charlcd struct to explicitly supplying x and y in
the function arguments. This is more intuitive and allows for moving
the cursor to positions independent from the position saved in the
charlcd struct.

Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: hd44780_common: Reduce clear_display timeout

2020-11-04T10:04:04+00:00

Digging in the hd44780 datasheet revealed that the timeout needed after
clearing the whole display is only 1,64ms not 15ms. So we can reduce
that timeout.

Link: https://lore.kernel.org/lkml/20200922092121.GG16421@1wt.eu/
Link: https://www.crystalfontz.com/controllers/Hitachi/HD44780/433/

Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: Move char redefine code to hd44780_common

2020-11-04T10:04:04+00:00

Take the code to redefine characters out of charlcd and move it to
hd44780_common, as this is hd44780 specific.
There is now a function hd44780_common_redefine_char that drivers use
and charlcd calls it through its ops function pointer.

Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: implement various hd44780_common_ functions

2020-11-04T10:04:04+00:00

This implements various hd44780_common_ functions for hd44780 compatible
display drivers to use. charlcd then calls these functions through its
ops function pointer.
The functions namely are:
- hd44780_common_shift_cursor
- hd44780_common_display_shift
- hd44780_common_display
- hd44780_common_cursor
- hd44780_common_blink
- hd44780_common_fontsize
- hd44780_common_lines

Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: Move init_display to hd44780_common

2020-11-04T10:04:04+00:00

The init_display function is moved over to hd44780_common. charlcd uses
it via its ops function pointer and drivers initialize the ops with the
common hd44780_common_init_display function.

Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: Move clear_display to hd44780_common

2020-11-04T10:04:03+00:00

This moves the clear_display function from charlcd to hd44780_common.
This is one more step to make charlcd independent from device specific
code. The two hd44780 drivers use the new function from hd44780_common
and charlcd calls this function through its function pointer in its ops
structure.

Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: add home to charlcd_ops

2020-11-04T10:04:03+00:00

This adds a home function to the charlcd_ops struct and offer an
implementation for hd44780_common. This implementation is used by our
two hd44780 drivers. This is to make charlcd device independent.

Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: provide hd44780_common_gotoxy

2020-11-04T10:04:03+00:00

Provide a hd44780_common_gotoxy function and a pointer in the ops for
charlcd to use to move the cursor.

Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: hd44780_common_print

2020-11-04T10:04:03+00:00

We create a hd44780_common_print function. It is derived from the
original charlcd_print. charlcd_print becomes a device independent print
function, that then only calls via its ops function pointers, into the
print function offered by drivers.

Reported-by: kernel test robot 
Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda

auxdisplay: Move ifwidth to struct hd44780_common

2020-11-04T10:04:02+00:00

Move struct charlcd member ifwidth to our new struct hd44780_common.
ifwidth is hd44780 device specific and is used by two drivers at the
moment, so we move it to a common place, where both can use this.

Reviewed-by: Willy Tarreau 
Signed-off-by: Lars Poeschel 
Signed-off-by: Miguel Ojeda