linux-toradex.git/drivers/base/core.c, branch tegra-9.12.13

driver-core: fix kernel-doc parameter name

2009-01-28T23:55:48+00:00

Fix function parameter name in kernel-doc:

Warning(linux-next-20090120//drivers/base/core.c:1289): No description found for parameter 'dev'
Warning(linux-next-20090120//drivers/base/core.c:1289): Excess function parameter 'root' description in 'root_device_unregister'

Signed-off-by: Randy Dunlap 
Acked-by: Mark McLoughlin 
Signed-off-by: Greg Kroah-Hartman

driver core: Convert '/' to '!' in dev_set_name()

2009-01-21T04:52:08+00:00

Commit 3ada8b7e ("block: struct device - replace bus_id with dev_name(),
dev_set_name()") deleted the code in register_disk() that changed a '/'
to a '!' in the device name when registering a disk, but dev_set_name()
does not perform this conversion.

This leads to amusing problems with disks that have '/' in their names:
for example a failure to boot with the root partition on a cciss device,
even though the kernel says it knows about the root device:

    VFS: Cannot open root device "cciss/c0d0p6" or unknown-block(0,0)
    Please append a correct "root=" boot option; here are the available partitions:
    6800        71652960 cciss/c0d0 driver: cciss
      6802               1 cciss/c0d0p2
      6805         2931831 cciss/c0d0p5
      6806        34354908 cciss/c0d0p6
    6810        71652960 cciss/c0d1 driver: cciss

Fix this by adding code to change '/' to '!' in dev_set_name() to handle
this until dev_set_name() is converted to use kobject_set_name().

Signed-off-by: Roland Dreier 
Acked-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: create a private portion of struct device"

2009-01-09T23:06:12+00:00

This reverts commit 2831fe6f9cc4e16c103504ee09a47a084297c0f3.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: move klist_children into private structure"

2009-01-09T22:55:37+00:00

This reverts commit 11c3b5c3e08f4d855cbef52883c266b9ab9df879.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver core: add root_device_register()

2009-01-06T18:44:33+00:00

Add support for allocating root device objects which group
device objects under /sys/devices directories.

Also add a sysfs 'module' symlink which points to the owner
of the root device object. This symlink will be used in virtio
to allow userspace to determine which virtio bus implementation
a given device is associated with.

[Includes suggestions from Cornelia Huck]

Signed-off-by: Mark McLoughlin 
Signed-off-by: Greg Kroah-Hartman

Driver core: move the bus notifier call points

2009-01-06T18:44:33+00:00

This patch (as1184) changes the location of the notifications in
device_add() and device_del().  Now the BUS_NOTIFY_ADD_DEVICE message
is sent after dpm_sysfs_add(), which is necessary for clients that
want to add attributes to the power/ subdirectory.  The
BUS_NOTIFY_DEL_DEVICE message is correspondingly moved before
dpm_sysfs_remove().

Signed-off-by: Alan Stern 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver core: move klist_children into private structure

2009-01-06T18:44:32+00:00

Nothing outside of the driver core should ever touch klist_children, or
knode_parent, so move them out of the public eye.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver core: create a private portion of struct device

2009-01-06T18:44:32+00:00

This is to be used to move things out of struct device that no code
outside of the driver core should ever touch.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver core: struct device - replace bus_id with dev_name(), dev_set_name()

2009-01-06T18:44:31+00:00

Signed-off-by: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

kobject: Fix kobject_rename and !CONFIG_SYSFS

2008-10-16T16:24:52+00:00

When looking at kobject_rename I found two bugs with
that exist when sysfs support is disabled in the kernel.

kobject_rename does not change the name on the kobject when
sysfs support is not compiled in.

kobject_rename without locking attempts to check the
validity of a rename operation, which the kobject layer
simply does not have the infrastructure to do.

This patch documents the previously unstated requirement of
kobject_rename that is the responsibility of the caller to
provide mutual exclusion and to be certain that the new_name
for the kobject is valid.

This patch modifies sysfs_rename_dir in !CONFIG_SYSFS case
to call kobject_set_name to actually change the kobject_name.

This patch removes the bogus and misleading check in kobject_rename
that attempts to see if a rename is valid.  The check is bogus
because we do not have the proper locking.  The check is misleading
because it looks like we can and do perform checking at the kobject
level that we don't.

Signed-off-by: Eric W. Biederman 
Signed-off-by: Greg Kroah-Hartman