linux-toradex.git/drivers/base/driver.c, branch v2.6.32-rc3

driver model: constify attribute groups

2009-09-15T16:50:47+00:00

Let attribute group vectors be declared "const".  We'd
like to let most attribute metadata live in read-only
sections... this is a start.

Signed-off-by: David Brownell 
Signed-off-by: Greg Kroah-Hartman

Driver Core: do not oops when driver_unregister() is called for unregistered drivers

2009-05-28T21:24:07+00:00

We also fix a problem with cleaning up properly when initializing
drivers and devices, so checks like this will work successfully.

Portions of the patch by Linus and Greg and Ingo.

Reported-by: Ozan Çağlayan 
Signed-off-by: Kay Sievers 
Cc: Linus Torvalds 
Cc: Ingo Molnar 
Signed-off-by: Greg Kroah-Hartman

driver core: move knode_driver into private structure

2009-03-24T23:38:25+00:00

Nothing outside of the driver core should ever touch knode_driver, so
move it out of the public eye.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver-core: do not register a driver with bus_type not registered

2009-03-24T23:38:25+00:00

If the bus_type is not registerd, driver_register to that bus will cause oops.

I found this bug when test built-in usb serial drivers (ie. aircable driver)
with 'nousb' cmdline params.

In this patch:
1. set the bus->p=NULL when bus_register failed and unregisterd.
2. if bus->p is NULL, driver_register BUG_ON will be triggered.

Signed-off-by: Dave Young 
Signed-off-by: Greg Kroah-Hartman

Revert "driver core: move knode_driver into private structure"

2009-01-09T22:44:18+00:00

This reverts commit 93e746db183b3bdbbda67900f79b5835f9cb388f.

Turns out that device_initialize shouldn't fail silently.
This series needs to be reworked in order to get into proper
shape.

Reported-by: Stefan Richter 
Cc: Alan Cox 
Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

driver core: move knode_driver into private structure

2009-01-06T18:44:32+00:00

Nothing outside of the driver core should ever touch knode_driver, so
move it out of the public eye.

Cc: Kay Sievers 
Signed-off-by: Greg Kroah-Hartman

drivers/base/driver.c: remove unused to_dev() macro

2008-08-21T17:15:35+00:00

Signed-off-by: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

driver core: warn about duplicate driver names on the same bus

2008-04-30T23:52:47+00:00

Currently an attempt to register multiple
drivers with the same name causes the
stack trace with some cryptic error message.
The attached patch adds the necessary check
and the clear error message.

Signed-off-by: Stas Sergeev 
Signed-off-by: Greg Kroah-Hartman

driver core: fix small mem leak in driver_add_kobj()

2008-03-28T21:45:23+00:00

The Coverity checker spotted that we leak the storage allocated to 'name' in
int driver_add_kobj().  The leak looks legit to me - this is the code :

int driver_add_kobj(struct device_driver *drv, struct kobject *kobj,
                    const char *fmt, ...)
{
        va_list args;
        char *name;
        int ret;

        va_start(args, fmt);
        name = kvasprintf(GFP_KERNEL, fmt, args);
        ^^^^^^^^ This dynamically allocates space...

        va_end(args);

        if (!name)
                return -ENOMEM;

        return kobject_add(kobj, &drv->p->kobj, "%s", name);
	^^^^^^^^ This neglects to free the space allocated
}

Inside kobject_add() a copy of 'name' will be made and used.  As far as I can
see, Coverity is correct in flagging this as a leak, but I'd like some
configmation before the patch is applied.

This should fix it.

Signed-off-by: Jesper Juhl 
Cc: Greg KH 
Cc: Kay Sievers 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

driver-core: fix kernel-doc function parameters

2008-02-21T23:27:07+00:00

Fix drivers/base/ missing kernel-doc parameters:
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'drv'
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'kobj'
Warning(linux-2.6.24-git12//drivers/base/driver.c:133): No description found for parameter 'fmt'
Warning(linux-2.6.24-git12//drivers/base/power/main.c:530): No description found for parameter 'state'

Signed-off-by: Randy Dunlap 
Signed-off-by: Greg Kroah-Hartman