linux-toradex.git/drivers/base/firmware_class.c, branch v2.6.34

include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h

2010-03-30T13:02:32+00:00

percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files.  percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.

percpu.h -> slab.h dependency is about to be removed.  Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability.  As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.

  http://userweb.kernel.org/~tj/misc/slabh-sweep.py

The script does the followings.

* Scan files for gfp and slab usages and update includes such that
  only the necessary includes are there.  ie. if only gfp is used,
  gfp.h, if slab is used, slab.h.

* When the script inserts a new include, it looks at the include
  blocks and try to put the new include such that its order conforms
  to its surrounding.  It's put in the include block which contains
  core kernel includes, in the same order that the rest are ordered -
  alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
  doesn't seem to be any matching order.

* If the script can't find a place to put a new include (mostly
  because the file doesn't have fitting include block), it prints out
  an error message indicating which .h file needs to be added to the
  file.

The conversion was done in the following steps.

1. The initial automatic conversion of all .c files updated slightly
   over 4000 files, deleting around 700 includes and adding ~480 gfp.h
   and ~3000 slab.h inclusions.  The script emitted errors for ~400
   files.

2. Each error was manually checked.  Some didn't need the inclusion,
   some needed manual addition while adding it to implementation .h or
   embedding .c file was more appropriate for others.  This step added
   inclusions to around 150 files.

3. The script was run again and the output was compared to the edits
   from #2 to make sure no file was left behind.

4. Several build tests were done and a couple of problems were fixed.
   e.g. lib/decompress_*.c used malloc/free() wrappers around slab
   APIs requiring slab.h to be added manually.

5. The script was run on all .h files but without automatically
   editing them as sprinkling gfp.h and slab.h inclusions around .h
   files could easily lead to inclusion dependency hell.  Most gfp.h
   inclusion directives were ignored as stuff from gfp.h was usually
   wildly available and often used in preprocessor macros.  Each
   slab.h inclusion directive was examined and added manually as
   necessary.

6. percpu.h was updated not to include slab.h.

7. Build test were done on the following configurations and failures
   were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
   distributed build env didn't work with gcov compiles) and a few
   more options had to be turned off depending on archs to make things
   build (like ipr on powerpc/64 which failed due to missing writeq).

   * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
   * powerpc and powerpc64 SMP allmodconfig
   * sparc and sparc64 SMP allmodconfig
   * ia64 SMP allmodconfig
   * s390 SMP allmodconfig
   * alpha SMP allmodconfig
   * um on x86_64 SMP allmodconfig

8. percpu.h modifications were reverted so that it could be applied as
   a separate patch and serve as bisection point.

Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.

Signed-off-by: Tejun Heo 
Guess-its-ok-by: Christoph Lameter 
Cc: Ingo Molnar 
Cc: Lee Schermerhorn

driver-core: fix missing kernel-doc in firmware_class

2010-03-19T14:12:16+00:00

Fix kernel-doc warning in firmware_class.c:

Warning(drivers/base/firmware_class.c:94): No description found for parameter 'attr'

Signed-off-by: Randy Dunlap 
Signed-off-by: Greg Kroah-Hartman

sysfs: use sysfs_bin_attr_init in firmware class driver

2010-03-19T14:12:10+00:00

Annotate dynamic sysfs attribute in fw_setup_device(). This gets
rid of the following lockdep warning:

bnx2 0000:08:00.0: firmware: requesting bnx2/bnx2-mips-06-5.0.0.j6.fw
BUG: key ffff880008293470 not in .data!
------------[ cut here ]------------
WARNING: at kernel/lockdep.c:2706 lockdep_init_map+0x562/0x620()
Modules linked in: bnx2(+) sg tpm_bios floppy rtc_lib usb_storage i2c_piix4 joydev button container shpchp i2c_core sr_mod cdrom pci_hotplug usbhid hid ohci_hcd ehci_hcd sd_mod usbcore edd ext3 mbcache jbd fan ata_generic sata_svw pata_serverworks libata scsi_mod thermal processor
Pid: 1915, comm: work_for_cpu Not tainted 2.6.34-rc1-default #81
Call Trace:
 [] ? lockdep_init_map+0x562/0x620
 [] warn_slowpath_common+0x78/0xd0
 [] warn_slowpath_null+0xf/0x20
 [] lockdep_init_map+0x562/0x620
 [] ? sysfs_new_dirent+0x76/0x120
 [] ? put_device+0x12/0x20
 [] sysfs_add_file_mode+0x6c/0xd0
 [] sysfs_add_file+0xc/0x10
 [] sysfs_create_bin_file+0x21/0x30
 [] _request_firmware+0x2f1/0x650
 [] request_firmware+0xe/0x10
 [] bnx2_init_one+0x8f5/0x177e [bnx2]
 [] ? _raw_spin_unlock_irq+0x2b/0x40
 [] ? finish_task_switch+0x69/0x100
 [] ? finish_task_switch+0x0/0x100
 [] ? do_work_for_cpu+0x0/0x30
 [] local_pci_probe+0x12/0x20
 [] do_work_for_cpu+0x13/0x30
 [] ? do_work_for_cpu+0x0/0x30
 [] kthread+0x96/0xa0
 [] kernel_thread_helper+0x4/0x10
 [] ? restore_args+0x0/0x30
 [] ? kthread+0x0/0xa0
 [] ? kernel_thread_helper+0x0/0x10
---[ end trace a2ecee9c9602d195 ]---

Cc: Eric W. Biederman 
Cc: Greg Kroah-Hartman 
Signed-off-by: Jiri Kosina 
Signed-off-by: Greg Kroah-Hartman

Driver core: Fix first line of kernel-doc for a few functions

2010-03-08T01:04:51+00:00

The function name must be followed by a space, hypen, space, and a
short description.

Signed-off-by: Ben Hutchings 
Signed-off-by: Greg Kroah-Hartman

driver-core: firmware_class: remove base.h header inclusion

2010-03-08T01:04:49+00:00

base.h is used by base drivers for sharing internal structures.
Turns out firmware_class does not depend on it at all so remove it.

Cc: Johannes Berg 
Signed-off-by: Luis R. Rodriguez 
Acked-by: Marcel Holtmann 
Signed-off-by: Greg Kroah-Hartman

driver-core: Add attribute argument to class_attribute show/store

2010-03-08T01:04:48+00:00

Passing the attribute to the low level IO functions allows all kinds
of cleanups, by sharing low level IO code without requiring
an own function for every piece of data.

Also drivers can extend the attributes with own data fields
and use that in the low level function.

This makes the class attributes the same as sysdev_class attributes
and plain attributes.

This will allow further cleanups in drivers.

Full tree sweep converting all users.

Signed-off-by: Andi Kleen 
Signed-off-by: Greg Kroah-Hartman

firmware_class: make request_firmware_nowait more useful

2009-12-11T19:24:52+00:00

Unfortunately, one cannot hold on to the struct firmware
that request_firmware_nowait() hands off, which is needed
in some cases. Allow this by requiring the callback to
free it (via release_firmware).

Additionally, give it a gfp_t parameter -- all the current
users call it from a GFP_KERNEL context so the GFP_ATOMIC
isn't necessary. This also marks an API break which is
useful in a sense, although that is obviously not the
primary purpose of this change.

Signed-off-by: Johannes Berg 
Acked-by: Marcel Holtmann 
Cc: Ming Lei 
Cc: Catalin Marinas 
Cc: David Woodhouse 
Cc: Pavel Roskin 
Cc: Abhay Salunke 
Signed-off-by: Greg Kroah-Hartman

driver core: firmware_class:fix memory leak of page pointers array

2009-07-28T20:45:22+00:00

The page pointers array is allocated in fw_realloc_buffer() called by
firmware_data_write(), and should be freed in release function of firmware
device.

Signed-off-by: Ming Lei 
Reported-by: Catalin Marinas 
Acked-by: David Woodhouse 
Signed-off-by: Greg Kroah-Hartman

Firmware: firmware_class, fix lock imbalance

2009-07-12T20:02:10+00:00

Add omitted unlock in firmware_data_read.

Signed-off-by: Jiri Slaby 
Signed-off-by: Greg Kroah-Hartman

Free struct device in fw_dev_release()

2009-07-08T16:34:08+00:00

The f_dev in _request_firmware() is allocated via the fw_setup_device()
and fw_register_device() calls and its class set to firmware_class (the
class release function is fw_dev_release).

Commit 6acf70f078ca replaced the kfree(dev) in fw_dev_release() with a
put_device() call but my understanding is that the release function is
called via put_device -> kobject_put -> kref_put -> koject_release etc.
and it should call kfree since it's the last to see this device
structure alive.

Because of that, the _request_firmware() function on its -ENOENT error
path only calls device_unregister(f_dev) which would eventually call
fw_dev_release() but there is no kfree (the subsequent put_device call
would just make the kref negative).

Signed-off-by: Catalin Marinas 
Acked-by: Cornelia Huck 
Acked-by: Ming Lei 
Signed-off-by: Linus Torvalds