linux-toradex.git/drivers/base/firmware_class.c, branch v3.7

firmware loader: sync firmware cache by async_synchronize_full_domain

2012-10-22T15:37:18+00:00

async.c has provided synchronization mechanism on async_schedule_*,
so use async_synchronize_full_domain to sync caching firmware instead
of reinventing the wheel.

Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

firmware loader: let direct loading back on 'firmware_buf'

2012-10-22T15:37:17+00:00

Firstly 'firmware_buf' is introduced to make all loading requests
to share one firmware kernel buffer, so firmware_buf should
be used in direct loading for saving memory and speedup firmware
loading.

Secondly, the commit below

	abb139e75c2cdbb955e840d6331cb5863e409d0e(firmware:teach
	the kernel to load firmware files directly from the filesystem)

introduces direct loading for fixing udev regression, but it
bypasses the firmware cache meachnism, so this patch enables
caching firmware for direct loading case since it is still needed
to solve drivers' dependency during system resume.

Cc: Linus Torvalds 
Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

firmware loader: fix one reqeust_firmware race

2012-10-22T15:37:17+00:00

Several loading requests may be pending on one same
firmware buf, and this patch moves fw_map_pages_buf()
before complete_all(&fw_buf->completion) and let all
requests see the mapped 'buf->data' once the loading
is completed.

Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

firmware loader: cancel uncache work before caching firmware

2012-10-22T15:37:16+00:00

Under 'Opportunistic sleep' situation, system sleep might be
triggered very frequently, so the uncahce work may not be completed
before caching firmware during next suspend.

This patch cancels the uncache work before caching firmware to
fix the problem above.

Also this patch optimizes the cacheing firmware mechanism a bit by
only storing one firmware cache entry for one firmware image.

So if the firmware is still cached during suspend, it doesn't need
to be loaded from user space any more.

Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

firmware: use 'kernel_read()' to read firmware into kernel buffer

2012-10-04T16:19:02+00:00

Fengguang correctly points out that the firmware reading should not use
vfs_read(), since the buffer is in kernel space.

The vfs_read() just happened to work for kernel threads, but sparse
warns about the incorrect address spaces, and it's definitely incorrect
and could fail for other users of the firmware loading.

Reported-by: Fengguang Wu 
Signed-off-by: Linus Torvalds

firmware: teach the kernel to load firmware files directly from the filesystem

2012-10-03T22:58:32+00:00

This is a first step in allowing people to by-pass udev for loading
device firmware.  Current versions of udev will deadlock (causing us to
block for the 30 second timeout) under some circumstances if the
firmware is loaded as part of the module initialization path, and this
is causing problems for media drivers in particular.

The current patch hardcodes the firmware path that udev uses by default,
and will fall back to the legacy udev mode if the firmware cannot be
found there.  We'd like to add support for both configuring the paths
and the fallback behaviour, but in the meantime this hopefully fixes the
immediate problem, while also giving us a way forward.

[ v2: Some VFS layer interface cleanups suggested by Al Viro ]
[ v3: use the default udev paths suggested by Kay Sievers ]

Suggested-by: Ivan Kalvachev 
Acked-by: Greg KH 
Acked-by: Al Viro 
Cc: Mauro Carvalho Chehab 
Cc: Kay Sievers 
Cc: Ming Lei 
Signed-off-by: Linus Torvalds

firmware loader: fix compile warning when CONFIG_PM=n

2012-09-10T23:40:30+00:00

This patch replaces the previous macro of CONFIG_PM with
CONFIG_PM_SLEEP becasue firmware cache is only used in
system sleep situations.

Also this patch fixes the below compile warning when
CONFIG_PM=n:

	drivers/base/firmware_class.c:1147: warning: 'device_cache_fw_images'
	defined but not used
	drivers/base/firmware_class.c:1212: warning:
	'device_uncache_fw_images_delay' defined but not used

Reported-by: Andrew Morton 
Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

firmware loader: let caching firmware piggyback on loading firmware

2012-09-06T21:46:16+00:00

After starting caching firmware, there is still some time left
before devices are suspended, during the period, request_firmware
or its nowait version may still be triggered by the below situations
to load firmware images which can't be cached during suspend/resume
cycle.

	- new devices added
	- driver bind
	- or device open kind of things

This patch utilizes the piggyback trick to cache firmware for
this kind of situation: just increase the firmware buf's reference
count and add the fw name entry into cache entry list after starting
caching firmware and before syscore_suspend() is called.

Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

firmware loader: fix firmware -ENOENT situations

2012-09-06T21:46:16+00:00

If the requested firmware image doesn't exist, firmware->priv
should be set for the later concurrent requests, otherwise
warning and oops will be triggered inside firmware_free_data().

Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

firmware loader: fix build failure if FW_LOADER is m

2012-08-17T14:37:35+00:00

device_cache_fw_images need to iterate devices in system,
so this patch applies the introduced dpm_for_each_dev to
avoid link failure if CONFIG_FW_LOADER is m.

Reported-by: Fengguang Wu 
Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman