linux-toradex.git/drivers/base/firmware_class.c, branch v4.16

driver core: add SPDX identifiers to all driver core files

2017-12-07T17:36:43+00:00

It's good to have SPDX identifiers in all files to make it easier to
audit the kernel tree for correct licenses.

Update the driver core files files with the correct SPDX license
identifier based on the license text in the file itself.  The SPDX
identifier is a legally binding shorthand, which can be used instead of
the full boiler plate text.

This work is based on a script and data from Thomas Gleixner, Philippe
Ombredanne, and Kate Stewart.

Cc: Johannes Berg 
Cc: "Luis R. Rodriguez" 
Cc: William Breathitt Gray 
Cc: Thomas Gleixner 
Cc: Kate Stewart 
Cc: Philippe Ombredanne 
Signed-off-by: Greg Kroah-Hartman

firmware: replace #ifdef over FW_OPT_FALLBACK with function checks

2017-11-29T10:18:43+00:00

Its not easy to follow the logic behind making FW_OPT_FALLBACK map
to an existing flag only if a kernel configuration option was set.
Its much easier to retpresent what was intended with function helpers
which make it clear that if CONFIG_FW_LOADER_USER_HELPER_FALLBACK is
set we force running the fallback mechanism unless a caller specifically
never wants to run it, such as request_firmware_direct().

Prior and after this change we upkeep the tradition:

CONFIG_FW_LOADER_USER_HELPER_FALLBACK
	request_firmware() force fallback
	request_firmware_into_buf() force fallback
	request_firmware_nowait() force fallback
	request_firmware_direct() always ignore fallback

!CONFIG_FW_LOADER_USER_HELPER_FALLBACK
	request_firmware() ignore fallback
	request_firmware_into_buf() ignore fallback
	request_firmware_nowait() depends on uevent flag
	request_firmware_direct() always ignore fallback

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

firmware: provide helper for FW_OPT_USERHELPER

2017-11-29T10:18:43+00:00

The macro FW_OPT_USERHELPER is only currently defined when
CONFIG_FW_LOADER_USER_HELPER is set. This is handled via an
ifdef around CONFIG_FW_LOADER_USER_HELPER. This makes reading
and understanding use FW_OPT_USERHELPER a bit convoluted.

Instead wrap the functionality implemented behind
CONFIG_FW_LOADER_USER_HELPER as we typically do in the
kernel.

Now when CONFIG_FW_LOADER_USER_HELPER is *not set*, then
simply the helper fw_sysfs_fallback() will not do anything.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

firmware: add helper to copy built-in data to pre-alloc buffer

2017-11-29T10:18:43+00:00

This makes it clearer that the parameters passed are only used for
the preallocated buffer option, ie, when a caller uses:

	request_firmware_into_buf()

Otherwise this code won't run. We flip the logic just so the actual
prellocated buf code is not indented.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

firmware: use static inline for to_fw_priv()

2017-11-29T10:18:43+00:00

This lets us type check the callers.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

firmware: rename sysfs state checks with sysfs prefix

2017-11-29T10:18:43+00:00

Doing this makes it clearer the states are only to be used
in the context of the sysfs fallback loading interface.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

firmware: use static inlines for state machine checking

2017-11-29T10:18:43+00:00

This will allow us to do proper typechecking on users both of
values passed and return types expected.

While at it, change the parameter passed to be the struct fw_priv,
so we can move around the state machine variable as we see fit with
these helpers.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

firmware: remove unused __fw_state_is_done()

2017-11-29T10:10:50+00:00

After commit e44565f62a ("firmware: fix batched requests - wake all waiters")
where we moved away from swait to old wait with a completion we also
stopped using __fw_state_is_done(). Since this is longer used kill it.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

firmware: remove duplicate fw_state_aborted()

2017-11-29T10:10:50+00:00

The macro is defined twice without need.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman

firmware: move core data structures to the top of file

2017-11-29T10:10:50+00:00

Move main core data structures used internally for firmware to the top
of the file. This will allow us to use them earlier later in helpers as
we extend their use.

Signed-off-by: Luis R. Rodriguez 
Signed-off-by: Greg Kroah-Hartman